zancas [Fri, 10 Oct 2014 02:37:32 +0000 (20:37 -0600)]
Do not report 'size' metadata if get_size returns None
zancas [Tue, 7 Oct 2014 23:36:03 +0000 (17:36 -0600)]
exercise all branches of new helper "get_filenode_metadata"
Note fix following issues from origial commit:
refactor unittests, fix style, add test
(0) use CommonFixture as mixin to increase DRYness
(1) self.failUnlessIn('size', metadata.keys()) --> self.failUnlessIn('size', metdata)
(2) test_size_is_not_None --> test_size_is_0 AND test_size_is_1000
zancas [Tue, 7 Oct 2014 19:11:31 +0000 (13:11 -0600)]
refactor get_filenode_metadata(...) into common.py
amontero [Mon, 9 Dec 2013 11:27:04 +0000 (12:27 +0100)]
Add pkg-config directory to .gitignore
Daira Hopwood [Sat, 13 Sep 2014 09:58:55 +0000 (10:58 +0100)]
Merge pull request #109 from warner/2023-caution
Avoid Popen() of executables that don't exist
Brian Warner [Thu, 11 Sep 2014 20:13:42 +0000 (13:13 -0700)]
Avoid Popen() of executables that don't exist
The stdlib 'subprocess' module in python-2.7.4 through 2.7.7 suffers
from http://bugs.python.org/issue18851 which causes unrelated file
descriptors to be closed when `subprocess.call()` fails the `exec()`,
such as when the executable being invoked does not actually exist. There
appears to be some randomness involved. This was fixed in python-2.7.8.
Tahoe's iputil.py uses subprocess.call on many different "ifconfig"-type
executables, most of which don't exist on any given platform (added in
git commit
8e31d66cd0b). This results in a lot of file-descriptor
closing, which (at least during unit tests) tends to clobber important
things like Tub TCP sockets. This seems to be the root cause behind
ticket:2121, in which normal code tries to close already-closed sockets,
crashing the unit tests. Since different platforms have different
ifconfigs, some platforms will experience more failed execs than others,
so this bug could easily behave differently on linux vs freebsd, as well
as working normally on python-2.7.8 or 2.7.4.
This patch inserts a guard to make sure that os.path.isfile() is true
before allowing Popen.call() to try executing the target. This ought to
be enough to avoid the bug. It changes both iputil.py and
allmydata.__init__ (which uses Popen for calling "lsb_release"), which
are all the places where 'subprocess' is used outside of unit tests.
Other potential fixes: use the 'subprocess32' module from PyPI (which is
a bug-free backport of the Python3 stdlib subprocess module, but would
introduce a new dependency), or require python >= 2.7.8 (but this would
rule out development/deployment on the current OS-X 10.9 release, which
ships with 2.7.5, as well as other distributions like Ubuntu 14.04 LTS).
I believe this closes ticket:2121, and given the apparent relationship
between 2121 and 2023, I think it also closes ticket:2023 (although
since 2023 doesn't have copies of the failing log files, it's hard to
tell). I'm hoping that this will tide us over until 1.11 is released, at
which point we can execute on the plan to remove iputil.py entirely by
changing the way that nodes learn their externally-facing IP address.
Brian Warner [Fri, 12 Sep 2014 19:55:52 +0000 (12:55 -0700)]
test_disk_stats: tolerate used==0 for a Travis worker bug
Some Travis-CI workers report persistently empty disks, causing spurious
test failures. It's not really that important to assert used>0, so this
relaxes the test.
Closes ticket:2290
Brian Warner [Fri, 12 Sep 2014 19:14:29 +0000 (12:14 -0700)]
travis: show os.statvfs before build, to investigate #2290
Brian Warner [Fri, 12 Sep 2014 04:32:27 +0000 (21:32 -0700)]
welcome.xhtml: explain MDMF too
Scott Arciszewski [Fri, 15 Aug 2014 22:35:33 +0000 (18:35 -0400)]
Update welcome.xhtml
Add a tooltip to explain what SDMF means. Cannot find a definition for MDMF; I presume "Medium" but at the risk of being wrong, I don't want to just blindly make that suggested change.
Daira Hopwood [Tue, 9 Sep 2014 17:51:44 +0000 (18:51 +0100)]
Rename README.txt to README.rst, and add Travis-CI and Coveralls badges to it.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Brian Warner [Tue, 9 Sep 2014 17:31:05 +0000 (10:31 -0700)]
Makefile: remove 'twisted' from SOURCES
Brian Warner [Tue, 9 Sep 2014 00:27:20 +0000 (17:27 -0700)]
coverage2el.py: update to current coverage-3.7.1 API
Daira Hopwood [Tue, 9 Sep 2014 12:31:19 +0000 (13:31 +0100)]
Merge pull request #107 from warner/2281-trialcoverage
Remove 'trialcoverage' plugin and support code
Brian Warner [Tue, 9 Sep 2014 00:28:26 +0000 (17:28 -0700)]
Remove 'trialcoverage' plugin and support code
Closes ticket:2281 (trac).
This removes src/allmydata/test/trial_coverage.py, which was a
in-process way to run trial tests under the "coverage" code-coverage
tool. These days, the preferred way to do this is with "coverage run",
although the actual invocation is a bit messy because of the way
bin/trial uses subprocess.call() to invoke the real entrypoint script
with the right PYTHONPATH (see #1698 for details). Hopefully this will
be improved to use a simpler "coverage run .." command in the future.
This patch also removes twisted/plugins/allmydata_trial.py, which
enabled the "--reporter=bwverbose-coverage" option. Finally it modifies
setup.py to stop looking for that option and adding "trialcoverage" to
the dependencies list, which gets us closer to removing "setup_requires"
entirely.
Daira Hopwood [Mon, 8 Sep 2014 21:49:54 +0000 (22:49 +0100)]
Update .PHONY declarations in Makefile.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 8 Sep 2014 21:49:23 +0000 (22:49 +0100)]
Update coverage-related targets in Makefile. refs #1698
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 8 Sep 2014 21:47:31 +0000 (22:47 +0100)]
Delete useless stuff from Makefile.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 8 Sep 2014 21:45:24 +0000 (22:45 +0100)]
Add a --coverage option to 'python setup.py test' and 'python setup.py trial'. refs #1698
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Brian Warner [Fri, 5 Sep 2014 05:05:08 +0000 (22:05 -0700)]
remove obsolete debian-package building tools
setup.py: stop sometimes-depending upon 'stdeb'
setup.cfg: don't try to alias 'sdist_dsc'
misc/build_helpers/build-deb.py: delete this, it was really old anyways
Closes ticket:2282 (trac).
Brian Warner [Wed, 3 Sep 2014 01:50:48 +0000 (18:50 -0700)]
Merge branch markberger/ticket-2008
This changes test_upload.py to delete-all-shares more gently, leaving
the 'incoming' directory in place, which should help the rest of the
test pass.
Closes tahoe-lafs/tahoe-lafs#50 (github PR)
Closes ticket:2008 (trac)
Mark Berger [Mon, 24 Jun 2013 22:32:27 +0000 (18:32 -0400)]
Removes unnecessary import
Mark Berger [Mon, 24 Jun 2013 22:30:26 +0000 (18:30 -0400)]
Fixes tests which were improperly deleting shares
Mark Berger [Mon, 24 Jun 2013 22:28:05 +0000 (18:28 -0400)]
Adds delete_all_shares
Mark Berger [Mon, 24 Jun 2013 20:44:40 +0000 (16:44 -0400)]
Deletes shares from server 0 correctly
Deletes the shares from server 0 without setting the remaining
size to 0
Brian Warner [Wed, 3 Sep 2014 01:32:27 +0000 (18:32 -0700)]
Makefile: fix test-clean by using 'distclean'
Brian Warner [Wed, 3 Sep 2014 01:22:59 +0000 (18:22 -0700)]
check_memory: stop using long-deprecated twisted internals
Brian Warner [Tue, 2 Sep 2014 21:01:24 +0000 (14:01 -0700)]
Merge branch tarcieri/redesigned-directory-page
Closes ticket:1966 (trac)
Closes tahoe-lafs/tahoe-lafs#32 (github PR)
Leif Ryge [Fri, 30 Aug 2013 19:57:38 +0000 (19:57 +0000)]
add a <br>
Mark J. Berger [Fri, 30 Aug 2013 14:03:58 +0000 (10:03 -0400)]
Updates webui directory forms
Leif Ryge [Sat, 27 Apr 2013 08:49:07 +0000 (08:49 +0000)]
make tests pass with redesigned directory pages
Tony Arcieri [Thu, 14 Mar 2013 17:04:18 +0000 (10:04 -0700)]
Redesigned directory pages (WIP)
This is an initial conversion of the directory pages from the old style
to the new style which is based on Twitter Bootstrap.
Still some remaining work to be done. You can see a screenshot here:
http://i.imgur.com/MPEngGx.png
Brian Warner [Tue, 2 Sep 2014 20:44:53 +0000 (13:44 -0700)]
welcome page: improve CSS slightly for narrow windows
Thanks to tarcieri for the patch.
refs ticket:1931
Brian Warner [Tue, 2 Sep 2014 20:32:59 +0000 (13:32 -0700)]
publish.py: log roothash in base32, not binary
Closes ticket:1800
Brian Warner [Tue, 2 Sep 2014 19:59:32 +0000 (12:59 -0700)]
Merge branch markberger/712-tahoe-cp-doesnt-copy-dir
Closes ticket:712 (trac).
Closes tahoe-lafs/tahoe-lafs#56 (github PR).
Brian Warner [Tue, 2 Sep 2014 19:40:21 +0000 (12:40 -0700)]
CLI.rst: expand the 'cp -r' subdirectory example
Mark J. Berger [Tue, 27 Aug 2013 15:54:33 +0000 (11:54 -0400)]
Documentation updates
Mark Berger [Mon, 5 Aug 2013 15:53:44 +0000 (11:53 -0400)]
Fix tests which relied on the old behavior of tahoe cp -r
Mark Berger [Mon, 5 Aug 2013 15:53:07 +0000 (11:53 -0400)]
tahoe cp -r now copies the top level directory with its children
Mark Berger [Mon, 5 Aug 2013 13:05:05 +0000 (09:05 -0400)]
Adds test_cli.Cp.test_cp_copies_dir
Daira Hopwood [Tue, 2 Sep 2014 18:40:21 +0000 (19:40 +0100)]
Update copyright year.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 2 Sep 2014 18:37:06 +0000 (19:37 +0100)]
Reference README.txt from License section of docs/about.rst, rather than duplicating the license info. fixes #2067
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 2 Sep 2014 14:08:58 +0000 (15:08 +0100)]
.travis.yml: okay, fetching just tags apparently isn't sufficient (and this use of 'git pull' won't actually pull any new commits, because we'll be on a detached head).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 2 Sep 2014 13:48:07 +0000 (14:48 +0100)]
.travis.yml: make sure that we only fetch tags and don't change the requested commit.
Daira Hopwood [Tue, 2 Sep 2014 13:36:19 +0000 (14:36 +0100)]
.travis.yml: really fix command used for testing.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 1 Sep 2014 20:12:53 +0000 (21:12 +0100)]
Suppress a DeprecationWarning from Twisted.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 1 Sep 2014 19:57:22 +0000 (20:57 +0100)]
.travis.yml: fix command used for testing.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
travis-tahoe [Mon, 1 Sep 2014 18:39:57 +0000 (19:39 +0100)]
Suppress all UserWarnings, not just ones with known messages. refs #2248
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
travis-tahoe [Mon, 1 Sep 2014 18:10:32 +0000 (19:10 +0100)]
Suppress warning about service_identity. fixes #2248
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
travis-tahoe [Mon, 1 Sep 2014 18:04:10 +0000 (19:04 +0100)]
Revert previous patch; service_identity has too many subdependencies.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
travis-tahoe [Mon, 1 Sep 2014 17:46:39 +0000 (18:46 +0100)]
Add service_identity as a dependency. fixes #2248
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 1 Sep 2014 17:08:36 +0000 (18:08 +0100)]
.travis.yml: correct the --source argument to coverage (it should be a directory, not a module name).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 1 Sep 2014 16:47:43 +0000 (17:47 +0100)]
.travis.yml: Make sure that update_version has enough history to see the last release tag.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 1 Sep 2014 15:50:51 +0000 (16:50 +0100)]
.travis.yml: install Twisted explicitly to work around #2249.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 1 Sep 2014 14:29:13 +0000 (15:29 +0100)]
Support coverage reporting via coverage.io. refs #623
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Fri, 22 Aug 2014 14:54:53 +0000 (15:54 +0100)]
Document ways to use LAFS as a key-value store.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
zooko [Tue, 19 Aug 2014 18:33:17 +0000 (18:33 +0000)]
Merge pull request #103 from zooko/2280-recommend-tahoe-backup_3
2280 recommend tahoe backup 3
Zooko Wilcox-O'Hearn [Tue, 19 Aug 2014 18:24:38 +0000 (18:24 +0000)]
formatting fixes
Zooko Wilcox-O'Hearn [Tue, 19 Aug 2014 18:18:33 +0000 (18:18 +0000)]
recommend `tahoe backup`
and, explain some of why it is awesome, and link to
`<docs/frontends/CLI.rst>`__.
Daira Hopwood [Sun, 17 Aug 2014 14:32:17 +0000 (15:32 +0100)]
test_runner: rename *_FILE variables to lowercase, because they are not constants.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Sun, 17 Aug 2014 14:36:57 +0000 (15:36 +0100)]
Better name for the file that causes a node to exit after a timeout when running unit tests. refs #1336
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Thu, 7 Aug 2014 14:30:00 +0000 (15:30 +0100)]
Merge pull request #96 from zooko/warn-about-FUSE-performance
add warning about performance problems with FUSE
Daira Hopwood [Thu, 7 Aug 2014 14:26:29 +0000 (15:26 +0100)]
Merge pull request #95 from zooko/remove-obsolete-comment
remove obsolete comment
Zooko Wilcox-O'Hearn [Tue, 5 Aug 2014 20:50:30 +0000 (20:50 +0000)]
add warning about performance problems with FUSE
Zooko Wilcox-O'Hearn [Tue, 5 Aug 2014 16:36:59 +0000 (16:36 +0000)]
remove obsolete comment
zooko [Tue, 22 Jul 2014 06:27:25 +0000 (06:27 +0000)]
Merge pull request #94 from zooko/link-to-Twisted-ticket-4633
link to Twisted ticket #4633
Zooko Wilcox-O'Hearn [Tue, 22 Jul 2014 05:16:04 +0000 (05:16 +0000)]
link to Twisted ticket #4633
Brian Warner [Wed, 2 Jul 2014 20:11:28 +0000 (13:11 -0700)]
Merge branch 'pr6'
pataquets [Sat, 7 Jul 2012 17:23:10 +0000 (20:23 +0300)]
Update adding comments as seen in https://tahoe-lafs.org/pipermail/tahoe-dev/2012-May/007365.html
Found it useful. I can't see here clearly if deleting backupdb will affect deduplication and I'd like to clarify here, anyway. Do deduplication depend on backupdb data? TIA.
Brian Warner [Mon, 23 Jun 2014 20:54:07 +0000 (13:54 -0700)]
hush current pyflakes warnings (list comprehensions)
closes #2245
zooko [Mon, 12 May 2014 22:06:33 +0000 (22:06 +0000)]
Merge pull request #91 from zooko/master
misc/build_helpers/show-tool-versions.py: print out more version information about dependencies and tools
Zooko Wilcox-O'Hearn [Mon, 12 May 2014 21:51:03 +0000 (21:51 +0000)]
add print_py_pkg_ver for all deps
Including probable-near-future-transitive deps due to the new pyOpenSSL…
Daira Hopwood [Mon, 5 May 2014 22:17:51 +0000 (23:17 +0100)]
Fix a pyflakes warning.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 5 May 2014 22:14:48 +0000 (23:14 +0100)]
Improve error reporting for '#' characters in config entries. refs #2128
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 5 May 2014 22:05:06 +0000 (23:05 +0100)]
Fix a shallow bug.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 5 May 2014 21:55:50 +0000 (22:55 +0100)]
Error if a .furl config entry contains an unescaped '#'. fixes #2128
Author: Andrew Miller <amiller@dappervision.com>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 5 May 2014 21:09:33 +0000 (22:09 +0100)]
Revert [
603f5eba32c98d4bfbc354530dcd36dfcd58887a] which was applied unintentionally.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Wed, 7 Aug 2013 20:11:21 +0000 (21:11 +0100)]
Fix #2048 (test_copy_using_filecap was doing much more work than necessary).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Wed, 7 Aug 2013 20:07:57 +0000 (21:07 +0100)]
Fix comments in test_copy_using_filecap to reflect what the tests actually do.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Sun, 4 May 2014 16:05:48 +0000 (17:05 +0100)]
Use "long" paths prefixed with \\?\ on Windows. refs #2235
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Brian Warner [Fri, 25 Apr 2014 23:16:05 +0000 (16:16 -0700)]
Include unminified versions of d3+jquery. Addresses #2208.
This should hopefully satisfy the Debian requirement to include original
sources. The old minified files for d3 and jquery were 63k and 91k
respectively, while the new unminified files are 133k and 293k.
Brian Warner [Fri, 25 Apr 2014 22:26:23 +0000 (15:26 -0700)]
release docs: recommend Twine for package upload. Closes #2086.
Daira Hopwood [Mon, 14 Apr 2014 22:34:39 +0000 (23:34 +0100)]
Minor comment fix. refs #1847
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 21 Apr 2014 21:40:28 +0000 (22:40 +0100)]
Remove ugly shadowing of Client.DEFAULT_ENCODING_PARAMETERS. fixes #1847
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Zooko Wilcox-O'Hearn [Tue, 15 Apr 2014 16:24:36 +0000 (16:24 +0000)]
remove lzip, add cffi, cryptography.io
Zooko Wilcox-O'Hearn [Fri, 11 Apr 2014 14:34:01 +0000 (14:34 +0000)]
remove darcs tools from show-tool-versions
zooko [Sun, 30 Mar 2014 00:11:31 +0000 (00:11 +0000)]
Merge pull request #87 from daira/2209-make-pip-install-img-dir
setup.py: include data files in package_data= with paths relative to src/allmydata/web.
Daira Hopwood [Sat, 29 Mar 2014 00:41:33 +0000 (00:41 +0000)]
setup.py: include data files in package_data= with paths relative to src/allmydata/web.
Remove packages= entries and unneeded __init__.py files for those subdirectories.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Thu, 20 Mar 2014 16:13:57 +0000 (16:13 +0000)]
Remove 'needs-rebalancing' and add 'count-happiness' to checker reports; repair tests. fixes #1784, #2105
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Sat, 15 Mar 2014 22:17:03 +0000 (22:17 +0000)]
Update my CREDITS entry.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 25 Feb 2014 16:57:57 +0000 (16:57 +0000)]
misc/simulators/hashbasedsig.py: revert last patch; the original code was correct.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 25 Feb 2014 16:55:19 +0000 (16:55 +0000)]
misc/simulators/hashbasedsig.py: fix minor miscalculation bug.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 25 Feb 2014 01:04:03 +0000 (01:04 +0000)]
misc/simulators/hashbasedsig.py: the cost of labels was being double-counted.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 25 Feb 2014 00:58:38 +0000 (00:58 +0000)]
misc/simulators/hashbasedsig.py: fix an incorrect comment.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 24 Feb 2014 20:23:39 +0000 (20:23 +0000)]
Use bigger random one-time keys in timing_safe_compare. fixes #2165
Follows this advice from Marsh Ray and Solar Designer: https://twitter.com/zooko/status/
431105294777597952
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 24 Feb 2014 20:21:24 +0000 (20:21 +0000)]
Rename 'constant_time_compare' to 'timing_safe_compare'. refs #2165
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Sun, 12 Jan 2014 22:02:56 +0000 (14:02 -0800)]
Merge pull request #85 from leif/isolate-keygen-test
Isolate test_keygen in its own base directory. This also causes KeyGeneratorService to create its base directory if it does not exist.
Leif Ryge [Sun, 12 Jan 2014 21:22:34 +0000 (21:22 +0000)]
isolate test_keygen data
This makes test_keygen use its own basedir, to avoid polluting the _trial_temp
directory for later tests.
Daira Hopwood [Sun, 12 Jan 2014 18:30:37 +0000 (10:30 -0800)]
Merge pull request #84 from kpreid/patch-1
Change kpreid's email address.
Kevin Reid [Sat, 11 Jan 2014 17:39:51 +0000 (09:39 -0800)]
Change kpreid's email address.