Brian Warner [Thu, 25 Apr 2013 00:12:16 +0000 (17:12 -0700)]
NEWS: edits, formatting, consolidation, set a date for 1.10.0
Brian Warner [Thu, 25 Apr 2013 00:00:18 +0000 (17:00 -0700)]
NEWS: fix a formatting typo
Brian Warner [Wed, 24 Apr 2013 23:56:29 +0000 (16:56 -0700)]
NEWS: improve highlighting
It looks like github's ReST renderer shows ''' with more emphasis than
---, so use ''' for release names, and --- for groups of changes within
a given release.
Brian Warner [Wed, 24 Apr 2013 22:20:47 +0000 (15:20 -0700)]
Makefile: oops, fix tahoe-deps/tahoe-lafs-deps mismatch
which broke fetch-and-unpack-deps
Brian Warner [Wed, 24 Apr 2013 21:58:27 +0000 (14:58 -0700)]
update deps URLs to use "tahoe-lafs" instead of bare "tahoe"
Brian Warner [Wed, 24 Apr 2013 15:58:40 +0000 (08:58 -0700)]
update some copyright dates
Brian Warner [Wed, 24 Apr 2013 07:18:43 +0000 (00:18 -0700)]
known_issues.rst: get closer to real date
Brian Warner [Tue, 23 Apr 2013 23:39:53 +0000 (16:39 -0700)]
known_issues: update chart-API text, with suggestions from Leif. refs #1942
Daira Hopwood [Mon, 22 Apr 2013 15:10:48 +0000 (16:10 +0100)]
Add "[global-opts]" to help synopsis for tahoe ls. refs #166
Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org>
Daira Hopwood [Mon, 22 Apr 2013 15:04:49 +0000 (16:04 +0100)]
NEWS: add entry for ref #166
Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org>
Brian Warner [Mon, 22 Apr 2013 06:01:25 +0000 (23:01 -0700)]
docs/nodekeys.rst: explain what node keys are for, with compatibility notes
Daira Hopwood [Thu, 18 Apr 2013 22:42:51 +0000 (23:42 +0100)]
Add comments and a caveat in webapi.rst indicating that
the needs-rebalancing field may be computed incorrectly. refs #1115, #1784, #1477
Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org>
Daira Hopwood [Thu, 18 Apr 2013 22:41:41 +0000 (23:41 +0100)]
Minor improvements to webapi.rst.
Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org>
Leif Ryge [Wed, 10 Apr 2013 00:13:37 +0000 (00:13 +0000)]
docs: fixed typos
Brian Warner [Thu, 18 Apr 2013 15:52:33 +0000 (08:52 -0700)]
whitespace change to trigger buildbot for 1.10-b1
Brian Warner [Thu, 18 Apr 2013 07:06:55 +0000 (00:06 -0700)]
client.py: create node key even when storage is disabled. Closes #1945.
Thanks to Leif for the catch!
Daira Hopwood [Thu, 18 Apr 2013 03:34:01 +0000 (04:34 +0100)]
docs/quickstart.rst: update Python 2.7 download URL.
Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org>
Daira Hopwood [Thu, 18 Apr 2013 03:30:19 +0000 (04:30 +0100)]
docs/quickstart.rst: update recommended Python version.
Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org>
Daira Hopwood [Mon, 15 Apr 2013 18:30:49 +0000 (19:30 +0100)]
Improve a test for ref #1643, and make sure that unexpected URIs actually raise AssertionError.
Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org>
Brian Warner [Mon, 15 Apr 2013 05:27:03 +0000 (22:27 -0700)]
known_issues: document the google-chart-API privacy leak. Refs #1942.
Brian Warner [Sun, 14 Apr 2013 21:32:13 +0000 (14:32 -0700)]
welcome page: display new nodeid (
ed25519-based) instead of old tubid
The old tubid is displayed in a tooltip. Also cleaned up the regexps in
the relevant tests.
Brian Warner [Sun, 14 Apr 2013 21:03:34 +0000 (14:03 -0700)]
client.py: remove the old "server.privkey" fallback
For a brief while (in between releases 1.9 and 1.10, specifically from
revision
bc21726 on 12-Mar-2012, until
bf416af on 10-Jun-2012), the new
introducer code stored its node key in NODEDIR/private/server.privkey .
After that point, it was updated to store this key in
NODEDIR/private/node.privkey instead. Fallback code was added to read
from the old location if present (so that folks using development
versions could keep their node keys after the
bf416af change).
This patch removes the fallback code. If you have a node which was run
under a version of Tahoe within this range, you need to manually update
your node by running:
mv NODEDIR/private/server.privkey NODEDIR/private/node.privkey
and then restart the node. If you accidentally start an older node with
code after this patch, it will create a new key (and other peers will
think a new server has appeared). You can either stick with the new key,
or use the command above to switch back to the old key.
See docs/nodekeys.rst (not yet written) for details about the node key
and how it is used.
Brian Warner [Sun, 14 Apr 2013 20:22:10 +0000 (13:22 -0700)]
client.py: internal renaming, _server_key -> _node_key
Brian Warner [Sun, 14 Apr 2013 20:03:55 +0000 (13:03 -0700)]
test_sftp.py: minor cosmetic changes
Brian Warner [Fri, 12 Apr 2013 16:22:15 +0000 (17:22 +0100)]
CLI: tolerate caps-from-future in unused aliases. Closes #1643.
Brian Warner [Tue, 9 Apr 2013 19:19:58 +0000 (20:19 +0100)]
docs: replace emdash characters with plain ASCII
Brian Warner [Tue, 9 Apr 2013 19:09:37 +0000 (20:09 +0100)]
test_cli: probably remove the unix-ism that broke tests on windows
Brian Warner [Tue, 9 Apr 2013 19:04:12 +0000 (20:04 +0100)]
Remove the whitespace reported by find-trailing-spaces. No code changes.
Brian Warner [Mon, 18 Jun 2012 17:44:39 +0000 (10:44 -0700)]
CLI: put "[global-opts]" in all command synopses
Brian Warner [Mon, 18 Jun 2012 17:44:26 +0000 (10:44 -0700)]
rename VDriveOptions to FilesystemOptions
Brian Warner [Mon, 18 Jun 2012 17:43:49 +0000 (10:43 -0700)]
bin/tahoe: clean up global-vs-subcommand arguments like --node-directory
The new rules for "bin/tahoe ARG1.. SUBCOMMAND ARG2.." arg:
* --node-directory is only accepted in ARG1, not ARG2
* create-*/start/stop/restart accept --basedir in ARG2, or an explicit
basedir argument
* only one of --node-directory/--basedir/explicit-basedir is accepted
* --quiet/--version is only accepted in ARG1, not ARG2
Closes #166
Zooko O'Whielacronx [Tue, 9 Apr 2013 06:48:23 +0000 (00:48 -0600)]
s/node/client; mention restart is needed
Zooko O'Whielacronx [Tue, 9 Apr 2013 05:33:42 +0000 (23:33 -0600)]
convergence secret doc by CtB, marlowe, zooko
Zooko O'Whielacronx [Tue, 9 Apr 2013 13:08:17 +0000 (07:08 -0600)]
attempt to clarify move-vs-relink
Brian Warner [Thu, 4 Apr 2013 20:50:00 +0000 (13:50 -0700)]
ServerMap.copy(): deepcopy .update_data too. Closes #1785.
This was apparently unused, but good to copy for completeness. Tests
pass with and without the change.
Brian Warner [Tue, 9 Apr 2013 11:06:52 +0000 (12:06 +0100)]
webapi.rst: small edits to the t=relink section
Daira Hopwood [Fri, 5 Apr 2013 05:11:27 +0000 (06:11 +0100)]
docs/frontends/webapi.rst: cosmetics.
Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org>
Daira Hopwood [Fri, 5 Apr 2013 05:36:14 +0000 (06:36 +0100)]
Change web-API to support t=relink instead of t=move (+ docs and tests). fixes #1732
Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org>
Daira Hopwood [Fri, 5 Apr 2013 04:47:46 +0000 (05:47 +0100)]
NEWS.rst: remove redundant descriptions of security fixes.
Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org>
Zooko O'Whielacronx [Thu, 4 Apr 2013 23:39:08 +0000 (17:39 -0600)]
edit for clarity
Brian Warner [Thu, 4 Apr 2013 20:47:14 +0000 (13:47 -0700)]
relnotes: soften compatibility claims until we have test infrastructure for them
Closes #1773
Daira Hopwood [Wed, 3 Apr 2013 20:57:32 +0000 (21:57 +0100)]
docs/man/tahoe.1: fix typo and copyright date.
Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org>
Daira Hopwood [Wed, 3 Apr 2013 04:19:04 +0000 (05:19 +0100)]
NEWS.rst: security improvements and other minor updates.
Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org>
pataquets [Tue, 2 Apr 2013 17:46:52 +0000 (20:46 +0300)]
Fix URL links to source docs at github
Brian Warner [Mon, 1 Apr 2013 06:12:41 +0000 (23:12 -0700)]
NEWS: merge in the rest
Brian Warner [Mon, 1 Apr 2013 06:09:54 +0000 (23:09 -0700)]
NEWS: merge in most items
David-Sarah Hopwood [Thu, 28 Mar 2013 05:21:55 +0000 (05:21 +0000)]
Include allmydata/web/static/css/*.css files in install.
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
Brian Warner [Wed, 27 Mar 2013 23:43:36 +0000 (16:43 -0700)]
NEWS: add unsorted recent entries. I think that's all of them.
This list includes the changes made between 1.9.0 and the 1.9.2 darcs
release. There are also lots of non-user-visible changes, but NEWS
doesn't need to include them.
David-Sarah Hopwood [Tue, 26 Mar 2013 19:23:27 +0000 (19:23 +0000)]
CREDITS: change my name.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Brian Warner [Tue, 26 Mar 2013 00:57:01 +0000 (17:57 -0700)]
resurrect provisioning.py
It looks like commit
916d26e7103208fa207259d62ce453a5a8b9acd0, in
addition to making a one-line fix for #1681, also deleted
misc/operations_helpers/provisioning/provisioning.py entirely. This
brings it back.
David-Sarah Hopwood [Sat, 23 Mar 2013 03:10:50 +0000 (03:10 +0000)]
Correct off-by-one in maximum-immutable-share-size for old servers. fixes #1781
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
David-Sarah Hopwood [Thu, 21 Mar 2013 00:25:49 +0000 (00:25 +0000)]
Censor the introducer and helper furls' swissnums from the web welcome page. refs #1802
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
Brian Warner [Wed, 20 Mar 2013 22:25:10 +0000 (15:25 -0700)]
client.py: throw error when reserved_space= is unparseable. Closes #1812.
This should now fail quickly (during "tahoe start"). Previously this
would silently treat an unparseable size as "0", and the only way to
discover that it had had a problem would be to look at the foolscap log,
or examine the storage-service web page for the unexpected "Reserved
Size" number.
Brian Warner [Wed, 20 Mar 2013 22:10:47 +0000 (15:10 -0700)]
Make introducer.furl unguessable. Closes #1802.
Previously, Introducers always used a swissnum of "introducer", so
anyone who could learn the (public) tubid of the introducer would be
able to connect to and use it. This changes new Introducers to use the
same randomly-generated swissnum as clients and storage servers do, so
that you absolutely must learn the introducer.furl from someone who
knows it already before you can connect.
This change also moves the location of the file that stores
introducer.furl from BASEDIR/introducer.furl to
BASEDIR/private/introducer.furl, since that's where we keep the private
things. The first time an introducer is started with the new code, it
will move any existing BASEDIR/introducer.furl into the new place.
Note that this will not change the FURL of existing introducers: it will
only affect newly created ones. When you change an introducer's FURL,
you must also update all of the nodes (clients and storage servers)
which connect to it, so upgrading it to an unguessable one isn't
something we should do automatically.
David-Sarah Hopwood [Wed, 20 Mar 2013 22:18:57 +0000 (22:18 +0000)]
NEWS.rst: precautions when upgrading. refs #1932
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
Brian Warner [Wed, 20 Mar 2013 19:27:38 +0000 (12:27 -0700)]
test_cli.py: fix mutable PUT stderr expectations
David-Sarah Hopwood [Wed, 20 Mar 2013 01:27:17 +0000 (01:27 +0000)]
Improve 'tahoe put --help' to clarify behaviour for mutable files, and
make sure the documented behaviour is tested. fixes #1372
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
David-Sarah Hopwood [Wed, 20 Mar 2013 00:57:50 +0000 (00:57 +0000)]
Avoid double-counting source files in 'tahoe cp --verbose'. fixes #1783
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
David-Sarah Hopwood [Wed, 20 Mar 2013 00:36:00 +0000 (00:36 +0000)]
Improvements to NEWS.rst for 1.10.
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
Brian Warner [Tue, 19 Mar 2013 23:23:34 +0000 (16:23 -0700)]
tweak NEWS a bit
David-Sarah Hopwood [Mon, 18 Mar 2013 19:20:27 +0000 (19:20 +0000)]
Add draft NEWS entry for 1.10.0c1.
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
Brian Warner [Tue, 19 Mar 2013 22:26:21 +0000 (15:26 -0700)]
Remove darcs from setup.py, remove darcsver egg. Closes #1908.
Also remove lingering traces of darcs from MANIFEST.in,
.darcs-boringfile, setup.cfg, and unit tests.
Brian Warner [Tue, 19 Mar 2013 19:18:27 +0000 (12:18 -0700)]
Makefile: re-enable tarball uploads for "master" branch
David-Sarah Hopwood [Tue, 19 Mar 2013 03:47:24 +0000 (03:47 +0000)]
New Welcome page: ensure 'not connected' status for Introducer and Helper is shown via text as well as bullet colour. refs #1713
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
David-Sarah Hopwood [Tue, 19 Mar 2013 05:37:02 +0000 (05:37 +0000)]
Improve SFTP error handling and remove use of IFinishableConsumer. fixes #1525
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
David-Sarah Hopwood [Sat, 5 Jan 2013 01:02:13 +0000 (01:02 +0000)]
sftpd.py: switch from using bare asserts to assertutil.
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
Brian Warner [Tue, 19 Mar 2013 00:40:56 +0000 (17:40 -0700)]
introducer.client: use integer seqnums, not time-based. Closes #1767.
This stores the sequence number in BASEDIR/announcement-seqnum, and
increments it each time any service is published (every service
announcement is regenerated with the new sequence number). As everyone
knows, time is an illusion, and occasionally goes backwards, so a
counter is generally safer (and reveals less information about the
node).
Later, we'll improve the introducer client to tolerate rollbacks (where,
perhaps due to a VM being restarted from an earlier checkpoint, the
stored sequence number reverts to an earlier version).
Brian Warner [Tue, 19 Mar 2013 00:30:57 +0000 (17:30 -0700)]
fileutil.write: accept mode=, and use it in Node.write_config
I want mode="w" (i.e. text, with newline conversion) for code that
writes newline-terminated strings (which should also be human readable)
to files. I like to use things like "cat .tahoe/permutation-seed"
without seeing the seed jammed together with the next command prompt.
David-Sarah Hopwood [Sun, 17 Mar 2013 18:27:58 +0000 (18:27 +0000)]
setup.py: add helpful comment on line that is a SyntaxError in Python < 2.6.
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
David-Sarah Hopwood [Sun, 17 Mar 2013 18:26:34 +0000 (18:26 +0000)]
test_web.py: relax tests for upload and mkdir forms to tolerate nondeterministic order of attributes.
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
David-Sarah Hopwood [Sun, 17 Mar 2013 16:43:46 +0000 (16:43 +0000)]
Move embedded setuptools egg to reflect new version (0.6c16dev4).
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
David-Sarah Hopwood [Sun, 17 Mar 2013 16:42:59 +0000 (16:42 +0000)]
Tolerate import errors when loading extra commands for "setup.py --help-commands"
and bump zetuptoolz version to 0.6c16dev4. fixes #1405
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
David-Sarah Hopwood [Fri, 15 Mar 2013 06:39:12 +0000 (06:39 +0000)]
Update helper.rst to explain new-style config. fixes #1915
Author: Zooko Wilcox-O'Hearn <zooko>
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
David-Sarah Hopwood [Fri, 15 Mar 2013 02:28:38 +0000 (02:28 +0000)]
Redesigned Welcome page using Twitter Bootstrap CSS.
Author: Tony Arcieri <tarcieri>
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
Brian Warner [Sat, 16 Mar 2013 04:46:32 +0000 (21:46 -0700)]
bump 'mock' dependency to >=0.8.0, to get the .call object
The 0.6.0 version that was previously allowed did not provide .call, so
test_cli.py failed during import.
David-Sarah Hopwood [Fri, 15 Mar 2013 05:13:30 +0000 (05:13 +0000)]
Require at least Python 2.6. fixes #1658
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
David-Sarah Hopwood [Fri, 15 Mar 2013 04:41:53 +0000 (04:41 +0000)]
Make doubly sure that we fail quickly on future Python 3.x versions. refs #1775
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
David-Sarah Hopwood [Fri, 15 Mar 2013 04:28:35 +0000 (04:28 +0000)]
Ensure that bin/tahoe and setup.py fail quickly on Python 3.3+. fixes #1775
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
David-Sarah Hopwood [Thu, 3 Jan 2013 03:19:52 +0000 (03:19 +0000)]
Add test for anti-Ubuntu-crash-reporter exception-catching code. fixes #1746
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
David-Sarah Hopwood [Fri, 4 Jan 2013 05:32:24 +0000 (05:32 +0000)]
tahoe_ls.py: JSON responses don't need quotemarks or quoted newlines.
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
David-Sarah Hopwood [Fri, 4 Jan 2013 05:31:07 +0000 (05:31 +0000)]
Only quote newline characters where necessary. fixes #1484
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
Mike Kazantsev [Wed, 27 Feb 2013 17:14:58 +0000 (23:14 +0600)]
test_web.py: fix test_GET_DIRECTORY_html_filenode_encoding for Twisted==12.3.0. fixes #1922
twisted.web.html.escape was used to produce html-encoded string (to then look
it up in "value" attribute), but behavior of that function has changed between
Twisted 12.2.0 (simple custom implementation) and 12.3.0 (imported from stdlib
cgi module).
David-Sarah Hopwood [Fri, 8 Feb 2013 19:27:57 +0000 (19:27 +0000)]
Add comment explaining fix to #1679. refs #1679
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
Zooko O'Whielacronx [Thu, 7 Feb 2013 16:35:43 +0000 (16:35 +0000)]
do not cache and re-use imm filenodes in nodemaker
fixes #1679
Zooko O'Whielacronx [Thu, 7 Feb 2013 16:35:23 +0000 (16:35 +0000)]
unit test for #1679
David-Sarah Hopwood [Thu, 3 Jan 2013 22:16:20 +0000 (22:16 +0000)]
tahoe_check.py: tolerate missing fields in check results for LIT files/dirs. fixes #1758
Also test this case and improve some existing tests of 'tahoe check'.
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
David-Sarah Hopwood [Sat, 29 Dec 2012 23:54:54 +0000 (23:54 +0000)]
Make WUI headings and titles more consistent and accurate:
'Recent and Active Operations' and 'Operational Statistics'. fixes #1457
Signed-off-by: David-Sarah Hopwood <davidsarah@jacaranda.org>
David-Sarah Hopwood [Sat, 29 Dec 2012 23:44:11 +0000 (23:44 +0000)]
test_web.py: minor cleanup to test_helper_status.
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
David-Sarah Hopwood [Sat, 29 Dec 2012 04:17:00 +0000 (04:17 +0000)]
If a helper is not configured, make the banner on the welcome page say that, and have a white background.
fixes #1735
Author: kick
Signed-off-by: David-Sarah Hopwood <davidsarah@jacaranda.org>
David-Sarah Hopwood [Thu, 27 Dec 2012 23:38:58 +0000 (23:38 +0000)]
docs/configuration.rst: clarification on scale suffixes for reserved_space.
refs #1812
Signed-off-by: David-Sarah Hopwood <davidsarah@mint>
David-Sarah Hopwood [Thu, 27 Dec 2012 20:08:27 +0000 (20:08 +0000)]
Make abbreviate_space able to output in exabytes. refs #1812
Signed-off-by: David-Sarah Hopwood <davidsarah@mint>
David-Sarah Hopwood [Thu, 27 Dec 2012 20:08:00 +0000 (20:08 +0000)]
Allow T (terabytes), P (petabytes), and E (exabytes), case-insensitive, in parse_abbreviated_size.
This also simplifies how case-insensitivity is handled, and fixes a corner case
where the wrong exception was raised when the size ends in "BB".
fixes #1812
Signed-off-by: David-Sarah Hopwood <davidsarah@mint>
David-Sarah Hopwood [Thu, 27 Dec 2012 19:00:22 +0000 (19:00 +0000)]
Make the system test nodes have non-ASCII nicknames.
This ensures that non-ASCII nicknames are exercised with the real server code.
refs #1298
Signed-off-by: David-Sarah Hopwood <davidsarah@mint>
David-Sarah Hopwood [Thu, 27 Dec 2012 05:08:53 +0000 (05:08 +0000)]
Allow welcome and storage status pages to display a non-ASCII node nickname. fixes #1298
Signed-off-by: David-Sarah Hopwood <davidsarah@jacaranda.org>
David-Sarah Hopwood [Thu, 27 Dec 2012 00:00:17 +0000 (00:00 +0000)]
Remove ResponseCache in favor of MDMFSlotReadProxy's cache. closes #1240.
This contains several merged patches. Individual messages follow, latest first:
* Fix a warning from check-miscaptures.
* In retrieve.py, explicitly test whether a key is in self.servermap.proxies
rather than catching KeyError.
* Added a new comment to the MDMF version of the test I removed, explaining
the removal of the SDMF version.
* Removed test_corrupt_all_block_hash_tree_late, since the entire block_hash_tree
is cached in the servermap for an SDMF file.
* Fixed several tests that require files larger than the servermap cache.
* Remove unused test_response_cache_memory_leak().
* Exercise the cache.
* Test infrastructure for counting cache misses on MDMF files.
* Removed the ResponseCache. Instead, the MDMFSlotReadProxy initialized
by ServerMap is kept around so Retrieve can access it. The ReadProxy
has a cache of the first 1000 bytes initially read from each share by
the ServerMap. We're able to satisfy a number of requests out of this
cache, so roundtrips are reduced from 84 to 60 in test_deepcheck_mdmf.
There is still some mystery about under what conditions the cache has
fewer than 1000 bytes. Also this breaks some existing unit tests that
depend on the inner behavior of ResponseCache.
* The servermap.proxies (a cache of SlotReadProxies) is now keyed
by (verinfo,serverid,shnum) rather than just (serverid,shnum)
* Minor cosmetic changes
* Added a test failure if the number of cache misses is too high.
Author: Andrew Miller <amiller@dappervision.com>
Signed-off-by: David-Sarah Hopwood <davidsarah@jacaranda.org>
David-Sarah Hopwood [Sat, 22 Dec 2012 23:47:47 +0000 (23:47 +0000)]
docs/logging.rst: fix rst2html warnings.
Signed-off-by: David-Sarah Hopwood <davidsarah@mint>
David-Sarah Hopwood [Sat, 22 Dec 2012 23:39:11 +0000 (23:39 +0000)]
docs/logging.rst: remove note about a bug that was fixed in foolscap 0.6.0.
Signed-off-by: David-Sarah Hopwood <davidsarah@mint>
David-Sarah Hopwood [Sun, 2 Dec 2012 01:54:47 +0000 (01:54 +0000)]
test/common_util.py: fix a bug in NonASCIIPathMixin that would cause spurious log entries on Windows.
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
Zooko O'Whielacronx [Thu, 29 Nov 2012 21:11:47 +0000 (14:11 -0700)]
tests: add more diagnostics when code-under-test fails
This prints out which things are different when two sets are expected to be the
same. This was useful to me when debugging the code under test. Hm, this
pattern might be more generally useful...
Zooko O'Whielacronx [Thu, 29 Nov 2012 20:44:32 +0000 (13:44 -0700)]
remove unnecessary request from upload-helper
The unnecessary request was from the upload helper to the sender, and it was
there in order to trigger the sender to deliver cleartext hashes. But we've
long since removed cleartext hashes.
Unit tests pass both before and after this change, and code-coverage shows that
the block I changed is exercised in unit tests.