From: Brian Warner Date: Thu, 8 Mar 2007 22:09:29 +0000 (-0700) Subject: test_observer.py: remove the code that allows observers to run out-of-order, our... X-Git-Url: https://git.rkrishnan.org/%5B/frontends/flags/install.html?a=commitdiff_plain;h=2f02659b5a52901c1216df549f2df65b3c01ef03;p=tahoe-lafs%2Ftahoe-lafs.git test_observer.py: remove the code that allows observers to run out-of-order, our use of foolscap.eventual removes this error case --- diff --git a/src/allmydata/test/test_observer.py b/src/allmydata/test/test_observer.py index c35306f7..4b12d041 100644 --- a/src/allmydata/test/test_observer.py +++ b/src/allmydata/test/test_observer.py @@ -51,17 +51,6 @@ class Observer(unittest.TestCase): ol.notify(3) def _check(res): self.failUnlessEqual(l1, [1,2]) - if l2 == [3,2]: - msg = ("ObserverList does not yet guarantee ordering of " - "its calls, although it should. This only actually " - "ever fails under windows because time.time() has " - "low resolution and because Twisted does not " - "guarantee ordering of consecutive " - "reactor.callLater(0) calls, although it should. " - "This will be fixed by adding a dependency upon " - "Foolscap and using foolscap.eventual.eventually() " - "instead of callLater(0)") - self.todo = msg self.failUnlessEqual(l2, [2,3]) d = nextTurn() d.addCallback(_check)