Daira Hopwood [Mon, 27 Apr 2015 22:20:22 +0000 (23:20 +0100)]
Move initialization to setUp().
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 27 Apr 2015 22:08:58 +0000 (23:08 +0100)]
Unfix tests :-p
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 28 Apr 2015 18:48:49 +0000 (19:48 +0100)]
Fix tests :-D
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 27 Apr 2015 20:32:31 +0000 (21:32 +0100)]
Cosmetics (ordering of checks).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 27 Apr 2015 20:31:58 +0000 (21:31 +0100)]
drop-upload: make paths consistently Unicode. Also fix import warnings.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 27 Apr 2015 16:19:21 +0000 (17:19 +0100)]
test_drop_upload.py: factor out duplicated setting of self.inotify.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
David Stainton [Fri, 24 Apr 2015 06:47:22 +0000 (07:47 +0100)]
fix dir tree unit test
David Stainton [Thu, 23 Apr 2015 00:25:03 +0000 (01:25 +0100)]
Fix _test_persistence AND remove superfluous print statements
David Stainton [Thu, 23 Apr 2015 00:09:41 +0000 (01:09 +0100)]
Fix problems with _test_db_persistence unit test code
David Stainton [Wed, 22 Apr 2015 07:38:24 +0000 (08:38 +0100)]
Create another uploader db test
David Stainton [Wed, 22 Apr 2015 02:16:52 +0000 (03:16 +0100)]
Remove unneeded lines the crept in from previous WIP commits
Daira Hopwood [Tue, 21 Apr 2015 22:54:51 +0000 (23:54 +0100)]
Cosmetics.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 21 Apr 2015 22:54:25 +0000 (23:54 +0100)]
Avoid shadowing a method name.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 21 Apr 2015 22:54:01 +0000 (23:54 +0100)]
Better variable name.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 21 Apr 2015 22:53:39 +0000 (23:53 +0100)]
Change when _scan is called.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 21 Apr 2015 22:52:26 +0000 (23:52 +0100)]
For persistence test, use a new client (with the same backupdb).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 21 Apr 2015 22:10:35 +0000 (23:10 +0100)]
Simplification of _upload_lazy_tail.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
David Stainton [Tue, 21 Apr 2015 21:51:51 +0000 (22:51 +0100)]
WIP
David Stainton [Tue, 21 Apr 2015 17:48:14 +0000 (18:48 +0100)]
wip - confirming that the db persistence doesn't work
David Stainton [Tue, 21 Apr 2015 07:17:24 +0000 (08:17 +0100)]
Fix db persistence unit test for uploader
David Stainton [Tue, 21 Apr 2015 04:48:16 +0000 (05:48 +0100)]
Fix race condition in upload deque
Daira Hopwood [Mon, 20 Apr 2015 23:02:33 +0000 (00:02 +0100)]
Remove redundant calls to _scan and startService.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
David Stainton [Mon, 20 Apr 2015 22:34:33 +0000 (23:34 +0100)]
WIP
Daira Hopwood [Tue, 28 Apr 2015 18:46:43 +0000 (19:46 +0100)]
Fixed move tree test and cleaned up persistence test
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 20 Apr 2015 16:57:37 +0000 (17:57 +0100)]
Use Unicode directory name.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 20 Apr 2015 16:57:26 +0000 (17:57 +0100)]
Add temporary debug prints.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 20 Apr 2015 16:56:34 +0000 (17:56 +0100)]
Try to fix potential race conditions in testMoveEmptyTree.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 20 Apr 2015 16:54:17 +0000 (17:54 +0100)]
Add ignore mechanism to upload callback.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 20 Apr 2015 16:52:48 +0000 (17:52 +0100)]
Clarify dir/file/link logic.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 20 Apr 2015 16:17:52 +0000 (17:17 +0100)]
Add recursive=True to drop_upload watch.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 28 Apr 2015 18:45:12 +0000 (19:45 +0100)]
WIP
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 28 Apr 2015 18:43:29 +0000 (19:43 +0100)]
fix unit tests WIP
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
David Stainton [Sat, 18 Apr 2015 03:50:54 +0000 (04:50 +0100)]
Add stats counter checking to uploader service start test
David Stainton [Sat, 18 Apr 2015 03:25:49 +0000 (04:25 +0100)]
Add further refinements to move tree uploader test
- test empty tree and small tree test cases using various stats counters
David Stainton [Sat, 18 Apr 2015 03:06:33 +0000 (04:06 +0100)]
Uncomment mkdir in uploader unit test
David Stainton [Sat, 18 Apr 2015 03:04:09 +0000 (04:04 +0100)]
Add move empty dir tree test and minor test cleanup
David Stainton [Sat, 18 Apr 2015 02:20:03 +0000 (03:20 +0100)]
Remove code duplication from uploader unit tests
David Stainton [Sat, 18 Apr 2015 01:43:22 +0000 (02:43 +0100)]
Don't increment disappeared stats twice
David Stainton [Sat, 18 Apr 2015 00:47:09 +0000 (01:47 +0100)]
Teach uploader to monitor subdirectories
David Stainton [Fri, 17 Apr 2015 22:30:27 +0000 (23:30 +0100)]
Teach uploader to keep object stats not file stats
- we keep track of objects instead of files so that we are not
forced to determine the object type (file, directory, symlink, special file etc.)
David Stainton [Fri, 17 Apr 2015 21:25:30 +0000 (22:25 +0100)]
Remove filepath from pending set earlier
David Stainton [Fri, 17 Apr 2015 20:47:13 +0000 (21:47 +0100)]
Fix test_create_drop_uploader
This test must use the correct function signature for it's mock function...
obviously. =-p
David Stainton [Fri, 17 Apr 2015 19:59:37 +0000 (20:59 +0100)]
Teach upload deque to be sequential and asynchronous
David Stainton [Fri, 17 Apr 2015 18:58:08 +0000 (19:58 +0100)]
Teach uploade deque append to not block (potentially?)
Daira Hopwood [Tue, 28 Apr 2015 18:39:35 +0000 (19:39 +0100)]
Simplify upload queue API
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 28 Apr 2015 18:38:32 +0000 (19:38 +0100)]
Make the unit tests work for Mock and Real
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 28 Apr 2015 18:37:08 +0000 (19:37 +0100)]
Add very basic unit tests for dir scan and db
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 28 Apr 2015 18:34:39 +0000 (19:34 +0100)]
Scan dir when service starts
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
David Stainton [Wed, 15 Apr 2015 18:19:56 +0000 (18:19 +0000)]
Bug fix: don't append filepath to upload deque twice
Daira Hopwood [Tue, 28 Apr 2015 18:28:29 +0000 (19:28 +0100)]
Bug fix: deque must be unbounded
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
David Stainton [Wed, 15 Apr 2015 18:10:01 +0000 (18:10 +0000)]
Fix pending upload bug
- remove filepath from pending upload set BEFORE performing upload
This bug was introduced at commit
87657eb382da05039cce99862691efcc27243193
Daira Hopwood [Wed, 15 Apr 2015 12:33:58 +0000 (13:33 +0100)]
Disable a test that breaks on Windows.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Wed, 18 Mar 2015 00:47:40 +0000 (00:47 +0000)]
WIP: workaround for duplicate events on Windows. refs #2220
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 28 Apr 2015 18:26:53 +0000 (19:26 +0100)]
Windows support for drop-upload. fixes #1431
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Sat, 12 Apr 2014 18:47:57 +0000 (19:47 +0100)]
Docs for drop-upload on Windows.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Wed, 15 Apr 2015 13:03:03 +0000 (14:03 +0100)]
DropUploader.startService returns a deferred; don't drop it.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 28 Apr 2015 18:22:26 +0000 (19:22 +0100)]
Use explicit deque to create expected upload "queue" functionality.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 28 Apr 2015 18:18:30 +0000 (19:18 +0100)]
Teach StorageFarmBroker to fire a deferred when a connection threshold is reached. refs #1449
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
David Stainton [Fri, 17 Apr 2015 00:52:48 +0000 (01:52 +0100)]
Make the unit tests work for Mock and Real
David Stainton [Tue, 14 Apr 2015 04:33:26 +0000 (04:33 +0000)]
Add very basic unit tests for dir scan and db
David Stainton [Tue, 14 Apr 2015 02:18:59 +0000 (02:18 +0000)]
Scan dir when service starts
the add file to queue function currently does nothing...
David Stainton [Sat, 11 Apr 2015 03:19:47 +0000 (03:19 +0000)]
WIP - add some backup db code fragments
Daira Hopwood [Tue, 28 Apr 2015 17:53:44 +0000 (18:53 +0100)]
Bump zetuptoolz version (move directory).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 28 Apr 2015 17:52:59 +0000 (18:52 +0100)]
Bump zetuptoolz version (file changes).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 28 Apr 2015 17:42:57 +0000 (18:42 +0100)]
zetuptoolz: tolerate a single string for __requires__, and improve error reporting. fixes ticket:2242
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 28 Apr 2015 16:21:31 +0000 (17:21 +0100)]
Change foolscap dependency to >= 0.8.0. refs #2400
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Brian Warner [Sun, 26 Apr 2015 22:07:55 +0000 (15:07 -0700)]
CREDITS: add my GPG key
Daira Hopwood [Tue, 21 Apr 2015 20:28:21 +0000 (21:28 +0100)]
Fix a test that was dependent on Windows path separators.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 21 Apr 2015 20:15:54 +0000 (21:15 +0100)]
Reduce differences between Windows and non-Windows dependencies.
This also fixes some warnings on Windows when using Twisted 12.1.0.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Brian Warner [Tue, 21 Apr 2015 20:04:47 +0000 (13:04 -0700)]
fix check-memory test, with new new (safe) control-port methods
Daira Hopwood [Tue, 21 Apr 2015 20:03:45 +0000 (21:03 +0100)]
Ensure the 'base' argument to abspath_expanduser_unicode takes effect on Windows. fixes #2398
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Brian Warner [Tue, 21 Apr 2015 18:26:16 +0000 (11:26 -0700)]
finish removing control-port upload/download functions
Brian Warner [Tue, 21 Apr 2015 17:48:06 +0000 (10:48 -0700)]
remove control-port upload/download file interfaces
FURLs are unguessable, but an attacker who somehow learned this FURL
could overwrite files and read sensitive data.
This will break the memory tests. I will add a new interface to support
the memory tests soon.
refs ticket:1737
Daira Hopwood [Fri, 17 Apr 2015 16:59:58 +0000 (17:59 +0100)]
backupdb.py: cosmetics
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Fri, 17 Apr 2015 16:59:34 +0000 (17:59 +0100)]
Make backupdb use dbutil.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Fri, 17 Apr 2015 16:57:49 +0000 (17:57 +0100)]
Add util/dbutil.py: open/create/update sqlite databases given some schema.
Author: Brian Warner <warner@lothar.com>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Fri, 23 Nov 2012 00:23:54 +0000 (00:23 +0000)]
Some useful Deferred utilities, originally from the cloud backend branch.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 13 Apr 2015 23:08:47 +0000 (00:08 +0100)]
Merge pull request #152 from vu3rdd/182-osx-packaging-7
strip the single quotes around $VERSION
Ramakrishnan Muthukrishnan [Sat, 11 Apr 2015 09:05:18 +0000 (14:35 +0530)]
strip the single quotes around $VERSION
Without stripping the single quotes, the generated pagkage filename
also has the undesired single quotes around the version string.
(eg: tahoe-lafs-'1.10.0.post309'-osx.pkg).
Daira Hopwood [Fri, 10 Apr 2015 22:42:57 +0000 (23:42 +0100)]
README.rst: change description to the new wording on tahoe-lafs.org (with "file store" instead of "filesystem").
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Thu, 2 Apr 2015 15:16:46 +0000 (16:16 +0100)]
Add discussion and rejection of Change Journals.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Thu, 2 Apr 2015 15:16:17 +0000 (16:16 +0100)]
Add link to otf-magic-folder-objective ticket query.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Thu, 2 Apr 2015 15:15:39 +0000 (16:15 +0100)]
Copyediting.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Thu, 2 Apr 2015 14:26:25 +0000 (15:26 +0100)]
Collaborative design from Daira and David.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Brian Warner [Tue, 31 Mar 2015 18:07:48 +0000 (11:07 -0700)]
Merge branch 'ftp-2394'
closes ticket:2394
Brian Warner [Tue, 31 Mar 2015 18:07:21 +0000 (11:07 -0700)]
typo
Brian Warner [Tue, 31 Mar 2015 16:41:55 +0000 (09:41 -0700)]
bump Twisted dep to 11.1.0, thus simplify IntishPermissions
Brian Warner [Tue, 31 Mar 2015 16:30:17 +0000 (09:30 -0700)]
test_ftp: fix comparison against integer
Brian Warner [Thu, 26 Mar 2015 01:23:33 +0000 (18:23 -0700)]
Fix ftp 'ls' to work with current Twisted-15.0.0
refs ticket:2394
It's kind of a hack, but Twisted changed the API and I couldn't find a
cleaner way to detect which form of "permissions" value the Twisted FTP
server wants.
I've manually tested it against 14.0.2 and 15.0.0.
Daira Hopwood [Tue, 31 Mar 2015 16:47:06 +0000 (17:47 +0100)]
Merge pull request #149 from warner/mutable-2034
use more servers for test_mutable.Update, to test #2034 properly
Brian Warner [Thu, 26 Mar 2015 01:49:37 +0000 (18:49 -0700)]
use more servers for test_mutable.Update, to test #2034 properly
Daira Hopwood [Tue, 24 Mar 2015 17:10:00 +0000 (17:10 +0000)]
Add a test, add missing imports. refs #2388
This tests ftpd, but not sftpd. Doing this sort of test on sftpd
requires the creation of a valid pubkey/privkey file pair, which is more
work than I want to do right now.
init_ftp/init_sftp were changed to interpret the configured
accounts.file as relative to the node's basedir, with
abspath_expanduser_unicode(accountfile, base=self.basedir).
This would happen naturally in a real node, since it os.chdir()s
to the basedir before doing anything. But tests don't do that.
Author: Brian Warner <warner@lothar.com>
Author: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 3 Mar 2015 20:06:35 +0000 (20:06 +0000)]
Ensure that path parameters to SFTPServer and FTPServer constructors are unicode. refs #2388
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 3 Mar 2015 20:04:57 +0000 (20:04 +0000)]
Add from_utf8_or_none and tests.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 24 Mar 2015 16:44:54 +0000 (16:44 +0000)]
Fix a missing import in test-osx-pkg.py. refs #2393
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 24 Mar 2015 16:42:27 +0000 (16:42 +0000)]
More careful quoting in build-osx-pkg.sh. refs #2393
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 24 Mar 2015 16:41:43 +0000 (16:41 +0000)]
Move computation of Tahoe version from Makefile to build-osx-pkg.sh. refs #2393
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 24 Mar 2015 16:11:30 +0000 (16:11 +0000)]
Merge pull request #146 from warner/versioned-osx-pkg
put a version string in the name of the OS-X .pkg file
Brian Warner [Sat, 21 Mar 2015 21:20:00 +0000 (14:20 -0700)]
create/test/upload tahoe-lafs-VERSION-osx.pkg, not tahoe-lafs-osx.pkg
Closes ticket:2393
Brian Warner [Sat, 21 Mar 2015 21:09:33 +0000 (14:09 -0700)]
move build-osx-pkg out to a separate shell script
Also remove the duplicate test-osx-pkg (i.e. don't run the test as part
of the build, and have the caller do it themselves later).