From a9a3b509df791a82ca7a58ad315f342db3686c84 Mon Sep 17 00:00:00 2001 From: Brian Warner Date: Mon, 9 Feb 2009 14:50:04 -0700 Subject: [PATCH] upload: add a think-of-the-compatibility note to UploadResults --- src/allmydata/immutable/upload.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/allmydata/immutable/upload.py b/src/allmydata/immutable/upload.py index 28edda49..ed377daf 100644 --- a/src/allmydata/immutable/upload.py +++ b/src/allmydata/immutable/upload.py @@ -46,6 +46,11 @@ class UploadResults(Copyable, RemoteCopy): typeToCopy = "allmydata.upload.UploadResults.tahoe.allmydata.com" copytype = typeToCopy + # also, think twice about changing the shape of any existing attribute, + # because instances of this class are sent from the helper to its client, + # so changing this may break compatibility. Consider adding new fields + # instead of modifying existing ones. + def __init__(self): self.timings = {} # dict of name to number of seconds self.sharemap = dictutil.DictOfSets() # {shnum: set(serverid)} -- 2.45.2