+# -*- coding: utf-8 -*-
+
import os, shutil
from cStringIO import StringIO
from twisted.trial import unittest
from twisted.python.failure import Failure
-from twisted.python import log
from twisted.internet import defer
from foolscap.api import fireEventually
from allmydata import uri, monitor, client
from allmydata.immutable import upload, encode
from allmydata.interfaces import FileTooLargeError, UploadUnhappinessError
+from allmydata.util import log, base32
from allmydata.util.assertutil import precondition
from allmydata.util.deferredutil import DeferredListShouldSucceed
from allmydata.test.no_network import GridTestMixin
from allmydata.test.common_util import ShouldFailMixin
from allmydata.util.happinessutil import servers_of_happiness, \
- shares_by_server, merge_peers
+ shares_by_server, merge_servers
from allmydata.storage_client import StorageFarmBroker
from allmydata.storage.server import storage_index_to_dir
self.num_servers = num_servers
if type(mode) is str:
mode = dict([i,mode] for i in range(num_servers))
- peers = [ ("%20d"%fakeid, FakeStorageServer(mode[fakeid]))
- for fakeid in range(self.num_servers) ]
+ servers = [ ("%20d"%fakeid, FakeStorageServer(mode[fakeid]))
+ for fakeid in range(self.num_servers) ]
self.storage_broker = StorageFarmBroker(None, permute_peers=True)
- for (serverid, server) in peers:
- self.storage_broker.test_add_server(serverid, server)
- self.last_peers = [p[1] for p in peers]
+ for (serverid, rref) in servers:
+ ann = {"anonymous-storage-FURL": "pb://%s@nowhere/fake" % base32.b2a(serverid),
+ "permutation-seed-base32": base32.b2a(serverid) }
+ self.storage_broker.test_add_rref(serverid, rref, ann)
+ self.last_servers = [s[1] for s in servers]
def log(self, *args, **kwargs):
pass
def test_first_error_all(self):
self.make_node("first-fail")
d = self.shouldFail(UploadUnhappinessError, "first_error_all",
- "peer selection failed",
+ "server selection failed",
upload_data, self.u, DATA)
def _check((f,)):
self.failUnlessIn("placed 0 shares out of 100 total", str(f.value))
def test_second_error_all(self):
self.make_node("second-fail")
d = self.shouldFail(UploadUnhappinessError, "second_error_all",
- "peer selection failed",
+ "server selection failed",
upload_data, self.u, DATA)
def _check((f,)):
self.failUnlessIn("placed 10 shares out of 100 total", str(f.value))
d.addBoth(self._should_fail)
return d
-class PeerSelection(unittest.TestCase):
+class ServerSelection(unittest.TestCase):
def make_client(self, num_servers=50):
self.node = FakeClient(mode="good", num_servers=num_servers)
self.node.DEFAULT_ENCODING_PARAMETERS = p
def test_one_each(self):
- # if we have 50 shares, and there are 50 peers, and they all accept a
- # share, we should get exactly one share per peer
+ # if we have 50 shares, and there are 50 servers, and they all accept
+ # a share, we should get exactly one share per server
self.make_client()
data = self.get_data(SIZE_LARGE)
d.addCallback(extract_uri)
d.addCallback(self._check_large, SIZE_LARGE)
def _check(res):
- for p in self.node.last_peers:
- allocated = p.allocated
+ for s in self.node.last_servers:
+ allocated = s.allocated
self.failUnlessEqual(len(allocated), 1)
- self.failUnlessEqual(p.queries, 1)
+ self.failUnlessEqual(s.queries, 1)
d.addCallback(_check)
return d
def test_two_each(self):
- # if we have 100 shares, and there are 50 peers, and they all accept
- # all shares, we should get exactly two shares per peer
+ # if we have 100 shares, and there are 50 servers, and they all
+ # accept all shares, we should get exactly two shares per server
self.make_client()
data = self.get_data(SIZE_LARGE)
- # if there are 50 peers, then happy needs to be <= 50
+ # if there are 50 servers, then happy needs to be <= 50
self.set_encoding_parameters(50, 50, 100)
d = upload_data(self.u, data)
d.addCallback(extract_uri)
d.addCallback(self._check_large, SIZE_LARGE)
def _check(res):
- for p in self.node.last_peers:
- allocated = p.allocated
+ for s in self.node.last_servers:
+ allocated = s.allocated
self.failUnlessEqual(len(allocated), 2)
- self.failUnlessEqual(p.queries, 2)
+ self.failUnlessEqual(s.queries, 2)
d.addCallback(_check)
return d
def test_one_each_plus_one_extra(self):
- # if we have 51 shares, and there are 50 peers, then one peer gets
- # two shares and the rest get just one
+ # if we have 51 shares, and there are 50 servers, then one server
+ # gets two shares and the rest get just one
self.make_client()
data = self.get_data(SIZE_LARGE)
def _check(res):
got_one = []
got_two = []
- for p in self.node.last_peers:
- allocated = p.allocated
+ for s in self.node.last_servers:
+ allocated = s.allocated
self.failUnless(len(allocated) in (1,2), len(allocated))
if len(allocated) == 1:
- self.failUnlessEqual(p.queries, 1)
- got_one.append(p)
+ self.failUnlessEqual(s.queries, 1)
+ got_one.append(s)
else:
- self.failUnlessEqual(p.queries, 2)
- got_two.append(p)
+ self.failUnlessEqual(s.queries, 2)
+ got_two.append(s)
self.failUnlessEqual(len(got_one), 49)
self.failUnlessEqual(len(got_two), 1)
d.addCallback(_check)
return d
def test_four_each(self):
- # if we have 200 shares, and there are 50 peers, then each peer gets
- # 4 shares. The design goal is to accomplish this with only two
- # queries per peer.
+ # if we have 200 shares, and there are 50 servers, then each server
+ # gets 4 shares. The design goal is to accomplish this with only two
+ # queries per server.
self.make_client()
data = self.get_data(SIZE_LARGE)
- # if there are 50 peers, then happy should be no more than 50 if
- # we want this to work.
+ # if there are 50 servers, then happy should be no more than 50 if we
+ # want this to work.
self.set_encoding_parameters(100, 50, 200)
d = upload_data(self.u, data)
d.addCallback(extract_uri)
d.addCallback(self._check_large, SIZE_LARGE)
def _check(res):
- for p in self.node.last_peers:
- allocated = p.allocated
+ for s in self.node.last_servers:
+ allocated = s.allocated
self.failUnlessEqual(len(allocated), 4)
- self.failUnlessEqual(p.queries, 2)
+ self.failUnlessEqual(s.queries, 2)
d.addCallback(_check)
return d
d.addCallback(self._check_large, SIZE_LARGE)
def _check(res):
counts = {}
- for p in self.node.last_peers:
- allocated = p.allocated
+ for s in self.node.last_servers:
+ allocated = s.allocated
counts[len(allocated)] = counts.get(len(allocated), 0) + 1
histogram = [counts.get(i, 0) for i in range(5)]
self.failUnlessEqual(histogram, [0,0,0,2,1])
d.addCallback(extract_uri)
d.addCallback(self._check_large, SIZE_LARGE)
def _check(res):
- # we should have put one share each on the big peers, and zero
- # shares on the small peers
+ # we should have put one share each on the big servers, and zero
+ # shares on the small servers
total_allocated = 0
- for p in self.node.last_peers:
+ for p in self.node.last_servers:
if p.mode == "good":
self.failUnlessEqual(len(p.allocated), 1)
elif p.mode == "small":
d.addCallback(_done)
return d
+# copied from python docs because itertools.combinations was added in
+# python 2.6 and we support >= 2.4.
+def combinations(iterable, r):
+ # combinations('ABCD', 2) --> AB AC AD BC BD CD
+ # combinations(range(4), 3) --> 012 013 023 123
+ pool = tuple(iterable)
+ n = len(pool)
+ if r > n:
+ return
+ indices = range(r)
+ yield tuple(pool[i] for i in indices)
+ while True:
+ for i in reversed(range(r)):
+ if indices[i] != i + n - r:
+ break
+ else:
+ return
+ indices[i] += 1
+ for j in range(i+1, r):
+ indices[j] = indices[j-1] + 1
+ yield tuple(pool[i] for i in indices)
+
+def is_happy_enough(servertoshnums, h, k):
+ """ I calculate whether servertoshnums achieves happiness level h. I do this with a naïve "brute force search" approach. (See src/allmydata/util/happinessutil.py for a better algorithm.) """
+ if len(servertoshnums) < h:
+ return False
+ # print "servertoshnums: ", servertoshnums, h, k
+ for happysetcombo in combinations(servertoshnums.iterkeys(), h):
+ # print "happysetcombo: ", happysetcombo
+ for subsetcombo in combinations(happysetcombo, k):
+ shnums = reduce(set.union, [ servertoshnums[s] for s in subsetcombo ])
+ # print "subsetcombo: ", subsetcombo, ", shnums: ", shnums
+ if len(shnums) < k:
+ # print "NOT HAAPP{Y", shnums, k
+ return False
+ # print "HAAPP{Y"
+ return True
+
+class FakeServerTracker:
+ def __init__(self, serverid, buckets):
+ self._serverid = serverid
+ self.buckets = buckets
+ def get_serverid(self):
+ return self._serverid
+
class EncodingParameters(GridTestMixin, unittest.TestCase, SetDEPMixin,
ShouldFailMixin):
+ def find_all_shares(self, unused=None):
+ """Locate shares on disk. Returns a dict that maps
+ server to set of sharenums.
+ """
+ assert self.g, "I tried to find a grid at self.g, but failed"
+ servertoshnums = {} # k: server, v: set(shnum)
+
+ for i, c in self.g.servers_by_number.iteritems():
+ for (dirp, dirns, fns) in os.walk(c.sharedir):
+ for fn in fns:
+ try:
+ sharenum = int(fn)
+ except TypeError:
+ # Whoops, I guess that's not a share file then.
+ pass
+ else:
+ servertoshnums.setdefault(i, set()).add(sharenum)
+
+ return servertoshnums
+
def _do_upload_with_broken_servers(self, servers_to_break):
"""
I act like a normal upload, but before I send the results of
- Tahoe2PeerSelector to the Encoder, I break the first servers_to_break
- PeerTrackers in the used_peers part of the return result.
+ Tahoe2ServerSelector to the Encoder, I break the first
+ servers_to_break ServerTrackers in the upload_servers part of the
+ return result.
"""
assert self.g, "I tried to find a grid at self.g, but failed"
broker = self.g.clients[0].storage_broker
encoder = encode.Encoder()
encoder.set_encrypted_uploadable(uploadable)
status = upload.UploadStatus()
- selector = upload.Tahoe2PeerSelector("dglev", "test", status)
+ selector = upload.Tahoe2ServerSelector("dglev", "test", status)
storage_index = encoder.get_param("storage_index")
share_size = encoder.get_param("share_size")
block_size = encoder.get_param("block_size")
d = selector.get_shareholders(broker, sh, storage_index,
share_size, block_size, num_segments,
10, 3, 4)
- def _have_shareholders((used_peers, already_peers)):
- assert servers_to_break <= len(used_peers)
+ def _have_shareholders((upload_trackers, already_servers)):
+ assert servers_to_break <= len(upload_trackers)
for index in xrange(servers_to_break):
- server = list(used_peers)[index]
- for share in server.buckets.keys():
- server.buckets[share].abort()
+ tracker = list(upload_trackers)[index]
+ for share in tracker.buckets.keys():
+ tracker.buckets[share].abort()
buckets = {}
- servermap = already_peers.copy()
- for peer in used_peers:
- buckets.update(peer.buckets)
- for bucket in peer.buckets:
- servermap.setdefault(bucket, set()).add(peer.peerid)
+ servermap = already_servers.copy()
+ for tracker in upload_trackers:
+ buckets.update(tracker.buckets)
+ for bucket in tracker.buckets:
+ servermap.setdefault(bucket, set()).add(tracker.get_serverid())
encoder.set_shareholders(buckets, servermap)
d = encoder.start()
return d
d.addCallback(_have_shareholders)
return d
+ def _has_happy_share_distribution(self):
+ servertoshnums = self.find_all_shares()
+ k = self.g.clients[0].DEFAULT_ENCODING_PARAMETERS['k']
+ h = self.g.clients[0].DEFAULT_ENCODING_PARAMETERS['happy']
+ return is_happy_enough(servertoshnums, h, k)
def _add_server(self, server_number, readonly=False):
assert self.g, "I tried to find a grid at self.g, but failed"
ss = self.g.make_server(server_number, readonly)
+ log.msg("just created a server, number: %s => %s" % (server_number, ss,))
self.g.add_server(server_number, ss)
-
def _add_server_with_share(self, server_number, share_number=None,
readonly=False):
self._add_server(server_number, readonly)
str(share_number))
if old_share_location != new_share_location:
shutil.copy(old_share_location, new_share_location)
- shares = self.find_shares(self.uri)
+ shares = self.find_uri_shares(self.uri)
# Make sure that the storage server has the share.
self.failUnless((share_number, ss.my_nodeid, new_share_location)
in shares)
self.uri = ur.uri
d.addCallback(_store_uri)
d.addCallback(lambda ign:
- self.find_shares(self.uri))
+ self.find_uri_shares(self.uri))
def _store_shares(shares):
self.shares = shares
d.addCallback(_store_shares)
return d
-
def test_configure_parameters(self):
self.basedir = self.mktemp()
hooks = {0: self._set_up_nodes_extra_config}
self.u.upload(DATA))
return d
+ def test_aborted_shares(self):
+ self.basedir = "upload/EncodingParameters/aborted_shares"
+ self.set_up_grid(num_servers=4)
+ c = self.g.clients[0]
+ DATA = upload.Data(100* "kittens", convergence="")
+ # These parameters are unsatisfiable with only 4 servers, but should
+ # work with 5, as long as the original 4 are not stuck in the open
+ # BucketWriter state (open() but not
+ parms = {"k":2, "happy":5, "n":5, "max_segment_size": 1*MiB}
+ c.DEFAULT_ENCODING_PARAMETERS = parms
+ d = self.shouldFail(UploadUnhappinessError, "test_aborted_shares",
+ "shares could be placed on only 4 "
+ "server(s) such that any 2 of them have enough "
+ "shares to recover the file, but we were asked "
+ "to place shares on at least 5 such servers",
+ c.upload, DATA)
+ # now add the 5th server
+ d.addCallback(lambda ign: self._add_server(4, False))
+ # and this time the upload ought to succeed
+ d.addCallback(lambda ign: c.upload(DATA))
+ d.addCallback(lambda ign:
+ self.failUnless(self._has_happy_share_distribution()))
+ return d
+
def test_problem_layout_comment_52(self):
def _basedir():
self.basedir = self.mktemp()
_basedir()
# This scenario is at
- # http://allmydata.org/trac/tahoe/ticket/778#comment:52
+ # http://allmydata.org/trac/tahoe-lafs/ticket/778#comment:52
#
# The scenario in comment:52 proposes that we have a layout
# like:
def test_problem_layout_comment_53(self):
# This scenario is at
- # http://allmydata.org/trac/tahoe/ticket/778#comment:53
+ # http://allmydata.org/trac/tahoe-lafs/ticket/778#comment:53
#
# Set up the grid to have one server
def _change_basedir(ign):
# one share from our initial upload to each of these.
# The counterintuitive ordering of the share numbers is to deal with
# the permuting of these servers -- distributing the shares this
- # way ensures that the Tahoe2PeerSelector sees them in the order
+ # way ensures that the Tahoe2ServerSelector sees them in the order
# described below.
d = self._setup_and_upload()
d.addCallback(lambda ign:
# server 2: share 0
# server 3: share 1
# We change the 'happy' parameter in the client to 4.
- # The Tahoe2PeerSelector will see the peers permuted as:
+ # The Tahoe2ServerSelector will see the servers permuted as:
# 2, 3, 1, 0
# Ideally, a reupload of our original data should work.
def _reset_encoding_parameters(ign, happy=4):
d.addCallback(_reset_encoding_parameters)
d.addCallback(lambda client:
client.upload(upload.Data("data" * 10000, convergence="")))
+ d.addCallback(lambda ign:
+ self.failUnless(self._has_happy_share_distribution()))
# This scenario is basically comment:53, but changed so that the
- # Tahoe2PeerSelector sees the server with all of the shares before
+ # Tahoe2ServerSelector sees the server with all of the shares before
# any of the other servers.
# The layout is:
# server 2: shares 0 - 9
# server 3: share 0
# server 1: share 1
# server 4: share 2
- # The Tahoe2PeerSelector sees the peers permuted as:
+ # The Tahoe2ServerSelector sees the servers permuted as:
# 2, 3, 1, 4
# Note that server 0 has been replaced by server 4; this makes it
- # easier to ensure that the last server seen by Tahoe2PeerSelector
+ # easier to ensure that the last server seen by Tahoe2ServerSelector
# has only one share.
d.addCallback(_change_basedir)
d.addCallback(lambda ign:
d.addCallback(_reset_encoding_parameters)
d.addCallback(lambda client:
client.upload(upload.Data("data" * 10000, convergence="")))
+ d.addCallback(lambda ign:
+ self.failUnless(self._has_happy_share_distribution()))
# Try the same thing, but with empty servers after the first one
- # We want to make sure that Tahoe2PeerSelector will redistribute
+ # We want to make sure that Tahoe2ServerSelector will redistribute
# shares as necessary, not simply discover an existing layout.
# The layout is:
# server 2: shares 0 - 9
# servers of happiness were pushed.
d.addCallback(lambda results:
self.failUnlessEqual(results.pushed_shares, 3))
+ d.addCallback(lambda ign:
+ self.failUnless(self._has_happy_share_distribution()))
return d
+ def test_problem_layout_ticket_1124(self):
+ self.basedir = self.mktemp()
+ d = self._setup_and_upload(k=2, n=4)
- def test_happiness_with_some_readonly_peers(self):
+ # server 0: shares 0, 1, 2, 3
+ # server 1: shares 0, 3
+ # server 2: share 1
+ # server 3: share 2
+ # With this layout, an upload should just be satisfied that the current distribution is good enough, right?
+ def _setup(ign):
+ self._add_server_with_share(server_number=0, share_number=None)
+ self._add_server_with_share(server_number=1, share_number=0)
+ self._add_server_with_share(server_number=2, share_number=1)
+ self._add_server_with_share(server_number=3, share_number=2)
+ # Copy shares
+ self._copy_share_to_server(3, 1)
+ client = self.g.clients[0]
+ client.DEFAULT_ENCODING_PARAMETERS['happy'] = 4
+ return client
+
+ d.addCallback(_setup)
+ d.addCallback(lambda client:
+ client.upload(upload.Data("data" * 10000, convergence="")))
+ d.addCallback(lambda ign:
+ self.failUnless(self._has_happy_share_distribution()))
+ return d
+ test_problem_layout_ticket_1124.todo = "Fix this after 1.7.1 release."
+
+ def test_happiness_with_some_readonly_servers(self):
# Try the following layout
# server 2: shares 0-9
# server 4: share 0, read-only
d.addCallback(_reset_encoding_parameters)
d.addCallback(lambda client:
client.upload(upload.Data("data" * 10000, convergence="")))
+ d.addCallback(lambda ign:
+ self.failUnless(self._has_happy_share_distribution()))
return d
- def test_happiness_with_all_readonly_peers(self):
+ def test_happiness_with_all_readonly_servers(self):
# server 3: share 1, read-only
# server 1: share 2, read-only
# server 2: shares 0-9, read-only
# server 4: share 0, read-only
# The idea with this test is to make sure that the survey of
- # read-only peers doesn't undercount servers of happiness
+ # read-only servers doesn't undercount servers of happiness
self.basedir = self.mktemp()
d = self._setup_and_upload()
d.addCallback(lambda ign:
d.addCallback(_reset_encoding_parameters)
d.addCallback(lambda client:
client.upload(upload.Data("data" * 10000, convergence="")))
+ d.addCallback(lambda ign:
+ self.failUnless(self._has_happy_share_distribution()))
return d
# the layout presented to it satisfies "servers_of_happiness"
# until a failure occurs)
#
- # This test simulates an upload where servers break after peer
+ # This test simulates an upload where servers break after server
# selection, but before they are written to.
def _set_basedir(ign=None):
self.basedir = self.mktemp()
self._add_server(server_number=5)
d.addCallback(_do_server_setup)
# remove the original server
- # (necessary to ensure that the Tahoe2PeerSelector will distribute
+ # (necessary to ensure that the Tahoe2ServerSelector will distribute
# all the shares)
def _remove_server(ign):
server = self.g.servers_by_number[0]
return d
- def test_merge_peers(self):
- # merge_peers merges a list of used_peers and a dict of
- # shareid -> peerid mappings.
+ def test_merge_servers(self):
+ # merge_servers merges a list of upload_servers and a dict of
+ # shareid -> serverid mappings.
shares = {
1 : set(["server1"]),
2 : set(["server2"]),
4 : set(["server4", "server5"]),
5 : set(["server1", "server2"]),
}
- # if not provided with a used_peers argument, it should just
+ # if not provided with a upload_servers argument, it should just
# return the first argument unchanged.
- self.failUnlessEqual(shares, merge_peers(shares, set([])))
- class FakePeerTracker:
- pass
+ self.failUnlessEqual(shares, merge_servers(shares, set([])))
trackers = []
for (i, server) in [(i, "server%d" % i) for i in xrange(5, 9)]:
- t = FakePeerTracker()
- t.peerid = server
- t.buckets = [i]
+ t = FakeServerTracker(server, [i])
trackers.append(t)
expected = {
1 : set(["server1"]),
7 : set(["server7"]),
8 : set(["server8"]),
}
- self.failUnlessEqual(expected, merge_peers(shares, set(trackers)))
+ self.failUnlessEqual(expected, merge_servers(shares, set(trackers)))
shares2 = {}
expected = {
5 : set(["server5"]),
7 : set(["server7"]),
8 : set(["server8"]),
}
- self.failUnlessEqual(expected, merge_peers(shares2, set(trackers)))
+ self.failUnlessEqual(expected, merge_servers(shares2, set(trackers)))
shares3 = {}
trackers = []
expected = {}
for (i, server) in [(i, "server%d" % i) for i in xrange(10)]:
shares3[i] = set([server])
- t = FakePeerTracker()
- t.peerid = server
- t.buckets = [i]
+ t = FakeServerTracker(server, [i])
trackers.append(t)
expected[i] = set([server])
- self.failUnlessEqual(expected, merge_peers(shares3, set(trackers)))
+ self.failUnlessEqual(expected, merge_servers(shares3, set(trackers)))
def test_servers_of_happiness_utility_function(self):
# value for given inputs.
# servers_of_happiness expects a dict of
- # shnum => set(peerids) as a preexisting shares argument.
+ # shnum => set(serverids) as a preexisting shares argument.
test1 = {
1 : set(["server1"]),
2 : set(["server2"]),
# should be 3 instead of 4.
happy = servers_of_happiness(test1)
self.failUnlessEqual(3, happy)
- # The second argument of merge_peers should be a set of
- # objects with peerid and buckets as attributes. In actual use,
- # these will be PeerTracker instances, but for testing it is fine
- # to make a FakePeerTracker whose job is to hold those instance
- # variables to test that part.
- class FakePeerTracker:
- pass
+ # The second argument of merge_servers should be a set of objects with
+ # serverid and buckets as attributes. In actual use, these will be
+ # ServerTracker instances, but for testing it is fine to make a
+ # FakeServerTracker whose job is to hold those instance variables to
+ # test that part.
trackers = []
for (i, server) in [(i, "server%d" % i) for i in xrange(5, 9)]:
- t = FakePeerTracker()
- t.peerid = server
- t.buckets = [i]
+ t = FakeServerTracker(server, [i])
trackers.append(t)
# Recall that test1 is a server layout with servers_of_happiness
# = 3. Since there isn't any overlap between the shnum ->
- # set([peerid]) correspondences in test1 and those in trackers,
+ # set([serverid]) correspondences in test1 and those in trackers,
# the result here should be 7.
- test2 = merge_peers(test1, set(trackers))
+ test2 = merge_servers(test1, set(trackers))
happy = servers_of_happiness(test2)
self.failUnlessEqual(7, happy)
# Now add an overlapping server to trackers. This is redundant,
# so it should not cause the previously reported happiness value
# to change.
- t = FakePeerTracker()
- t.peerid = "server1"
- t.buckets = [1]
+ t = FakeServerTracker("server1", [1])
trackers.append(t)
- test2 = merge_peers(test1, set(trackers))
+ test2 = merge_servers(test1, set(trackers))
happy = servers_of_happiness(test2)
self.failUnlessEqual(7, happy)
test = {}
4 : set(['server4']),
}
trackers = []
- t = FakePeerTracker()
- t.peerid = 'server5'
- t.buckets = [4]
+ t = FakeServerTracker('server5', [4])
trackers.append(t)
- t = FakePeerTracker()
- t.peerid = 'server6'
- t.buckets = [3, 5]
+ t = FakeServerTracker('server6', [3, 5])
trackers.append(t)
# The value returned by servers_of_happiness is the size
# of a maximum matching in the bipartite graph that
- # servers_of_happiness() makes between peerids and share
+ # servers_of_happiness() makes between serverids and share
# numbers. It should find something like this:
# (server 1, share 1)
# (server 2, share 2)
#
# and, since there are 5 edges in this matching, it should
# return 5.
- test2 = merge_peers(test, set(trackers))
+ test2 = merge_servers(test, set(trackers))
happy = servers_of_happiness(test2)
self.failUnlessEqual(5, happy)
# Zooko's first puzzle:
sbs = shares_by_server(test1)
self.failUnlessEqual(set([1, 2, 3]), sbs["server1"])
self.failUnlessEqual(set([4, 5]), sbs["server2"])
- # This should fail unless the peerid part of the mapping is a set
+ # This should fail unless the serverid part of the mapping is a set
test2 = {1: "server1"}
self.shouldFail(AssertionError,
"test_shares_by_server",
# server 2: empty
# server 3: empty
# server 4: empty
- # The purpose of this test is to make sure that the peer selector
+ # The purpose of this test is to make sure that the server selector
# knows about the shares on server 1, even though it is read-only.
# It used to simply filter these out, which would cause the test
# to fail when servers_of_happiness = 4.
d.addCallback(_prepare_client)
d.addCallback(lambda client:
client.upload(upload.Data("data" * 10000, convergence="")))
+ d.addCallback(lambda ign:
+ self.failUnless(self._has_happy_share_distribution()))
return d
def test_query_counting(self):
- # If peer selection fails, Tahoe2PeerSelector prints out a lot
+ # If server selection fails, Tahoe2ServerSelector prints out a lot
# of helpful diagnostic information, including query stats.
# This test helps make sure that that information is accurate.
self.basedir = self.mktemp()
c.upload, upload.Data("data" * 10000,
convergence="")))
# Now try with some readonly servers. We want to make sure that
- # the readonly peer share discovery phase is counted correctly.
+ # the readonly server share discovery phase is counted correctly.
def _reset(ign):
self.basedir = self.mktemp()
self.g = None
d.addCallback(lambda client:
self.shouldFail(UploadUnhappinessError,
"test_upper_limit_on_readonly_queries",
- "sent 8 queries to 8 peers",
+ "sent 8 queries to 8 servers",
client.upload,
upload.Data('data' * 10000, convergence="")))
return d
- def test_exception_messages_during_peer_selection(self):
+ def test_exception_messages_during_server_selection(self):
# server 1: read-only, no shares
# server 2: read-only, no shares
# server 3: read-only, no shares
"total (10 homeless), want to place shares on at "
"least 4 servers such that any 3 of them have "
"enough shares to recover the file, "
- "sent 5 queries to 5 peers, 0 queries placed "
+ "sent 5 queries to 5 servers, 0 queries placed "
"some shares, 5 placed none "
"(of which 5 placed none due to the server being "
"full and 0 placed none due to an error)",
d.addCallback(lambda ign:
self._add_server(server_number=2))
def _break_server_2(ign):
- server = self.g.servers_by_number[2].my_nodeid
- # We have to break the server in servers_by_id,
- # because the one in servers_by_number isn't wrapped,
- # and doesn't look at its broken attribute when answering
- # queries.
- self.g.servers_by_id[server].broken = True
+ serverid = self.g.servers_by_number[2].my_nodeid
+ self.g.break_server(serverid)
d.addCallback(_break_server_2)
d.addCallback(lambda ign:
self._add_server(server_number=3, readonly=True))
"total (10 homeless), want to place shares on at "
"least 4 servers such that any 3 of them have "
"enough shares to recover the file, "
- "sent 5 queries to 5 peers, 0 queries placed "
+ "sent 5 queries to 5 servers, 0 queries placed "
"some shares, 5 placed none "
"(of which 4 placed none due to the server being "
"full and 1 placed none due to an error)",
d.addCallback(_setup)
d.addCallback(lambda client:
client.upload(upload.Data("data" * 10000, convergence="")))
+ d.addCallback(lambda ign:
+ self.failUnless(self._has_happy_share_distribution()))
return d
test_problem_layout_comment_187.todo = "this isn't fixed yet"
+ def test_problem_layout_ticket_1118(self):
+ # #1118 includes a report from a user who hit an assertion in
+ # the upload code with this layout.
+ self.basedir = self.mktemp()
+ d = self._setup_and_upload(k=2, n=4)
+
+ # server 0: no shares
+ # server 1: shares 0, 3
+ # server 3: share 1
+ # server 2: share 2
+ # The order that they get queries is 0, 1, 3, 2
+ def _setup(ign):
+ self._add_server(server_number=0)
+ self._add_server_with_share(server_number=1, share_number=0)
+ self._add_server_with_share(server_number=2, share_number=2)
+ self._add_server_with_share(server_number=3, share_number=1)
+ # Copy shares
+ self._copy_share_to_server(3, 1)
+ storedir = self.get_serverdir(0)
+ # remove the storedir, wiping out any existing shares
+ shutil.rmtree(storedir)
+ # create an empty storedir to replace the one we just removed
+ os.mkdir(storedir)
+ client = self.g.clients[0]
+ client.DEFAULT_ENCODING_PARAMETERS['happy'] = 4
+ return client
+
+ d.addCallback(_setup)
+ # Note: actually it should succeed! See
+ # test_problem_layout_ticket_1128. But ticket 1118 is just to
+ # make it realize that it has failed, so if it raises
+ # UploadUnhappinessError then we'll give it the green light
+ # for now.
+ d.addCallback(lambda ignored:
+ self.shouldFail(UploadUnhappinessError,
+ "test_problem_layout_ticket_1118",
+ "",
+ self.g.clients[0].upload, upload.Data("data" * 10000,
+ convergence="")))
+ return d
+
+ def test_problem_layout_ticket_1128(self):
+ # #1118 includes a report from a user who hit an assertion in
+ # the upload code with this layout.
+ self.basedir = self.mktemp()
+ d = self._setup_and_upload(k=2, n=4)
+
+ # server 0: no shares
+ # server 1: shares 0, 3
+ # server 3: share 1
+ # server 2: share 2
+ # The order that they get queries is 0, 1, 3, 2
+ def _setup(ign):
+ self._add_server(server_number=0)
+ self._add_server_with_share(server_number=1, share_number=0)
+ self._add_server_with_share(server_number=2, share_number=2)
+ self._add_server_with_share(server_number=3, share_number=1)
+ # Copy shares
+ self._copy_share_to_server(3, 1)
+ storedir = self.get_serverdir(0)
+ # remove the storedir, wiping out any existing shares
+ shutil.rmtree(storedir)
+ # create an empty storedir to replace the one we just removed
+ os.mkdir(storedir)
+ client = self.g.clients[0]
+ client.DEFAULT_ENCODING_PARAMETERS['happy'] = 4
+ return client
+
+ d.addCallback(_setup)
+ d.addCallback(lambda client:
+ client.upload(upload.Data("data" * 10000, convergence="")))
+ d.addCallback(lambda ign:
+ self.failUnless(self._has_happy_share_distribution()))
+ return d
+ test_problem_layout_ticket_1128.todo = "Invent a smarter uploader that uploads successfully in this case."
def test_upload_succeeds_with_some_homeless_shares(self):
# If the upload is forced to stop trying to place shares before
d.addCallback(_server_setup)
d.addCallback(lambda client:
client.upload(upload.Data("data" * 10000, convergence="")))
+ d.addCallback(lambda ign:
+ self.failUnless(self._has_happy_share_distribution()))
return d
d.addCallback(_server_setup)
d.addCallback(lambda client:
client.upload(upload.Data("data" * 10000, convergence="")))
+ d.addCallback(lambda ign:
+ self.failUnless(self._has_happy_share_distribution()))
+ return d
+
+
+ def test_server_selector_bucket_abort(self):
+ # If server selection for an upload fails due to an unhappy
+ # layout, the server selection process should abort the buckets it
+ # allocates before failing, so that the space can be re-used.
+ self.basedir = self.mktemp()
+ self.set_up_grid(num_servers=5)
+
+ # Try to upload a file with happy=7, which is unsatisfiable with
+ # the current grid. This will fail, but should not take up any
+ # space on the storage servers after it fails.
+ client = self.g.clients[0]
+ client.DEFAULT_ENCODING_PARAMETERS['happy'] = 7
+ d = defer.succeed(None)
+ d.addCallback(lambda ignored:
+ self.shouldFail(UploadUnhappinessError,
+ "test_server_selection_bucket_abort",
+ "",
+ client.upload, upload.Data("data" * 10000,
+ convergence="")))
+ # wait for the abort messages to get there.
+ def _turn_barrier(res):
+ return fireEventually(res)
+ d.addCallback(_turn_barrier)
+ def _then(ignored):
+ for server in self.g.servers_by_number.values():
+ self.failUnlessEqual(server.allocated_size(), 0)
+ d.addCallback(_then)
+ return d
+
+
+ def test_encoder_bucket_abort(self):
+ # If enough servers die in the process of encoding and uploading
+ # a file to make the layout unhappy, we should cancel the
+ # newly-allocated buckets before dying.
+ self.basedir = self.mktemp()
+ self.set_up_grid(num_servers=4)
+
+ client = self.g.clients[0]
+ client.DEFAULT_ENCODING_PARAMETERS['happy'] = 7
+
+ d = defer.succeed(None)
+ d.addCallback(lambda ignored:
+ self.shouldFail(UploadUnhappinessError,
+ "test_encoder_bucket_abort",
+ "",
+ self._do_upload_with_broken_servers, 1))
+ def _turn_barrier(res):
+ return fireEventually(res)
+ d.addCallback(_turn_barrier)
+ def _then(ignored):
+ for server in self.g.servers_by_number.values():
+ self.failUnlessEqual(server.allocated_size(), 0)
+ d.addCallback(_then)
return d
return None
# TODO:
-# upload with exactly 75 peers (shares_of_happiness)
+# upload with exactly 75 servers (shares_of_happiness)
# have a download fail
# cancel a download (need to implement more cancel stuff)
+
+# from test_encode:
+# NoNetworkGrid, upload part of ciphertext, kill server, continue upload
+# check with Kevan, they want to live in test_upload, existing tests might cover
+# def test_lost_one_shareholder(self): # these are upload-side tests
+# def test_lost_one_shareholder_early(self):
+# def test_lost_many_shareholders(self):
+# def test_lost_all_shareholders(self):
projects / tahoe-lafs / tahoe-lafs.git / blobdiff