Discourage future readers of iputil.py from using Win32 APIs in preference to route...

[tahoe-lafs/tahoe-lafs.git] / src / allmydata / util / iputil.py

diff --git a/src/allmydata/util/iputil.py b/src/allmydata/util/iputil.py
index d58c578aaf646a09bde8efa5916f717606c53c77..4b90b250bd589c30b61f9cf8bedae6f22c09dd42 100644 (file)
--- a/src/allmydata/util/iputil.py
+++ b/src/allmydata/util/iputil.py
@@ -142,8 +142,10 @@ def get_local_ip_for(target):
 
 # Wow, I'm really amazed at home much mileage we've gotten out of calling
 # the external route.exe program on windows...  It appears to work on all
-# versions so far.  Still, the real system calls would much be preferred...
+# versions so far.
 # ... thus wrote Greg Smith in time immemorial...
+# Also, the Win32 APIs for this are really klunky and error-prone. --Daira
+
 _win32_re = re.compile(r'^\s*\d+\.\d+\.\d+\.\d+\s.+\s(?P<address>\d+\.\d+\.\d+\.\d+)\s+(?P<metric>\d+)\s*$', flags=re.M|re.I|re.S)
 _win32_commands = (('route.exe', ('print',), _win32_re),)