change upload to push 2 shares instead of 3

Now that peers can talk to themselves, the 5-node system test won't fail
just because one of the shares was hosted on the downloader (and thus
inaccessible until recently). The 3-share push was there to avoid this
problem.

diff --git a/src/allmydata/upload.py b/src/allmydata/upload.py
index 5121bc930a08afe69d9172be881b535f221d76a1..653ada41c7c3d6bcd57d9175c4809214bb4c6e2c 100644 (file)
--- a/src/allmydata/upload.py
+++ b/src/allmydata/upload.py
@@ -270,12 +270,9 @@ class Uploader(service.MultiService):
         if self.debug:
             u.debug = True
         u.set_filehandle(fh)
-        # TODO: change this to (2,2,4) once Foolscap is fixed to allow
-        # connect-to-self and Client is fixed to include ourselves in the
-        # peerlist. Otherwise this usually fails because we give a share to
-        # the eventual downloader, and they won't try to get a share from
-        # themselves.
-        u.set_params(2, 3, 4)
+        # push two shares, require that we get two back. TODO: this is
+        # temporary, of course.
+        u.set_params(2, 2, 4)
         u.set_verifierid(self._compute_verifierid(fh))
         d = u.start()
         def _done(res):