From: Brian Warner <warner@allmydata.com>
Date: Mon, 9 Jun 2008 23:06:29 +0000 (-0700)
Subject: Makefile: build twice, since sometimes the Nevow build fails the first time. See... 
X-Git-Tag: allmydata-tahoe-1.1.0~30
X-Git-Url: https://git.rkrishnan.org/?a=commitdiff_plain;h=08d07f0cc5c9084d53628a9ac9b8718a193f3d5f;p=tahoe-lafs%2Ftahoe-lafs.git

Makefile: build twice, since sometimes the Nevow build fails the first time. See #455. This ought to be undone once that ticket is fixed by a new release of setuptools
---

diff --git a/Makefile b/Makefile
index 672aa99c..425c8920 100644
--- a/Makefile
+++ b/Makefile
@@ -87,7 +87,22 @@ make-version:
 src/allmydata/_version.py:
 	$(MAKE) make-version
 
+# c.f. ticket #455, there is a problem in the intersection of setuptools,
+# twisted's setup.py, and nevow's setup.py . A Tahoe build, to satisfy its
+# dependencies, may try to build both Twisted and Nevow. If both of these
+# occur during the same invocation of 'setup.py develop', then the Nevow
+# build will fail with an "ImportError: No module named components". Running
+# the build a second time will succeed. Until there is a new version of
+# setuptools which properly sandboxes sys.modules (or a new version of nevow
+# which doesn't import twisted during its build, or a new version of twisted
+# which doesn't import itself during its build), we just build tahoe twice
+# and ignore the errors from the first pass.
+
 build: src/allmydata/_version.py
+	-$(MAKE) build-once
+	$(MAKE) build-once
+
+build-once:
 	mkdir -p "$(SUPPORTLIB)"
 	$(PP) $(PYTHON) ./setup.py develop --prefix="$(SUPPORT)"
 	chmod +x bin/tahoe