From: Brian Warner Date: Mon, 8 Feb 2016 22:39:28 +0000 (-0800) Subject: Merge pull request #236 from daira/2725.timezone-test.0 X-Git-Url: https://git.rkrishnan.org/?a=commitdiff_plain;h=HEAD;hp=-c;p=tahoe-lafs%2Ftahoe-lafs.git Merge pull request #236 from daira/2725.timezone-test.0 Fix tests on platforms without time.tzset (e.g. Windows) --- 186f6d4a59a879ee93207a48bca15fbdf2741206 diff --combined src/allmydata/test/test_util.py index 69d3c747,be5541e8..e59e14ab --- a/src/allmydata/test/test_util.py +++ b/src/allmydata/test/test_util.py @@@ -932,6 -932,10 +932,10 @@@ class TimeFormat(unittest.TestCase, Tim # time_format.iso_utc_time_to_localseconds() breaks if the timezone is # Europe/London. (As soon as this unit test is done then I'll change # that implementation to something that works even in this case...) + + if not self.have_working_tzset(): + raise unittest.SkipTest("This test can't be run on a platform without time.tzset().") + self.setTimezone("Europe/London") return self._help_test_epoch() @@@ -1006,10 -1010,9 +1010,10 @@@ def test_format_time_y2038(self): seconds_per_day = 60*60*24 leap_years_1970_to_2047_inclusive = ((2044 - 1968) // 4) - self.failUnlessEqual(time_format.format_time(time.gmtime(seconds_per_day*((2048 - 1970)*365+leap_years_1970_to_2047_inclusive))), '2048-01-01 00:00:00') - - test_format_time_y2038.todo = "This test is known to fail on systems with 32-bit time_t." + try: + self.failUnlessEqual(time_format.format_time(time.gmtime(seconds_per_day*((2048 - 1970)*365+leap_years_1970_to_2047_inclusive))), '2048-01-01 00:00:00') + except unittest.FailTest: + raise unittest.SkipTest("Note: this system cannot handle dates after 2037.") def test_format_delta(self): time_1 = 1389812723