Remove or comment out print statements and improve logging.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Remove MagicFolderTestMixin._create_magicfolder.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Remove MagicFolderCLITestMixin.create_magicfolder.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Minor cleanup.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Remove redundant inotify parameters to MagicFolder and Uploader constructors.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Ensure that fake_inotify is used for restarted clients in MockTest.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Compare size and ctime as well as mtime.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix test bug that accidentally suppressed errors.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Teach should_ignore_file to require unicode

Simply should_ignore_file helper function

Activate test_alice_bob test

it was previously renamed to ommit it from unit test runs

Remove old debugging print statements

WIP

remove debug print statements

Fix version incrementation bug

only increment if mtimes are differing...

Add is_new_file_time db helper function

this is for comparing mtimes

Fix bug in Downloader's _get_local_latest

previously the magic-folder path was not prepended
to the file path... thus the file didn't exist and
the call to _get_local_latest returned None.

Teach test_persistence to only use one clientdir

This effectively fixes the bug where upon restart the client
uses a different clientdir

WIP

fix unit test helper _wait_until_started by using ready()

Teach test_persistence to upload a 2nd file

test fails...

Teach test_persistence to restart client with the new no network grid api changes

Add should_ignore_file and tests

This helper function will be used by magic-folder to
determine when to drop a file from the upload queue...
it ignores hidden files and certain suffixed files.

Repair test_replace_file for the case where the replaced file did not already exist
(which is no longer considered an error).

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Repair test.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

restart_client needs to remove the old client from its parent, not just stop it.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

startService can be called more than once.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Comment out some print statements.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Cleanup of _restart_client.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix a logging bug for Unicode nicknames.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

WIP

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Solve a potential race condition by waiting until the uploader is started.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Remove self.client and stats_provider attributes which could get out-of-sync with self.get_client().

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Add 'started' hook to Magic Folder uploader.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Remove unused variables.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Add _restart_client callback.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

stopService does not necessarily return a Deferred.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Add a restart_client method to GridTestMixin.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Rename test_cli_magic_folder.MagicFolderTestMixin to MagicFolderCLITestMixin.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Add print statements.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

WIP

Revert "Attempt to fix test_persistence"

This reverts commit 257d6665d29454351886d9c1125d214b21c324f7.

Attempt to fix test_persistence

broken WIP, startup path was broken

Add db util function for retrieving all downloaded files

More precise and correct error reporting in replace_file.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix path handling in Downloader._process.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Make _write_downloaded_file return the path of the destination file.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

replace_file should not fail if replaced_path does not exist.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Restore some print statements.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Move the test for _write_download_file() to test_magic_folder module

_process(): pass absolute path to the _write_download_file()

WIP: test for _write_downloaded_file

magic_folder: typo utimes -> utime

more debugging print statements

Uncomment alice bob test print statements

Remove stupid errback and raise proper conflict exception

Fix replace_file; rename only if replaced_path exists

Add err print statement to show the conflict...

Capture exceptions from conflict and write info in magic folder db

Fix _write_downloaded_file by adding base path

Correct spelling is os.utime not utimes

Add Downloader._write_downloaded_file. refs ticket:2489

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Remove debug prints in backupdb.py.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Remove or comment out print statements.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Rename Client.upload_ready_d to connected_enough_d.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

In Downloader._get_collective_latest_file, consume errors when getting metadata.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Teach uploader to process lazy tail upon stop method

Teach magic-folder ready method to return a deferred

Fix a bug in Downloader._scan_remote that incorrectly skips subsequent files
(and drops a Deferred) when local version >= remote version.
Also simplify that code and robustify it for the case where the version metadata is missing.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Use deferredutil.HookMixin to simplify callback for tests.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Minor fix to alice bob test

Fix _scan_remote and remove print statements

Fix incorrect order of fields in SQL statement.
My kingdom for a better SQL DSL.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Cleanup.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

More debug prints.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Debug prints to diagnose version mismatch after deletion (backupdb).

Debug prints to diagnose version mismatch after deletion.

Add some print statements.

Merge pull request #184 from vu3rdd/2477.refactor-all-the-things.0

test for get_pathinfo()

test_get_pathinfo: testdir is unnecessary

Use basedir itself, instead of creating another directory inside basedir.

test_get_pathinfo: rename the identifier d to testdir

d, by convention, is used for the Twisted Deferred objects.

add more tests for get_pathinfo()

When operating on a file, test if the "file" is not a directory
or a symlink. Likewise for directory and symlink.

Add test for get_pathinfo()

Use get_pathinfo instead of separate os.path.{is*,exists} calls.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Extend get_pathinfo to add size, ctime and mtime.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Remove an unnecessary precondition and an incorrect comment.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Add fileutil.get_pathinfo function.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Extract get_metadata and get_filenode to methods of Uploader.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Processing symlinks and special files should not be an error.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Refactor uploader by inlining _add_file into _process._maybe_upload.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Refactor uploader by inlining _add_file into _process._maybe_upload.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Refactor uploader by extracting _process_child to a top-level method.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Swap two checks to clarify which is failing.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

fix code that adds version number of deleted file to magic-folder db

enable version checking tests - currently a righteous fail

make various changes - work in progress

add version checking to alice bob test

Update magic-folder db after download

Add final download to alice bob test

- that is to say after alice deletes the file she rewrites it
and this causes bob to download this latest version

Remove old unused append to deque function from downloader