From 3c757a524f3e2c7f9c74dba7d0a77b665a978ed6 Mon Sep 17 00:00:00 2001 From: Brian Warner Date: Thu, 29 Mar 2007 11:16:29 -0700 Subject: [PATCH] introducer: add some comments about separating nodeid from tubid --- src/allmydata/introducer.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/allmydata/introducer.py b/src/allmydata/introducer.py index 08520d85..d2fe6c3c 100644 --- a/src/allmydata/introducer.py +++ b/src/allmydata/introducer.py @@ -62,6 +62,15 @@ class IntroducerClient(service.Service, Referenceable): def _new_peer(self, pburl): if pburl in self.reconnectors: return + # TODO: rather than using the TubID as a nodeid, we should use + # something else. The thing that requires the least additional + # mappings is to use the foolscap "identifier" (the last component of + # the pburl), since these are unguessable. Before we can do that, + # though, we need a way to conveniently make these identifiers + # persist from one run of the client program to the next. Also, using + # the foolscap identifier would mean that anyone who knows the name + # of the node also has all the secrets they need to contact and use + # them, which may or may not be what we want. m = re.match(r'pb://(\w+)@', pburl) assert m nodeid = idlib.a2b(m.group(1)) -- 2.45.2