more hlint fixes

[functorrent.git] / src / FuncTorrent / PeerMsgs.hs

diff --git a/src/FuncTorrent/PeerMsgs.hs b/src/FuncTorrent/PeerMsgs.hs
index 79c41c298b6182b088998fe6b4aa63b205abd32e..f597ed8c6ee676b3581b25e96a264d7fa35c2fd4 100644 (file)
--- a/src/FuncTorrent/PeerMsgs.hs
+++ b/src/FuncTorrent/PeerMsgs.hs
@@ -24,6 +24,7 @@ module FuncTorrent.PeerMsgs
         sendMsg,
         getMsg,
         Peer(..),
+        makePeer,
         PeerMsg(..)
        ) where
 
@@ -32,6 +33,7 @@ import Prelude hiding (lookup, concat, replicate, splitAt, take)
 import System.IO (Handle)
 import Data.ByteString (ByteString, pack, unpack, concat, hGet, hPut, singleton)
 import Data.ByteString.Lazy (fromStrict, fromChunks, toStrict)
+import Data.ByteString.Char8 as BC (splitAt)
 import qualified Data.ByteString.Char8 as BC (replicate, pack)
 import Control.Monad (replicateM, liftM)
 import Control.Applicative (liftA3)
@@ -40,8 +42,10 @@ import Data.Binary (Binary(..), decode, encode)
 import Data.Binary.Put (putWord32be, putWord16be, putWord8)
 import Data.Binary.Get (getWord32be, getWord16be, getWord8, runGet)
 
--- | Peer is a PeerID, IP address, port tuple
-data Peer = Peer ID IP Port
+import FuncTorrent.Utils (toIP, toPort)
+
+-- | Peer is a IP address, port tuple
+data Peer = Peer IP Port
           deriving (Show, Eq)
 
 type ID = String
@@ -82,9 +86,7 @@ instance Binary PeerMsg where
                                           bfListLen = length bfList
              RequestMsg i o l -> do putWord32be 13
                                     putWord8 6
-                                    putWord32be (fromIntegral i)
-                                    putWord32be (fromIntegral o)
-                                    putWord32be (fromIntegral l)
+                                    putIndexOffsetLength i o l
              PieceMsg i o b -> do putWord32be $ fromIntegral (9 + blocklen)
                                   putWord8 7
                                   putWord32be (fromIntegral i)
@@ -94,12 +96,15 @@ instance Binary PeerMsg where
                                           blocklen = length blockList
              CancelMsg i o l -> do putWord32be 13
                                    putWord8 8
-                                   putWord32be (fromIntegral i)
-                                   putWord32be (fromIntegral o)
-                                   putWord32be (fromIntegral l)
+                                   putIndexOffsetLength i o l
              PortMsg p -> do putWord32be 3
                              putWord8 9
                              putWord16be (fromIntegral p)
+    where putIndexOffsetLength i o l = do
+            putWord32be (fromIntegral i)
+            putWord32be (fromIntegral o)
+            putWord32be (fromIntegral l)
+            
   get = do
     l <- getWord32be
     msgid <- getWord8
@@ -108,15 +113,15 @@ instance Binary PeerMsg where
      1 -> return UnChokeMsg
      2 -> return InterestedMsg
      3 -> return NotInterestedMsg
-     4 -> liftM (HaveMsg . fromIntegral) getWord32be
-     5 -> liftM (BitFieldMsg . pack) (replicateM (fromIntegral l - 1) getWord8)
+     4 -> fmap (HaveMsg . fromIntegral) getWord32be
+     5 -> fmap (BitFieldMsg . pack) (replicateM (fromIntegral l - 1) getWord8)
      6 -> liftA3 RequestMsg getInteger getInteger getInteger
        where getInteger = fromIntegral <$> getWord32be
      7 -> liftA3 PieceMsg getInteger getInteger (pack  <$> replicateM (fromIntegral l - 9) getWord8)
        where getInteger = fromIntegral <$> getWord32be
      8 -> liftA3 CancelMsg getInteger getInteger getInteger
        where getInteger = fromIntegral <$> getWord32be
-     9 -> liftM (PortMsg . fromIntegral) getWord16be
+     9 -> fmap (PortMsg . fromIntegral) getWord16be
      _ -> error ("unknown message ID: " ++ show msgid)
 
 getMsg :: Handle -> IO PeerMsg
@@ -142,3 +147,7 @@ genHandshakeMsg infoHash peer_id = concat [pstrlen, pstr, reserved, infoHash, pe
 
 bsToInt :: ByteString -> Int
 bsToInt x = fromIntegral (runGet getWord32be (fromChunks (return x)))
+
+makePeer :: ByteString -> Peer
+makePeer peer = Peer (toIP ip') (toPort port')
+  where (ip', port') = splitAt 4 peer