Ensure the 'base' argument to abspath_expanduser_unicode takes effect on Windows...

[tahoe-lafs/tahoe-lafs.git] / src / allmydata / util / fileutil.py

diff --git a/src/allmydata/util/fileutil.py b/src/allmydata/util/fileutil.py
index 74132733169f306f8feb668f565d547f9b6f4df9..4dd501ce82a505eaf8cb16b4d14aa218dae655a9 100644 (file)
--- a/src/allmydata/util/fileutil.py
+++ b/src/allmydata/util/fileutil.py
@@ -318,10 +318,14 @@ def abspath_expanduser_unicode(path, base=None):
     path = expanduser(path)
 
     if _getfullpathname:
-        # On Windows, os.path.isabs will return True for paths without a drive letter,
+        # On Windows, os.path.isabs will incorrectly return True
+        # for paths without a drive letter (that are not UNC paths),
         # e.g. "\\". See <http://bugs.python.org/issue1669539>.
         try:
-            path = _getfullpathname(path or u".")
+            if base is None:
+                path = _getfullpathname(path or u".")
+            else:
+                path = _getfullpathname(os.path.join(base, path))
         except OSError:
             pass