From cdf1752a5d20e050276a32a322b6a508369f1f30 Mon Sep 17 00:00:00 2001 From: David-Sarah Hopwood Date: Fri, 8 Feb 2013 19:27:57 +0000 Subject: [PATCH] Add comment explaining fix to #1679. refs #1679 Signed-off-by: David-Sarah Hopwood --- src/allmydata/nodemaker.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/allmydata/nodemaker.py b/src/allmydata/nodemaker.py index d590bf5a..d0c00246 100644 --- a/src/allmydata/nodemaker.py +++ b/src/allmydata/nodemaker.py @@ -72,6 +72,10 @@ class NodeMaker: cap = uri.from_string(bigcap, deep_immutable=deep_immutable, name=name) node = self._create_from_single_cap(cap) + + # node is None for an unknown URI, otherwise it is a type for which + # is_mutable() is known. We avoid cacheing mutable nodes due to + # ticket #1679. if node is None: # don't cache UnknownNode node = UnknownNode(writecap, readcap, -- 2.45.2