From b90d4a243e677a003849a9579c5c026c94e7d2c8 Mon Sep 17 00:00:00 2001 From: Brian Warner Date: Wed, 16 May 2007 11:57:20 -0700 Subject: [PATCH] make-version.py: use 'subprocess' module instead of 'commands', to improve windows compatibility --- misc/make-version.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/misc/make-version.py b/misc/make-version.py index a4f68164..c3d284c3 100644 --- a/misc/make-version.py +++ b/misc/make-version.py @@ -33,8 +33,9 @@ get 'darcs changes --from-tag=' to accept real regexps). """ -import os, sys, commands, re +import os, sys, re import xml.dom.minidom +from subprocess import Popen, PIPE def get_text(nodelist): rc = "" @@ -68,8 +69,10 @@ def update(): return 0 print "no _darcs/ but no version.py either: how did you get this tree?" return 0 - cmd = "darcs changes --from-tag=^allmydata-tahoe --xml-output" - (rc, output) = commands.getstatusoutput(cmd) + cmd = ["darcs", "changes", "--from-tag=^allmydata-tahoe", "--xml-output"] + p = Popen(cmd, stdout=PIPE) + output = p.communicate()[0] + rc = p.returncode if rc != 0: print "unable to run 'darcs changes':" print output -- 2.45.2