From: Zooko O'Whielacronx <zooko@zooko.com>
Date: Wed, 7 May 2008 15:39:03 +0000 (-0700)
Subject: docs: fix a few stale comments in code
X-Git-Tag: allmydata-tahoe-1.1.0~157
X-Git-Url: https://git.rkrishnan.org/components/%22news.html/...?a=commitdiff_plain;h=c1184f51e44f71df0ab0747da0747adba6bddaa0;p=tahoe-lafs%2Ftahoe-lafs.git

docs: fix a few stale comments in code
---

diff --git a/src/allmydata/interfaces.py b/src/allmydata/interfaces.py
index 4a0225e9..b3dbed39 100644
--- a/src/allmydata/interfaces.py
+++ b/src/allmydata/interfaces.py
@@ -20,7 +20,7 @@ ShareData = StringConstraint(None)
 URIExtensionData = StringConstraint(1000)
 Number = IntegerConstraint(8) # 2**(8*8) == 16EiB ~= 18e18 ~= 18 exabytes
 Offset = Number
-ReadSize = int # the 'int' constraint is 2**31 == 2Gib
+ReadSize = int # the 'int' constraint is 2**31 == 2Gib -- large files are processed in not-so-large increments
 LeaseRenewSecret = Hash # used to protect bucket lease renewal requests
 LeaseCancelSecret = Hash # used to protect bucket lease cancellation requests
 
@@ -186,8 +186,6 @@ class RIBucketWriter(RemoteInterface):
 
 class RIBucketReader(RemoteInterface):
     def read(offset=Offset, length=ReadSize):
-        # ShareData is limited to 1MiB, so we don't need length= to be any
-        # larger than that. Large files must be read in pieces.
         return ShareData
 
 TestVector = ListOf(TupleOf(Offset, ReadSize, str, str))
diff --git a/src/allmydata/storage.py b/src/allmydata/storage.py
index 60c643be..8c086dd0 100644
--- a/src/allmydata/storage.py
+++ b/src/allmydata/storage.py
@@ -24,9 +24,8 @@ class DataTooLargeError(Exception):
 # storage/shares/$START/$STORAGEINDEX
 # storage/shares/$START/$STORAGEINDEX/$SHARENUM
 
-# Where "$START" denotes the first 14 bits worth of $STORAGEINDEX (that's 3
-# base-32 chars, but the last one has only 4 bits in it -- i.e. only 16 possible
-# chars in the last position).
+# Where "$START" denotes the first 10 bits worth of $STORAGEINDEX (that's 2
+# base-32 chars).
 
 # $SHARENUM matches this regex:
 NUM_RE=re.compile("^[0-9]+$")