Brian Warner [Tue, 26 May 2015 18:32:14 +0000 (11:32 -0700)]
wrap long lines, and tolerate various-width wrappings of the --help output
test_cli.Help was too sensitive to the way that the --help output was
wrapped, which caused failures on travis when COLUMNS= was set low and
the expected strings were split across separate lines.
Brian Warner [Tue, 26 May 2015 18:31:06 +0000 (11:31 -0700)]
cli: improve formatting of all commands
Also:
* do some light refactoring of create-client/node
* make it clear that these commands' --basedir options do the same as
the global --node-directory option
* use "global-options" instead of "global-opts"
Brian Warner [Tue, 26 May 2015 18:29:49 +0000 (11:29 -0700)]
scripts: improve rendering of synopsis/usage
Subcommands "--help" is now rendered as:
```
tahoe [global-options] COMMAND [options] ARGS
(use 'tahoe --help' to view global options)
USAGE (flags/options)
DESCRIPTION
DESCRIPTION_UNWRAPPED
```
The new .description and .description_unwrapped fields allow
commands (subclasses of twisted.python.usage.Usage) better control over
how their explanations are rendered: the old .longdesc field was wrapped
unpleasantly.
Brian Warner [Tue, 26 May 2015 15:11:44 +0000 (08:11 -0700)]
scripts/runner.py: put command group descriptions in parens
Brian Warner [Tue, 26 May 2015 15:06:06 +0000 (08:06 -0700)]
refactor scripts/common.py: move _default_nodedir out to its own file
Daira Hopwood [Tue, 26 May 2015 18:22:24 +0000 (19:22 +0100)]
Merge pull request #169 from zooko/2433-dead-code-NamedTemporaryDirectory
remove dead code: NamedTemporaryDirectory
Zooko [Tue, 26 May 2015 17:20:11 +0000 (17:20 +0000)]
remove dead code: NamedTemporaryDirectory
fixes #2433
Brian Warner [Fri, 22 May 2015 00:41:49 +0000 (17:41 -0700)]
NEWS: update lists of tickets closed/referenced-as-not-closed
Brian Warner [Thu, 21 May 2015 23:21:02 +0000 (16:21 -0700)]
test-desert-island wasn't catching https downloads
I think the desert-island build is broken, but the automated test wasn't
catching it because of this bug.
Brian Warner [Thu, 21 May 2015 23:19:52 +0000 (16:19 -0700)]
NEWS: update with all recent changes. Still unedited.
Brian Warner [Thu, 21 May 2015 22:59:19 +0000 (15:59 -0700)]
MANIFEST.in: add some missing files so tarballs are complete
Daira Hopwood [Mon, 18 May 2015 00:42:01 +0000 (01:42 +0100)]
fileutil.py: use ctypes.get_last_error() instead of GetLastError(). refs #1531
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Wed, 13 May 2015 13:42:31 +0000 (14:42 +0100)]
On Windows, the user's home directory may be either %USERPROFILE% or %HOMEDRIVE%%HOMEPATH% depending on the Windows version. fixes ticket:2417
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 28 Apr 2015 22:35:06 +0000 (23:35 +0100)]
interfaces.py: fix arguments to create_subdirectory.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 28 Apr 2015 20:16:26 +0000 (21:16 +0100)]
drop-upload.py: fix error messages.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Wed, 13 May 2015 13:20:13 +0000 (14:20 +0100)]
Fix a pyflakes warning.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Wed, 13 May 2015 12:36:04 +0000 (13:36 +0100)]
Update copy of gen-package-table.py in source tree.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Sat, 2 May 2015 21:26:39 +0000 (22:26 +0100)]
Retire the setup_requires hack in cases where it isn't needed (and can cause build problems). refs #2286
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Wed, 13 May 2015 11:49:10 +0000 (12:49 +0100)]
NEWS.rst: add dependency updates. fixes #2415
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Sat, 2 May 2015 20:38:48 +0000 (21:38 +0100)]
_auto_deps.py: update comments. refs #2416
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Sat, 2 May 2015 20:38:05 +0000 (21:38 +0100)]
Allow working with Twisted >= 13 on Windows if pywin32 is manually installed. fixes #2416
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 11 May 2015 20:06:17 +0000 (21:06 +0100)]
Merge pull request #165 from pataquets/add-dockerfile
Base Dockerfile initial version.
amontero-referup [Mon, 11 May 2015 17:04:30 +0000 (19:04 +0200)]
Remove .bashrc alias uncommenting.
Daira Hopwood [Mon, 11 May 2015 14:05:42 +0000 (15:05 +0100)]
docs/frontends/CLI.rst: clarification.
The implementation (in [source:src/allmydata/scripts/common.py]) actually tests whether there is a slash anywhere before the first colon.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 11 May 2015 13:50:32 +0000 (14:50 +0100)]
docs/frontends/CLI.rst: remove a superfluous TODO.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
pataquets [Sun, 10 May 2015 12:07:48 +0000 (14:07 +0200)]
Base Dockerfile initial version.
Brian Warner [Mon, 4 May 2015 05:14:53 +0000 (22:14 -0700)]
Merge branch '2399-cp-mkdir'
closes ticket:2399
Brian Warner [Mon, 4 May 2015 05:03:25 +0000 (22:03 -0700)]
apply review feedback
Brian Warner [Sat, 2 May 2015 00:37:07 +0000 (17:37 -0700)]
cp: trailing slash on source filename is an error, just like on targets
Brian Warner [Mon, 4 May 2015 05:13:52 +0000 (22:13 -0700)]
tahoe cp: ignore trailing slash on source arguments
This avoids an error case where an empty child name resulted in a
duplicate mkdir. It adds a precondition check to guard against empty
child names, and some test cases. It also cleans up a funny redundancy
noticed earlier (refs ticket:2329).
Brian Warner [Mon, 4 May 2015 04:49:34 +0000 (21:49 -0700)]
Improve docs on 'cp -r', noting the recent 2329 changes
refs ticket:2329
Daira Hopwood [Fri, 1 May 2015 21:07:27 +0000 (22:07 +0100)]
Update title of OpenSSL and pyOpenSSL build instructions.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Fri, 1 May 2015 20:43:43 +0000 (21:43 +0100)]
Add OpenSSL and pyOpenSSL build instructions for 32-bit Windows.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Fri, 1 May 2015 17:45:19 +0000 (18:45 +0100)]
Add doc for building pyOpenSSL.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Ramakrishnan Muthukrishnan [Thu, 16 Apr 2015 16:28:12 +0000 (21:58 +0530)]
OS X icons and dialog box help text
Ramakrishnan Muthukrishnan [Thu, 16 Apr 2015 15:36:26 +0000 (21:06 +0530)]
fix OS X logo generation
Ramakrishnan Muthukrishnan [Thu, 26 Mar 2015 15:10:33 +0000 (20:40 +0530)]
add osx bundle meta data and applescript script to show an alert.
Daira Hopwood [Thu, 30 Apr 2015 14:24:12 +0000 (15:24 +0100)]
Build Tahoe-LAFS icon for OS X and Windows. refs ticket:2323
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Fri, 30 Jan 2015 22:05:54 +0000 (22:05 +0000)]
zetuptoolz: don't add ';' to an empty path when appending a new item.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Brian Warner [Tue, 28 Apr 2015 18:03:12 +0000 (11:03 -0700)]
control.py: minor improvements
refs ticket:1737
Daira Hopwood [Tue, 28 Apr 2015 17:53:44 +0000 (18:53 +0100)]
Bump zetuptoolz version (move directory).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 28 Apr 2015 17:52:59 +0000 (18:52 +0100)]
Bump zetuptoolz version (file changes).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 28 Apr 2015 17:42:57 +0000 (18:42 +0100)]
zetuptoolz: tolerate a single string for __requires__, and improve error reporting. fixes ticket:2242
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 28 Apr 2015 16:21:31 +0000 (17:21 +0100)]
Change foolscap dependency to >= 0.8.0. refs #2400
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Brian Warner [Sun, 26 Apr 2015 22:07:55 +0000 (15:07 -0700)]
CREDITS: add my GPG key
Daira Hopwood [Tue, 21 Apr 2015 20:28:21 +0000 (21:28 +0100)]
Fix a test that was dependent on Windows path separators.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 21 Apr 2015 20:15:54 +0000 (21:15 +0100)]
Reduce differences between Windows and non-Windows dependencies.
This also fixes some warnings on Windows when using Twisted 12.1.0.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Brian Warner [Tue, 21 Apr 2015 20:04:47 +0000 (13:04 -0700)]
fix check-memory test, with new new (safe) control-port methods
Daira Hopwood [Tue, 21 Apr 2015 20:03:45 +0000 (21:03 +0100)]
Ensure the 'base' argument to abspath_expanduser_unicode takes effect on Windows. fixes #2398
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Brian Warner [Tue, 21 Apr 2015 18:26:16 +0000 (11:26 -0700)]
finish removing control-port upload/download functions
Brian Warner [Tue, 21 Apr 2015 17:48:06 +0000 (10:48 -0700)]
remove control-port upload/download file interfaces
FURLs are unguessable, but an attacker who somehow learned this FURL
could overwrite files and read sensitive data.
This will break the memory tests. I will add a new interface to support
the memory tests soon.
refs ticket:1737
Daira Hopwood [Fri, 17 Apr 2015 16:59:58 +0000 (17:59 +0100)]
backupdb.py: cosmetics
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Fri, 17 Apr 2015 16:59:34 +0000 (17:59 +0100)]
Make backupdb use dbutil.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Fri, 17 Apr 2015 16:57:49 +0000 (17:57 +0100)]
Add util/dbutil.py: open/create/update sqlite databases given some schema.
Author: Brian Warner <warner@lothar.com>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Fri, 23 Nov 2012 00:23:54 +0000 (00:23 +0000)]
Some useful Deferred utilities, originally from the cloud backend branch.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Mon, 13 Apr 2015 23:08:47 +0000 (00:08 +0100)]
Merge pull request #152 from vu3rdd/182-osx-packaging-7
strip the single quotes around $VERSION
Ramakrishnan Muthukrishnan [Sat, 11 Apr 2015 09:05:18 +0000 (14:35 +0530)]
strip the single quotes around $VERSION
Without stripping the single quotes, the generated pagkage filename
also has the undesired single quotes around the version string.
(eg: tahoe-lafs-'1.10.0.post309'-osx.pkg).
Daira Hopwood [Fri, 10 Apr 2015 22:42:57 +0000 (23:42 +0100)]
README.rst: change description to the new wording on tahoe-lafs.org (with "file store" instead of "filesystem").
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Thu, 2 Apr 2015 15:16:46 +0000 (16:16 +0100)]
Add discussion and rejection of Change Journals.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Thu, 2 Apr 2015 15:16:17 +0000 (16:16 +0100)]
Add link to otf-magic-folder-objective ticket query.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Thu, 2 Apr 2015 15:15:39 +0000 (16:15 +0100)]
Copyediting.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Thu, 2 Apr 2015 14:26:25 +0000 (15:26 +0100)]
Collaborative design from Daira and David.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Brian Warner [Tue, 31 Mar 2015 18:07:48 +0000 (11:07 -0700)]
Merge branch 'ftp-2394'
closes ticket:2394
Brian Warner [Tue, 31 Mar 2015 18:07:21 +0000 (11:07 -0700)]
typo
Brian Warner [Tue, 31 Mar 2015 16:41:55 +0000 (09:41 -0700)]
bump Twisted dep to 11.1.0, thus simplify IntishPermissions
Brian Warner [Tue, 31 Mar 2015 16:30:17 +0000 (09:30 -0700)]
test_ftp: fix comparison against integer
Brian Warner [Thu, 26 Mar 2015 01:23:33 +0000 (18:23 -0700)]
Fix ftp 'ls' to work with current Twisted-15.0.0
refs ticket:2394
It's kind of a hack, but Twisted changed the API and I couldn't find a
cleaner way to detect which form of "permissions" value the Twisted FTP
server wants.
I've manually tested it against 14.0.2 and 15.0.0.
Daira Hopwood [Tue, 31 Mar 2015 16:47:06 +0000 (17:47 +0100)]
Merge pull request #149 from warner/mutable-2034
use more servers for test_mutable.Update, to test #2034 properly
Brian Warner [Thu, 26 Mar 2015 01:49:37 +0000 (18:49 -0700)]
use more servers for test_mutable.Update, to test #2034 properly
Daira Hopwood [Tue, 24 Mar 2015 17:10:00 +0000 (17:10 +0000)]
Add a test, add missing imports. refs #2388
This tests ftpd, but not sftpd. Doing this sort of test on sftpd
requires the creation of a valid pubkey/privkey file pair, which is more
work than I want to do right now.
init_ftp/init_sftp were changed to interpret the configured
accounts.file as relative to the node's basedir, with
abspath_expanduser_unicode(accountfile, base=self.basedir).
This would happen naturally in a real node, since it os.chdir()s
to the basedir before doing anything. But tests don't do that.
Author: Brian Warner <warner@lothar.com>
Author: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 3 Mar 2015 20:06:35 +0000 (20:06 +0000)]
Ensure that path parameters to SFTPServer and FTPServer constructors are unicode. refs #2388
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 3 Mar 2015 20:04:57 +0000 (20:04 +0000)]
Add from_utf8_or_none and tests.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 24 Mar 2015 16:44:54 +0000 (16:44 +0000)]
Fix a missing import in test-osx-pkg.py. refs #2393
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 24 Mar 2015 16:42:27 +0000 (16:42 +0000)]
More careful quoting in build-osx-pkg.sh. refs #2393
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 24 Mar 2015 16:41:43 +0000 (16:41 +0000)]
Move computation of Tahoe version from Makefile to build-osx-pkg.sh. refs #2393
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 24 Mar 2015 16:11:30 +0000 (16:11 +0000)]
Merge pull request #146 from warner/versioned-osx-pkg
put a version string in the name of the OS-X .pkg file
Brian Warner [Sat, 21 Mar 2015 21:20:00 +0000 (14:20 -0700)]
create/test/upload tahoe-lafs-VERSION-osx.pkg, not tahoe-lafs-osx.pkg
Closes ticket:2393
Brian Warner [Sat, 21 Mar 2015 21:09:33 +0000 (14:09 -0700)]
move build-osx-pkg out to a separate shell script
Also remove the duplicate test-osx-pkg (i.e. don't run the test as part
of the build, and have the caller do it themselves later).
Brian Warner [Fri, 20 Mar 2015 17:52:48 +0000 (10:52 -0700)]
Makefile: add upload-osx-pkg rule
Brian Warner [Fri, 20 Mar 2015 01:59:16 +0000 (18:59 -0700)]
check_memory.py: announce 32-bit vs 64-bit
Brian Warner [Tue, 17 Mar 2015 18:53:30 +0000 (11:53 -0700)]
Merge branch '2329-2': fix "tahoe cp -r" exception
Brian Warner [Tue, 17 Mar 2015 18:16:06 +0000 (11:16 -0700)]
test_cli_cp.py: hush pyflakes
Brian Warner [Tue, 17 Mar 2015 18:13:57 +0000 (11:13 -0700)]
tahoe_cp: be consistent with "source.basename() is None" testing
Brian Warner [Tue, 17 Mar 2015 18:13:33 +0000 (11:13 -0700)]
tahoe_cp: minor cleanups, no behavior changes
Brian Warner [Tue, 17 Mar 2015 18:11:11 +0000 (11:11 -0700)]
tahoe_cp: make populate(recurse=) more explicit
Brian Warner [Tue, 17 Mar 2015 17:41:01 +0000 (10:41 -0700)]
test_cli_cp: test cleanups
* remove redundant test cases
* add more internal asserts
* clean up set usage
Brian Warner [Tue, 17 Mar 2015 16:59:34 +0000 (09:59 -0700)]
test_cli_cp: improve test cases
Brian Warner [Tue, 10 Mar 2015 16:17:17 +0000 (09:17 -0700)]
improve error message for slash-terminated non-directories
Brian Warner [Wed, 4 Mar 2015 02:20:03 +0000 (18:20 -0800)]
test_cli_cp.py: turn off debug mode, tests now assert for real
Brian Warner [Wed, 4 Mar 2015 02:19:58 +0000 (18:19 -0800)]
tahoe cp: overhaul target assignment, update tests
This substantially changes the internals of "tahoe cp", to behave in
accordance with the scheme developed in ticket:2329. test_cli_cp.py got
a large new test to exercise all the various combinations. This also
changes the set of error messages that "tahoe cp" can produce.
This modifies try_copy(), inserts a new implementation of
copy_things_to_directory() (and supporting methods), and fixes a few
bugs elsewhere.
fixes ticket:2329
Brian Warner [Wed, 4 Mar 2015 02:18:17 +0000 (18:18 -0800)]
tahoe_cp: delete copy_to_directory() code
This code will be replaced in the next commit with an entirely different
approach, and modifying it in a single commit would yield a completely
unreadable diff.
Brian Warner [Wed, 4 Mar 2015 01:51:28 +0000 (17:51 -0800)]
tahoe_cp: simplify some checks, rename some functions
no behavioral changes
Daira Hopwood [Fri, 27 Feb 2015 23:59:18 +0000 (23:59 +0000)]
.travis.yml: emove 'sudo: false' as requested by https://github.com/travis-ci/travis-ci/issues/2389#issuecomment-
76202191
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Brian Warner [Thu, 26 Feb 2015 06:04:25 +0000 (22:04 -0800)]
NEWS.rst: add partial list of changes
Zooko [Tue, 24 Feb 2015 18:11:30 +0000 (18:11 +0000)]
zetuptoolz: print out more context in case of parse_requirements error
Brian Warner [Tue, 24 Feb 2015 10:07:57 +0000 (02:07 -0800)]
tahoe_cp.py: use s.basename() instead of tracking it separately
Brian Warner [Tue, 24 Feb 2015 09:55:53 +0000 (01:55 -0800)]
tahoe_cp.py: store basename in the Source instance
Brian Warner [Mon, 23 Feb 2015 06:31:14 +0000 (22:31 -0800)]
test_cli.py: split the largest test classes out into separate files
That file was getting unruly. No behavioral changes, apart from tests
now having different names.
Daira Hopwood [Thu, 19 Feb 2015 17:41:09 +0000 (17:41 +0000)]
Discourage future readers of iputil.py from using Win32 APIs in preference to route.exe.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 17 Feb 2015 19:11:57 +0000 (19:11 +0000)]
It is Twisted 12.2.0 that starts depending on pywin32 for endpoints, not Twisted 12.3.0.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>