setup: don't catch all Exception from check_requirement(), but only PackagingError...
authorZooko O'Whielacronx <zooko@zooko.com>
Fri, 28 Jan 2011 15:20:06 +0000 (08:20 -0700)
committerZooko O'Whielacronx <zooko@zooko.com>
Fri, 28 Jan 2011 15:20:06 +0000 (08:20 -0700)
I noticed this because I had accidentally inserted a bug which caused AssertionError to be raised from check_requirement().

src/allmydata/__init__.py

index 6bb20d81a169a16824d29f0afcdbeace4e35c512..c404276ceb80fa4309d9e3097c51cf749a6bdbcf 100644 (file)
@@ -373,7 +373,7 @@ def check_all_requirements():
     for requirement in install_requires:
         try:
             check_requirement(requirement, vers_and_locs)
-        except Exception, e:
+        except (ImportError, PackagingError), e:
             errors.append("%s: %s" % (e.__class__.__name__, e))
 
     if errors: