tahoe-lafs/tahoe-lafs.git
11 years agoattempt to clarify move-vs-relink 36/head
Zooko O'Whielacronx [Tue, 9 Apr 2013 13:08:17 +0000 (07:08 -0600)]
attempt to clarify move-vs-relink

11 years agoServerMap.copy(): deepcopy .update_data too. Closes #1785.
Brian Warner [Thu, 4 Apr 2013 20:50:00 +0000 (13:50 -0700)]
ServerMap.copy(): deepcopy .update_data too. Closes #1785.

This was apparently unused, but good to copy for completeness. Tests
pass with and without the change.

11 years agowebapi.rst: small edits to the t=relink section
Brian Warner [Tue, 9 Apr 2013 11:06:52 +0000 (12:06 +0100)]
webapi.rst: small edits to the t=relink section

11 years agodocs/frontends/webapi.rst: cosmetics.
Daira Hopwood [Fri, 5 Apr 2013 05:11:27 +0000 (06:11 +0100)]
docs/frontends/webapi.rst: cosmetics.

Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org>
11 years agoChange web-API to support t=relink instead of t=move (+ docs and tests). fixes #1732
Daira Hopwood [Fri, 5 Apr 2013 05:36:14 +0000 (06:36 +0100)]
Change web-API to support t=relink instead of t=move (+ docs and tests). fixes #1732

Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org>
11 years agoNEWS.rst: remove redundant descriptions of security fixes.
Daira Hopwood [Fri, 5 Apr 2013 04:47:46 +0000 (05:47 +0100)]
NEWS.rst: remove redundant descriptions of security fixes.

Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org>
11 years agoedit for clarity
Zooko O'Whielacronx [Thu, 4 Apr 2013 23:39:08 +0000 (17:39 -0600)]
edit for clarity

11 years agorelnotes: soften compatibility claims until we have test infrastructure for them
Brian Warner [Thu, 4 Apr 2013 20:47:14 +0000 (13:47 -0700)]
relnotes: soften compatibility claims until we have test infrastructure for them

Closes #1773

11 years agodocs/man/tahoe.1: fix typo and copyright date.
Daira Hopwood [Wed, 3 Apr 2013 20:57:32 +0000 (21:57 +0100)]
docs/man/tahoe.1: fix typo and copyright date.

Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org>
11 years agoNEWS.rst: security improvements and other minor updates.
Daira Hopwood [Wed, 3 Apr 2013 04:19:04 +0000 (05:19 +0100)]
NEWS.rst: security improvements and other minor updates.

Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org>
11 years agoFix URL links to source docs at github 34/head
pataquets [Tue, 2 Apr 2013 17:46:52 +0000 (20:46 +0300)]
Fix URL links to source docs at github

11 years agoNEWS: merge in the rest
Brian Warner [Mon, 1 Apr 2013 06:12:41 +0000 (23:12 -0700)]
NEWS: merge in the rest

11 years agoNEWS: merge in most items
Brian Warner [Mon, 1 Apr 2013 06:09:54 +0000 (23:09 -0700)]
NEWS: merge in most items

11 years agoInclude allmydata/web/static/css/*.css files in install.
David-Sarah Hopwood [Thu, 28 Mar 2013 05:21:55 +0000 (05:21 +0000)]
Include allmydata/web/static/css/*.css files in install.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agoNEWS: add unsorted recent entries. I think that's all of them. allmydata-tahoe-1.10a2
Brian Warner [Wed, 27 Mar 2013 23:43:36 +0000 (16:43 -0700)]
NEWS: add unsorted recent entries. I think that's all of them.

This list includes the changes made between 1.9.0 and the 1.9.2 darcs
release. There are also lots of non-user-visible changes, but NEWS
doesn't need to include them.

11 years agoCREDITS: change my name.
David-Sarah Hopwood [Tue, 26 Mar 2013 19:23:27 +0000 (19:23 +0000)]
CREDITS: change my name.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
11 years agoresurrect provisioning.py
Brian Warner [Tue, 26 Mar 2013 00:57:01 +0000 (17:57 -0700)]
resurrect provisioning.py

It looks like commit 916d26e7103208fa207259d62ce453a5a8b9acd0, in
addition to making a one-line fix for #1681, also deleted
misc/operations_helpers/provisioning/provisioning.py entirely. This
brings it back.

11 years agoCorrect off-by-one in maximum-immutable-share-size for old servers. fixes #1781
David-Sarah Hopwood [Sat, 23 Mar 2013 03:10:50 +0000 (03:10 +0000)]
Correct off-by-one in maximum-immutable-share-size for old servers. fixes #1781

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agoCensor the introducer and helper furls' swissnums from the web welcome page. refs...
David-Sarah Hopwood [Thu, 21 Mar 2013 00:25:49 +0000 (00:25 +0000)]
Censor the introducer and helper furls' swissnums from the web welcome page. refs #1802

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agoclient.py: throw error when reserved_space= is unparseable. Closes #1812.
Brian Warner [Wed, 20 Mar 2013 22:25:10 +0000 (15:25 -0700)]
client.py: throw error when reserved_space= is unparseable. Closes #1812.

This should now fail quickly (during "tahoe start"). Previously this
would silently treat an unparseable size as "0", and the only way to
discover that it had had a problem would be to look at the foolscap log,
or examine the storage-service web page for the unexpected "Reserved
Size" number.

11 years agoMake introducer.furl unguessable. Closes #1802.
Brian Warner [Wed, 20 Mar 2013 22:10:47 +0000 (15:10 -0700)]
Make introducer.furl unguessable. Closes #1802.

Previously, Introducers always used a swissnum of "introducer", so
anyone who could learn the (public) tubid of the introducer would be
able to connect to and use it. This changes new Introducers to use the
same randomly-generated swissnum as clients and storage servers do, so
that you absolutely must learn the introducer.furl from someone who
knows it already before you can connect.

This change also moves the location of the file that stores
introducer.furl from BASEDIR/introducer.furl to
BASEDIR/private/introducer.furl, since that's where we keep the private
things. The first time an introducer is started with the new code, it
will move any existing BASEDIR/introducer.furl into the new place.

Note that this will not change the FURL of existing introducers: it will
only affect newly created ones. When you change an introducer's FURL,
you must also update all of the nodes (clients and storage servers)
which connect to it, so upgrading it to an unguessable one isn't
something we should do automatically.

11 years agoNEWS.rst: precautions when upgrading. refs #1932
David-Sarah Hopwood [Wed, 20 Mar 2013 22:18:57 +0000 (22:18 +0000)]
NEWS.rst: precautions when upgrading. refs #1932

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agotest_cli.py: fix mutable PUT stderr expectations
Brian Warner [Wed, 20 Mar 2013 19:27:38 +0000 (12:27 -0700)]
test_cli.py: fix mutable PUT stderr expectations

11 years agoImprove 'tahoe put --help' to clarify behaviour for mutable files, and
David-Sarah Hopwood [Wed, 20 Mar 2013 01:27:17 +0000 (01:27 +0000)]
Improve 'tahoe put --help' to clarify behaviour for mutable files, and
make sure the documented behaviour is tested. fixes #1372

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agoAvoid double-counting source files in 'tahoe cp --verbose'. fixes #1783
David-Sarah Hopwood [Wed, 20 Mar 2013 00:57:50 +0000 (00:57 +0000)]
Avoid double-counting source files in 'tahoe cp --verbose'. fixes #1783

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agoImprovements to NEWS.rst for 1.10.
David-Sarah Hopwood [Wed, 20 Mar 2013 00:36:00 +0000 (00:36 +0000)]
Improvements to NEWS.rst for 1.10.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agotweak NEWS a bit
Brian Warner [Tue, 19 Mar 2013 23:23:34 +0000 (16:23 -0700)]
tweak NEWS a bit

11 years agoAdd draft NEWS entry for 1.10.0c1.
David-Sarah Hopwood [Mon, 18 Mar 2013 19:20:27 +0000 (19:20 +0000)]
Add draft NEWS entry for 1.10.0c1.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agoRemove darcs from setup.py, remove darcsver egg. Closes #1908.
Brian Warner [Tue, 19 Mar 2013 22:26:21 +0000 (15:26 -0700)]
Remove darcs from setup.py, remove darcsver egg. Closes #1908.

Also remove lingering traces of darcs from MANIFEST.in,
.darcs-boringfile, setup.cfg, and unit tests.

11 years agoMakefile: re-enable tarball uploads for "master" branch allmydata-tahoe-1.10a1
Brian Warner [Tue, 19 Mar 2013 19:18:27 +0000 (12:18 -0700)]
Makefile: re-enable tarball uploads for "master" branch

11 years agoNew Welcome page: ensure 'not connected' status for Introducer and Helper is shown...
David-Sarah Hopwood [Tue, 19 Mar 2013 03:47:24 +0000 (03:47 +0000)]
New Welcome page: ensure 'not connected' status for Introducer and Helper is shown via text as well as bullet colour. refs #1713

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agoImprove SFTP error handling and remove use of IFinishableConsumer. fixes #1525
David-Sarah Hopwood [Tue, 19 Mar 2013 05:37:02 +0000 (05:37 +0000)]
Improve SFTP error handling and remove use of IFinishableConsumer. fixes #1525

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agosftpd.py: switch from using bare asserts to assertutil.
David-Sarah Hopwood [Sat, 5 Jan 2013 01:02:13 +0000 (01:02 +0000)]
sftpd.py: switch from using bare asserts to assertutil.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agointroducer.client: use integer seqnums, not time-based. Closes #1767.
Brian Warner [Tue, 19 Mar 2013 00:40:56 +0000 (17:40 -0700)]
introducer.client: use integer seqnums, not time-based. Closes #1767.

This stores the sequence number in BASEDIR/announcement-seqnum, and
increments it each time any service is published (every service
announcement is regenerated with the new sequence number). As everyone
knows, time is an illusion, and occasionally goes backwards, so a
counter is generally safer (and reveals less information about the
node).

Later, we'll improve the introducer client to tolerate rollbacks (where,
perhaps due to a VM being restarted from an earlier checkpoint, the
stored sequence number reverts to an earlier version).

11 years agofileutil.write: accept mode=, and use it in Node.write_config
Brian Warner [Tue, 19 Mar 2013 00:30:57 +0000 (17:30 -0700)]
fileutil.write: accept mode=, and use it in Node.write_config

I want mode="w" (i.e. text, with newline conversion) for code that
writes newline-terminated strings (which should also be human readable)
to files. I like to use things like "cat .tahoe/permutation-seed"
without seeing the seed jammed together with the next command prompt.

11 years agosetup.py: add helpful comment on line that is a SyntaxError in Python < 2.6.
David-Sarah Hopwood [Sun, 17 Mar 2013 18:27:58 +0000 (18:27 +0000)]
setup.py: add helpful comment on line that is a SyntaxError in Python < 2.6.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agotest_web.py: relax tests for upload and mkdir forms to tolerate nondeterministic...
David-Sarah Hopwood [Sun, 17 Mar 2013 18:26:34 +0000 (18:26 +0000)]
test_web.py: relax tests for upload and mkdir forms to tolerate nondeterministic order of attributes.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agoMove embedded setuptools egg to reflect new version (0.6c16dev4).
David-Sarah Hopwood [Sun, 17 Mar 2013 16:43:46 +0000 (16:43 +0000)]
Move embedded setuptools egg to reflect new version (0.6c16dev4).

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agoTolerate import errors when loading extra commands for "setup.py --help-commands"
David-Sarah Hopwood [Sun, 17 Mar 2013 16:42:59 +0000 (16:42 +0000)]
Tolerate import errors when loading extra commands for "setup.py --help-commands"
and bump zetuptoolz version to 0.6c16dev4. fixes #1405

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agoUpdate helper.rst to explain new-style config. fixes #1915
David-Sarah Hopwood [Fri, 15 Mar 2013 06:39:12 +0000 (06:39 +0000)]
Update helper.rst to explain new-style config. fixes #1915

Author: Zooko Wilcox-O'Hearn <zooko>
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agoRedesigned Welcome page using Twitter Bootstrap CSS.
David-Sarah Hopwood [Fri, 15 Mar 2013 02:28:38 +0000 (02:28 +0000)]
Redesigned Welcome page using Twitter Bootstrap CSS.

Author: Tony Arcieri <tarcieri>
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agobump 'mock' dependency to >=0.8.0, to get the .call object
Brian Warner [Sat, 16 Mar 2013 04:46:32 +0000 (21:46 -0700)]
bump 'mock' dependency to >=0.8.0, to get the .call object

The 0.6.0 version that was previously allowed did not provide .call, so
test_cli.py failed during import.

11 years agoRequire at least Python 2.6. fixes #1658
David-Sarah Hopwood [Fri, 15 Mar 2013 05:13:30 +0000 (05:13 +0000)]
Require at least Python 2.6. fixes #1658

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agoMake doubly sure that we fail quickly on future Python 3.x versions. refs #1775
David-Sarah Hopwood [Fri, 15 Mar 2013 04:41:53 +0000 (04:41 +0000)]
Make doubly sure that we fail quickly on future Python 3.x versions. refs #1775

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agoEnsure that bin/tahoe and setup.py fail quickly on Python 3.3+. fixes #1775
David-Sarah Hopwood [Fri, 15 Mar 2013 04:28:35 +0000 (04:28 +0000)]
Ensure that bin/tahoe and setup.py fail quickly on Python 3.3+. fixes #1775

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agoAdd test for anti-Ubuntu-crash-reporter exception-catching code. fixes #1746
David-Sarah Hopwood [Thu, 3 Jan 2013 03:19:52 +0000 (03:19 +0000)]
Add test for anti-Ubuntu-crash-reporter exception-catching code. fixes #1746

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agotahoe_ls.py: JSON responses don't need quotemarks or quoted newlines.
David-Sarah Hopwood [Fri, 4 Jan 2013 05:32:24 +0000 (05:32 +0000)]
tahoe_ls.py: JSON responses don't need quotemarks or quoted newlines.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agoOnly quote newline characters where necessary. fixes #1484
David-Sarah Hopwood [Fri, 4 Jan 2013 05:31:07 +0000 (05:31 +0000)]
Only quote newline characters where necessary. fixes #1484

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agotest_web.py: fix test_GET_DIRECTORY_html_filenode_encoding for Twisted==12.3.0. fixes... 31/head
Mike Kazantsev [Wed, 27 Feb 2013 17:14:58 +0000 (23:14 +0600)]
test_web.py: fix test_GET_DIRECTORY_html_filenode_encoding for Twisted==12.3.0. fixes #1922

twisted.web.html.escape was used to produce html-encoded string (to then look
it up in "value" attribute), but behavior of that function has changed between
Twisted 12.2.0 (simple custom implementation) and 12.3.0 (imported from stdlib
cgi module).

11 years agoAdd comment explaining fix to #1679. refs #1679
David-Sarah Hopwood [Fri, 8 Feb 2013 19:27:57 +0000 (19:27 +0000)]
Add comment explaining fix to #1679. refs #1679

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agodo not cache and re-use imm filenodes in nodemaker 30/head
Zooko O'Whielacronx [Thu, 7 Feb 2013 16:35:43 +0000 (16:35 +0000)]
do not cache and re-use imm filenodes in nodemaker

fixes #1679

11 years agounit test for #1679
Zooko O'Whielacronx [Thu, 7 Feb 2013 16:35:23 +0000 (16:35 +0000)]
unit test for #1679

11 years agotahoe_check.py: tolerate missing fields in check results for LIT files/dirs. fixes...
David-Sarah Hopwood [Thu, 3 Jan 2013 22:16:20 +0000 (22:16 +0000)]
tahoe_check.py: tolerate missing fields in check results for LIT files/dirs. fixes #1758
Also test this case and improve some existing tests of 'tahoe check'.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agoMake WUI headings and titles more consistent and accurate:
David-Sarah Hopwood [Sat, 29 Dec 2012 23:54:54 +0000 (23:54 +0000)]
Make WUI headings and titles more consistent and accurate:
'Recent and Active Operations' and 'Operational Statistics'. fixes #1457

Signed-off-by: David-Sarah Hopwood <davidsarah@jacaranda.org>
11 years agotest_web.py: minor cleanup to test_helper_status.
David-Sarah Hopwood [Sat, 29 Dec 2012 23:44:11 +0000 (23:44 +0000)]
test_web.py: minor cleanup to test_helper_status.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
11 years agoIf a helper is not configured, make the banner on the welcome page say that, and...
David-Sarah Hopwood [Sat, 29 Dec 2012 04:17:00 +0000 (04:17 +0000)]
If a helper is not configured, make the banner on the welcome page say that, and have a white background.
fixes #1735

Author: kick
Signed-off-by: David-Sarah Hopwood <davidsarah@jacaranda.org>
11 years agodocs/configuration.rst: clarification on scale suffixes for reserved_space. 26/head
David-Sarah Hopwood [Thu, 27 Dec 2012 23:38:58 +0000 (23:38 +0000)]
docs/configuration.rst: clarification on scale suffixes for reserved_space.
refs #1812

Signed-off-by: David-Sarah Hopwood <davidsarah@mint>
11 years agoMake abbreviate_space able to output in exabytes. refs #1812
David-Sarah Hopwood [Thu, 27 Dec 2012 20:08:27 +0000 (20:08 +0000)]
Make abbreviate_space able to output in exabytes. refs #1812

Signed-off-by: David-Sarah Hopwood <davidsarah@mint>
11 years agoAllow T (terabytes), P (petabytes), and E (exabytes), case-insensitive, in parse_abbr...
David-Sarah Hopwood [Thu, 27 Dec 2012 20:08:00 +0000 (20:08 +0000)]
Allow T (terabytes), P (petabytes), and E (exabytes), case-insensitive, in parse_abbreviated_size.
This also simplifies how case-insensitivity is handled, and fixes a corner case
where the wrong exception was raised when the size ends in "BB".
fixes #1812

Signed-off-by: David-Sarah Hopwood <davidsarah@mint>
11 years agoMake the system test nodes have non-ASCII nicknames. 25/head
David-Sarah Hopwood [Thu, 27 Dec 2012 19:00:22 +0000 (19:00 +0000)]
Make the system test nodes have non-ASCII nicknames.
This ensures that non-ASCII nicknames are exercised with the real server code.
refs #1298

Signed-off-by: David-Sarah Hopwood <davidsarah@mint>
11 years agoAllow welcome and storage status pages to display a non-ASCII node nickname. fixes...
David-Sarah Hopwood [Thu, 27 Dec 2012 05:08:53 +0000 (05:08 +0000)]
Allow welcome and storage status pages to display a non-ASCII node nickname. fixes #1298

Signed-off-by: David-Sarah Hopwood <davidsarah@jacaranda.org>
11 years agoRemove ResponseCache in favor of MDMFSlotReadProxy's cache. closes #1240.
David-Sarah Hopwood [Thu, 27 Dec 2012 00:00:17 +0000 (00:00 +0000)]
Remove ResponseCache in favor of MDMFSlotReadProxy's cache. closes #1240.

This contains several merged patches. Individual messages follow, latest first:

* Fix a warning from check-miscaptures.
* In retrieve.py, explicitly test whether a key is in self.servermap.proxies
  rather than catching KeyError.
* Added a new comment to the MDMF version of the test I removed, explaining
  the removal of the SDMF version.
* Removed test_corrupt_all_block_hash_tree_late, since the entire block_hash_tree
  is cached in the servermap for an SDMF file.
* Fixed several tests that require files larger than the servermap cache.
* Remove unused test_response_cache_memory_leak().
* Exercise the cache.
* Test infrastructure for counting cache misses on MDMF files.
* Removed the ResponseCache. Instead, the MDMFSlotReadProxy initialized
  by ServerMap is kept around so Retrieve can access it. The ReadProxy
  has a cache of the first 1000 bytes initially read from each share by
  the ServerMap. We're able to satisfy a number of requests out of this
  cache, so roundtrips are reduced from 84 to 60 in test_deepcheck_mdmf.
  There is still some mystery about under what conditions the cache has
  fewer than 1000 bytes. Also this breaks some existing unit tests that
  depend on the inner behavior of ResponseCache.
* The servermap.proxies (a cache of SlotReadProxies) is now keyed
  by (verinfo,serverid,shnum) rather than just (serverid,shnum)
* Minor cosmetic changes
* Added a test failure if the number of cache misses is too high.

Author: Andrew Miller <amiller@dappervision.com>
Signed-off-by: David-Sarah Hopwood <davidsarah@jacaranda.org>
12 years agodocs/logging.rst: fix rst2html warnings.
David-Sarah Hopwood [Sat, 22 Dec 2012 23:47:47 +0000 (23:47 +0000)]
docs/logging.rst: fix rst2html warnings.

Signed-off-by: David-Sarah Hopwood <davidsarah@mint>
12 years agodocs/logging.rst: remove note about a bug that was fixed in foolscap 0.6.0.
David-Sarah Hopwood [Sat, 22 Dec 2012 23:39:11 +0000 (23:39 +0000)]
docs/logging.rst: remove note about a bug that was fixed in foolscap 0.6.0.

Signed-off-by: David-Sarah Hopwood <davidsarah@mint>
12 years agotest/common_util.py: fix a bug in NonASCIIPathMixin that would cause spurious log...
David-Sarah Hopwood [Sun, 2 Dec 2012 01:54:47 +0000 (01:54 +0000)]
test/common_util.py: fix a bug in NonASCIIPathMixin that would cause spurious log entries on Windows.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
12 years agotests: add more diagnostics when code-under-test fails 23/head
Zooko O'Whielacronx [Thu, 29 Nov 2012 21:11:47 +0000 (14:11 -0700)]
tests: add more diagnostics when code-under-test fails

This prints out which things are different when two sets are expected to be the
same. This was useful to me when debugging the code under test. Hm, this
pattern might be more generally useful...

12 years agoremove unnecessary request from upload-helper
Zooko O'Whielacronx [Thu, 29 Nov 2012 20:44:32 +0000 (13:44 -0700)]
remove unnecessary request from upload-helper

The unnecessary request was from the upload helper to the sender, and it was
there in order to trigger the sender to deliver cleartext hashes. But we've
long since removed cleartext hashes.

Unit tests pass both before and after this change, and code-coverage shows that
the block I changed is exercised in unit tests.

12 years agopkg_resources: better error message on bad spec
Zooko O'Whielacronx [Thu, 22 Nov 2012 16:27:28 +0000 (09:27 -0700)]
pkg_resources: better error message on bad spec

Include the text of the offending distribution spec when it is ill-formed.

I got an error message from pkg_resources.py saying that a distribution spec
was ill-formed, because it ended with an '=' and nothing came after the '='.
However, the error message and stack trace didn't tell which distribution spec
it was.

With this patch, it includes the distribution spec itself in the error message.

There is no unit test of this patch, but I did test it manually by inserting a
"raise ValueError('WHATEVER')" into the code and re-running it and observing
that the new output correctly included the distribution

12 years agoNEWS.rst: add a missing dependency update for 1.9.2.
David-Sarah Hopwood [Tue, 20 Nov 2012 05:59:00 +0000 (05:59 +0000)]
NEWS.rst: add a missing dependency update for 1.9.2.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
12 years agoMakefile: increase filesystem size for 'make tmpfstest'.
David-Sarah Hopwood [Tue, 13 Nov 2012 16:24:36 +0000 (16:24 +0000)]
Makefile: increase filesystem size for 'make tmpfstest'.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
12 years agoweb/unlinked.py: don't use % operator to expand %(uri)s. fixes #1860.
David-Sarah Hopwood [Thu, 15 Nov 2012 04:16:19 +0000 (04:16 +0000)]
web/unlinked.py: don't use % operator to expand %(uri)s. fixes #1860.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
12 years agodocs/frontends/CLI.rst: fix markup of * and ?.
David-Sarah Hopwood [Sun, 11 Nov 2012 16:04:23 +0000 (16:04 +0000)]
docs/frontends/CLI.rst: fix markup of * and ?.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
12 years agodocs/frontends/CLI.rst: document ./* trick, and that aliases should not be a single...
David-Sarah Hopwood [Sun, 11 Nov 2012 15:50:46 +0000 (15:50 +0000)]
docs/frontends/CLI.rst: document ./* trick, and that aliases should not be a single char on Windows.
Also fix some rst2html warnings. refs #1853, #1840

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
12 years agoUpdate docs/network-and-reliance-topology.svg for RAIC, and to be more accurate about...
David-Sarah Hopwood [Sat, 3 Nov 2012 00:15:32 +0000 (00:15 +0000)]
Update docs/network-and-reliance-topology.svg for RAIC, and to be more accurate about frontend protocols.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
12 years agoCLI: fix synopsis for 'tahoe ls'. fixes #1839
David-Sarah Hopwood [Thu, 1 Nov 2012 23:40:06 +0000 (23:40 +0000)]
CLI: fix synopsis for 'tahoe ls'. fixes #1839

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
12 years agodocs/about.rst: fix broken link for network-and-reliance-topology image.
David-Sarah Hopwood [Thu, 1 Nov 2012 23:09:07 +0000 (23:09 +0000)]
docs/about.rst: fix broken link for network-and-reliance-topology image.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
12 years agoMakefile: add 'make tmpfstest', which uses a tmpfs for _trial_temp.
David-Sarah Hopwood [Thu, 25 Oct 2012 01:16:21 +0000 (02:16 +0100)]
Makefile: add 'make tmpfstest', which uses a tmpfs for _trial_temp.

This probably only works on Linux. It uses sudo to mount and unmount the tmpfs,
which may prompt for a password. refs #20

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
12 years agotest_runner: we no longer need to skip tests on Twisted < 9.0.
David-Sarah Hopwood [Wed, 24 Oct 2012 22:47:44 +0000 (23:47 +0100)]
test_runner: we no longer need to skip tests on Twisted < 9.0.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
12 years agosrc/allmydata/web/directory.py: fix HTML double-encoding issue for filenames.
David-Sarah Hopwood [Thu, 25 Oct 2012 00:01:25 +0000 (01:01 +0100)]
src/allmydata/web/directory.py: fix HTML double-encoding issue for filenames.

Nevow automatically HTML-escapes strings passed in stan without a raw marker.
Written by MK_FG. fixes #1143

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
12 years agodocs/frontends/webapi.rst: remove (ignored) "size" keyword from mkdir POST example
Mike Kazantsev [Tue, 9 Oct 2012 17:19:55 +0000 (23:19 +0600)]
docs/frontends/webapi.rst: remove (ignored) "size" keyword from mkdir POST example

12 years agoadd alternating grey-background to make it easier to scan across the table left to...
Zooko O'Whielacronx [Mon, 8 Oct 2012 18:13:33 +0000 (12:13 -0600)]
add alternating grey-background to make it easier to scan across the table left to right

12 years agolink from the tahoe-lafs-dep-eggs/README.html to the relevant wiki pages
Zooko O'Whielacronx [Mon, 8 Oct 2012 17:43:50 +0000 (11:43 -0600)]
link from the tahoe-lafs-dep-eggs/README.html to the relevant wiki pages

12 years agofixed wrong index in tahoe cp --verbose, as explained in #1805
frederik b [Fri, 28 Sep 2012 17:22:53 +0000 (19:22 +0200)]
fixed wrong index in tahoe cp --verbose, as explained in #1805

this bug shows wrong counters for copied files in verbose mode

12 years agoIgnore *~, /miscaptures.txt and /violations.txt.
David-Sarah Hopwood [Mon, 17 Sep 2012 20:28:49 +0000 (21:28 +0100)]
Ignore *~, /miscaptures.txt and /violations.txt.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
12 years agosrc/allmydata/__init__.py: ensure that if a dependency cannot be imported, we will...
david-sarah [Fri, 14 Sep 2012 02:14:48 +0000 (02:14 +0000)]
src/allmydata/__init__.py: ensure that if a dependency cannot be imported, we will report that rather than reporting a confusing message about the version and location being None. fixes #1804

12 years agodocs/quickstart.rst: swap two paragraphs to make it more likely a user will report...
david-sarah [Fri, 14 Sep 2012 02:10:12 +0000 (02:10 +0000)]
docs/quickstart.rst: swap two paragraphs to make it more likely a user will report import and versioning errors from 'bin/tahoe --version' if there are any, before trying to run tests. Also, change 'python setup.py test' to 'python setup.py trial' to avoid a rebuild that might change the dependencies (if setuptools decides to throw a spanner in the works).

12 years agoApply David-Sarah's recommended changes. Closes #974
Brian Warner [Tue, 4 Sep 2012 22:44:51 +0000 (15:44 -0700)]
Apply David-Sarah's recommended changes. Closes #974

12 years agoWhen the CLI cannot connect to the gateway, it prints an error message rather than...
Andrew Miller [Sat, 31 Mar 2012 22:53:45 +0000 (18:53 -0400)]
When the CLI cannot connect to the gateway, it prints an error message rather than raising a python exception. Includes a unit test

Signed-off-by: Andrew Miller <amiller@dappervision.com>
12 years agoCosmetic changes to match cloud backend branch.
david-sarah [Tue, 24 Jul 2012 03:40:49 +0000 (03:40 +0000)]
Cosmetic changes to match cloud backend branch.

12 years agointerfaces.py: corrections to take into account that lease cancel secrets are no...
david-sarah [Tue, 24 Jul 2012 03:40:06 +0000 (03:40 +0000)]
interfaces.py: corrections to take into account that lease cancel secrets are no longer honoured.

12 years agointerfaces.py: corrections to interfaces to make more of them checkable.
david-sarah [Tue, 24 Jul 2012 03:39:24 +0000 (03:39 +0000)]
interfaces.py: corrections to interfaces to make more of them checkable.

12 years agointerfaces.py: which -> that.
david-sarah [Tue, 24 Jul 2012 03:37:07 +0000 (03:37 +0000)]
interfaces.py: which -> that.

12 years agoDefault arguments in interface declarations should only be used to specify a default...
david-sarah [Tue, 24 Jul 2012 03:34:46 +0000 (03:34 +0000)]
Default arguments in interface declarations should only be used to specify a default, not to specify the type, in order to be checkable.

12 years agoRemove spurious 'self' arguments that should not be included in interface declarations.
david-sarah [Tue, 24 Jul 2012 03:32:56 +0000 (03:32 +0000)]
Remove spurious 'self' arguments that should not be included in interface declarations.

12 years agointerfaces.py: whitespace
david-sarah [Tue, 24 Jul 2012 03:29:14 +0000 (03:29 +0000)]
interfaces.py: whitespace

12 years agodocs: fix link to mutable.rst. Thanks to TimothyA for noticing the broken link
Zooko O'Whielacronx [Fri, 20 Jul 2012 19:24:02 +0000 (19:24 +0000)]
docs: fix link to mutable.rst. Thanks to TimothyA for noticing the broken link

12 years agodocs/configuration.rst: clarify statement about lack of redundancy when shares.happy...
david-sarah [Thu, 12 Jul 2012 20:30:26 +0000 (20:30 +0000)]
docs/configuration.rst: clarify statement about lack of redundancy when shares.happy <= k. fixes #1793

12 years agoUpdate release date for 1.9.2.
david-sarah [Tue, 3 Jul 2012 16:30:10 +0000 (16:30 +0000)]
Update release date for 1.9.2.

12 years agoSlightly improve the error message when a stats.pickle file cannot be read.
david-sarah [Tue, 3 Jul 2012 14:45:22 +0000 (14:45 +0000)]
Slightly improve the error message when a stats.pickle file cannot be read.

12 years agoRelnotes, NEWS and quickstart updates for 1.9.2, with updated release date. refs...
david-sarah [Sun, 1 Jul 2012 23:19:21 +0000 (23:19 +0000)]
Relnotes, NEWS and quickstart updates for 1.9.2, with updated release date. refs #1776