From: Brian Warner <warner@allmydata.com>
Date: Wed, 13 Feb 2008 20:08:26 +0000 (-0700)
Subject: test_web: remove test_GET_DIRURL_large, it failed to exercise the problem in #237... 
X-Git-Tag: allmydata-tahoe-0.8.0~72
X-Git-Url: https://git.rkrishnan.org/components/com_hotproperty/flags/rgr-080307.php?a=commitdiff_plain;h=871e7756f739994f57de0dcce5b35c20cd3aff27;p=tahoe-lafs%2Ftahoe-lafs.git

test_web: remove test_GET_DIRURL_large, it failed to exercise the problem in #237 and consumes a disproportionate amount of time
---

diff --git a/src/allmydata/test/test_web.py b/src/allmydata/test/test_web.py
index 97c92ff1..d6f462b4 100644
--- a/src/allmydata/test/test_web.py
+++ b/src/allmydata/test/test_web.py
@@ -650,37 +650,6 @@ class Web(WebMixin, unittest.TestCase):
                                   self.public_url + "/foo?t=bogus")
         return d
 
-    def test_GET_DIRURL_large(self):
-        # Nevow has a problem showing more than about 192 children of a
-        # directory: it uses defer.success() and d.addCallback in a way that
-        # can make the stack grow very quickly. See ticket #237 for details.
-        # To work around this, I think we'll need to put a 'return
-        # defer.fireEventually' in our render_ method. This test is intended
-        # to trigger the bug (and eventually verify that our workaround
-        # actually works), but it isn't yet failing for me.
-
-        d = self.s.create_empty_dirnode()
-        COUNT = 200
-        def _created(dirnode):
-            entries = [ (str(i), self._foo_uri) for i in range(COUNT) ]
-            d2 = dirnode.set_uris(entries)
-            d2.addCallback(lambda res: dirnode)
-            return d2
-        d.addCallback(_created)
-
-        def _check(dirnode):
-            large_url = "/uri/" + dirnode.get_uri() + "/"
-            return self.GET(large_url)
-        d.addCallback(_check)
-
-        def _done(res):
-            m = r'<a href="/uri/URI%3ADIR2%3A[^"]+">' + ("%d" % (COUNT-1)) + r'</a>'
-            self.failUnless(re.search(m, res))
-            self.failIf("maximum recursion depth exceeded" in res)
-        d.addCallback(_done)
-        return d
-    test_GET_DIRURL_large.timeout= 240 # this hits 120-sec timeout on overloaded vm buildslaves
-
     def test_GET_DIRURL_json(self):
         d = self.GET(self.public_url + "/foo?t=json")
         d.addCallback(self.failUnlessIsFooJSON)