From: Daira Hopwood Date: Thu, 21 Feb 2013 01:58:56 +0000 (+0000) Subject: openstack_container.py: avoid logging secrets in request headers. X-Git-Url: https://git.rkrishnan.org/components/com_hotproperty/flags/status?a=commitdiff_plain;h=fe36d43bbe1a5b07177dc112986ea3eea83d89dc;p=tahoe-lafs%2Ftahoe-lafs.git openstack_container.py: avoid logging secrets in request headers. Signed-off-by: David-Sarah Hopwood --- diff --git a/src/allmydata/storage/backends/cloud/openstack/openstack_container.py b/src/allmydata/storage/backends/cloud/openstack/openstack_container.py index a86ac5fe..cd0048f3 100644 --- a/src/allmydata/storage/backends/cloud/openstack/openstack_container.py +++ b/src/allmydata/storage/backends/cloud/openstack/openstack_container.py @@ -67,8 +67,8 @@ def _http_request(what, agent, method, url, request_headers, body=None, need_res # We don't need to explicitly set Content-Length because FileBodyProducer knows the length # (and if we do it won't work, because in that case Content-Length would be duplicated). - log.msg(format="OpenStack %(what)s request %(method)s %(url)s %(headers)s", - what=what, method=method, url=url, headers=repr(request_headers), level=log.OPERATIONAL) + log.msg(format="OpenStack %(what)s request %(method)s %(url)s %(header_keys)s", + what=what, method=method, url=url, header_keys=repr(request_headers.keys()), level=log.OPERATIONAL) d = defer.maybeDeferred(agent.request, method, url, Headers(request_headers), bodyProducer)