Refactor useful functionality out of OpenStackContainer and into utility class.

More tests for the Google Storage container, and fixes to the tests.

Start of tests for the Google Storage container.

Tests for googlestorage_container.AuthenticationClient.

Author: Itamar Turner-Trauring <itamar@futurefoundries.com>

Sketch of working Google Cloud Storage authentication, with some demo code.

docs/backends/cloud.rst: clarify how to get to API Access in the Rackspace console.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

OpenStack: fix a type error introduced by the fix to #1921.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

OpenStack: support HP Cloud Object Storage.
Also make the choice of auth protocol for Rackspace configurable via
openstack.provider, and change the reauth period to 11 hours.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

leasedb/accounting crawler: only treat stable shares as disappeared or unleased.
fixes #1921

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

Cloud backend: move potentially reusable HTTP request utilities to cloud_common.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

OpenStack: if we get a 401 Unauthorized response, reauthenticate immediately.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

cloud_common.py: generalize ContainerRetryMixin to allow the container class to specify what to retry.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

openstack_container.py: remove a superfluous argument to get_auth_info_locked.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

accounting_crawler.py: disable removing leasedb entries for disappeared shares.
This works around ticket #1921 for now.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

openstack_container.py: avoid logging secrets in request headers.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

docs: add references to OpenStack/cloud backend in configuration.rst and running.rst.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

OpenStack: generalize to support multiple auth protocols, and add V2 protocol.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

OpenStack: add _http_request helper.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

openstack_container.py: factor out HTTP response code checking.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

docs/backends/cloud.rst: add documentation for OpenStack config parameters.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

openstack_container.py: improve name of _auth_lock; simplify by using DeferredLock.run.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

OpenStack: change provider names to rackspace.com and rackspace.co.uk.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

test_storage.py: add tests for OpenStackContainer.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

openstack_container.py: disable or remove debug prints.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

openstack_container.py: fix a bug in type of ContainerListing.is_truncated.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

Move classes common to mock and OpenStack cloud services, to cloud_common.py.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

test_storage.py: refactor OpenStackCloudBackend to make it easier to add new tests.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

OpenStack: mostly complete implementation of OpenStackContainer.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

OpenStack: improve logging in openstack_container.py.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

OpenStack: add openstack.container config parameter.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

Add test for OpenStack authentication client.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

openstack_container.py: add shutdown() to avoid unclean reactor errors in tests.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

openstack_container.py: add _ prefix to private attributes.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

setup.py: add allmydata.storage.backends.cloud.openstack module.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

test_client.py: add OpenStack config tests.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

test_client.py: cleanups to S3 config tests.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

OpenStack service: add AuthenticationClient.
Configure using properties relevant to OpenStack.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

Add stub OpenStack container impl. as a copy of S3 container impl.
Generalize the container instantiation to work for either.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

Fix interface violations introduced in cloud merge.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

Make backupdb use dbutil.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Makefile: have 'make tmpfstest' unmount and remove stale temp directories.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

Makefile: the timing for 'make tmpfstest' should exclude filesystem
mounting/unmounting and entering the password if needed.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

Makefile: allow tmpfs size to be more easily overridden, and use 500 MiB by default (rebased).

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

test_runner.py: add test for 'tahoe debug trial'.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

Fixes to tests. Some tests are applied to multiple backends.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fixes to test infrastructure.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Miscellaneous corrections and additions.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

Changes to crawler classes (ShareCrawler and AccountingCrawler).
Pass in a Clock to allow (in theory) deterministic testing, although this isn't used yet by tests.
Simplify the generic ShareCrawler code by not attempting to track state during processing
of a single prefix.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

Changes to fileutil.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix bugs in Accountant.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

Simplify Account.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

Changes to debug.py.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Changes to node classes (Node, Client and StorageServer).

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Changes to Bucket{Reader,Writer} and disk backend (rebased).

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Changes and additions to interface documentation.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

Add new files for cloud merge (rebased).

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Move BucketWriter and BucketReader to storage/bucket.py.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

Move code around and add new directories for cloud backend merge.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

Add dependency on our fork of txAWS (0.2.1.post5).

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

.gitignore: changes to facilitate cloud backend merge (rebased).

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Add documentation for each storage backend (rebased).

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Add test_leasedb.py.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

leasedb: use a semantic primary key (storage_index, shnum, account_id), rather than an integer, for the leases table.
Take advantage of this to simplify add_or_renew_leases.
Fix a bug in add_starter_lease (which is not used yet) when a starter lease already exists.
Clean up leftover accesses to self._dirty.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

Rename 'buckets' to 'sharesets' on storage status page.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

Remove unused files storage/lease.py and storage/expirer.py.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Main leasedb changes (rebased).

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Remove the 'original-*' and 'configured-*' lease crawler output that won't be supported by the accounting crawler.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

Cosmetics.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

test_storage.py: ss -> server for cases that will remain a server after the server/account split.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

Asyncify crawlers. Note that this breaks tests for the LeaseCrawler
(which is going away, to be replaced by the AccountingCrawler).

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

scripts/debug.py: remove display of lease information and secrets.
This version replaces the expiration field with '-' instead of '0', per Zooko's comments.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

Remove the [storage]expire.{mutable,immutable} options.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Remove support for [storage]debug_discard option.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Add new files for leasedb.

Authors: Brian Warner <warner@lothar.com> and David-Sarah Hopwood
Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

Changes to specification of add_lease and renew_lease in RIStorageServer.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

docs/garbage-collection.rst: update text for leasedb changes.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

util/fileutil.py: add get_used_space. This version does not use FilePath.

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

Change some instances of "filesystem" that were missed to "file store".

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

update docs for 1.10.2 release

add a pypy that is allowed to fail

update NEWS with recent changes

quickstart: Mention python-dev package for Python.h

Closes ticket:2328.

Merge branch '2447-cp-overwrite'

test_cli_cp: minor cleanup

cp: error on target-filename collisions, rather than overwrite

Closes ticket:2447

unit test for my desired behavior

Merge branch '2436.less-scary.3'

This reverts and improves the earlier fix for ticket:2436

test_version.py: minor cleanup.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Don't show scary diagnostic warnings from --version[-and-path] (corrected). refs ticket:2436

The previous version would incorrectly add to the output of
get_package_versions_string each time it was called.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Revert "Don't show scary diagnostic warnings from --version[-and-path]"

This reverts commit 431728f8f854e02d9ab2f731675f12ce18cda122.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

mutable/retrieve.py: remove all bare assert()s

Replace them with _assert() or precondition(). Closes ticket:2462.

improve HTTP byte-range docs

webapi.rst: document Range: header on GET requests

closes ticket#2460

IReadable.read(): document out-of-range errors

closes ticket#2461

Merge branch 'sdmf-partial-2'

This cleans up the mutable-retrieve code a bit, and should fix some
corner cases where an offset/size combinations that reads the last byte
of the file (but not the first) could cause an assert to fire, making
the download hang. Should address ticket:2459 and ticket:2462.

test_mutable: more enhancements

mutable/retrieve.py: rewrite partial-read handling

This should tolerate offset/size combinations that read the last byte of
the file, something which was broken before. It quits early in the case
of zero-byte reads, to simplify the resulting "which segments do I need"
logic. Probably addresses ticket:2459.

enhance SDMF/MDMF tests: zero-length files, size=None

Add tests for SDMF partial reads. refs #2459

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Remove some bare asserts in retrieve.py (there are still quite a few left). refs #2462

Signed-off-by: Daira Hopwood <daira@jacaranda.org>