]> git.rkrishnan.org Git - tahoe-lafs/tahoe-lafs.git/log
tahoe-lafs/tahoe-lafs.git
17 years agozfec: fix link to zfec-dev mailing list
Zooko O'Whielacronx [Fri, 20 Jul 2007 20:57:47 +0000 (13:57 -0700)]
zfec: fix link to zfec-dev mailing list

17 years agozfec: fix README.txt to explain how to use setuptools with GNU stow better
Zooko O'Whielacronx [Fri, 20 Jul 2007 20:57:01 +0000 (13:57 -0700)]
zfec: fix README.txt to explain how to use setuptools with GNU stow better
Also remove requirement of setuptools >= v0.6c3.  I *think* that using setuptools in the modern way relieves this requirement, but I haven't tested it on dapper yet.

17 years agozfec: clarify licensing requirements (transitive grace period)
Zooko O'Whielacronx [Fri, 20 Jul 2007 20:55:46 +0000 (13:55 -0700)]
zfec: clarify licensing requirements (transitive grace period)

17 years agozfec: shebang usr bin env python in ez_setup.py
Zooko O'Whielacronx [Mon, 4 Jun 2007 11:45:17 +0000 (04:45 -0700)]
zfec: shebang usr bin env python in ez_setup.py

17 years agozfec: update doc strings in fileutil
Zooko O'Whielacronx [Mon, 4 Jun 2007 11:44:44 +0000 (04:44 -0700)]
zfec: update doc strings in fileutil

17 years agofix iputil so that it doesn't launch dozens of processes when you give it a full...
Zooko O'Whielacronx [Thu, 9 Aug 2007 17:56:47 +0000 (10:56 -0700)]
fix iputil so that it doesn't launch dozens of processes when you give it a full path and so that it tries executables in preference order and stops as soon as one gives out a dotted-quad string

17 years agoin --> across
wilcoxjg [Thu, 9 Aug 2007 04:17:54 +0000 (21:17 -0700)]
in --> across

17 years agocleaning grammar
wilcoxjg [Thu, 9 Aug 2007 04:11:54 +0000 (21:11 -0700)]
cleaning grammar

17 years ago/twistd.log -> /logs/twistd.log
wilcoxjg [Thu, 9 Aug 2007 03:53:28 +0000 (20:53 -0700)]
/twistd.log -> /logs/twistd.log

17 years agomisc/sizes.py: rename "block" to "share" and "subblock" to "block"
Zooko O'Whielacronx [Thu, 9 Aug 2007 05:31:12 +0000 (22:31 -0700)]
misc/sizes.py: rename "block" to "share" and "subblock" to "block"
This renaming is already in place in all of our other documentation and code, but misc/sizes.py got overlooked.

17 years agoarchitecture.txt: small edits
Zooko O'Whielacronx [Thu, 9 Aug 2007 05:31:05 +0000 (22:31 -0700)]
architecture.txt: small edits

17 years agostartstop_node now works if the logs directory already exists
Zooko O'Whielacronx [Thu, 9 Aug 2007 04:43:48 +0000 (21:43 -0700)]
startstop_node now works if the logs directory already exists
Thanks to Arno and Arch for pointing this out.

17 years agoREADME: formatting (line-wrapping) of arch_o_median's edits to README
Zooko O'Whielacronx [Thu, 9 Aug 2007 03:47:42 +0000 (20:47 -0700)]
README: formatting (line-wrapping) of arch_o_median's edits to README

17 years agochanged README to inslude simplejson in "The Python Way" install
wilcoxjg [Thu, 9 Aug 2007 03:43:40 +0000 (20:43 -0700)]
changed README to inslude simplejson in "The Python Way" install

17 years agochanged MakeFile to install simplejson
wilcoxjg [Thu, 9 Aug 2007 03:41:26 +0000 (20:41 -0700)]
changed MakeFile to install simplejson

17 years agoedited README "The Python Way" installs to /usr/bin
wilcoxjg [Thu, 9 Aug 2007 03:32:09 +0000 (20:32 -0700)]
edited README "The Python Way" installs to /usr/bin

17 years agoREADME: clarify/edit build, install, and test instructions
Zooko O'Whielacronx [Thu, 9 Aug 2007 03:44:58 +0000 (20:44 -0700)]
README: clarify/edit build, install, and test instructions

17 years agoclarify licence
Zooko O'Whielacronx [Thu, 9 Aug 2007 03:44:42 +0000 (20:44 -0700)]
clarify licence

17 years agoREADME: point people to allmydata.org if they are looking for precompiled packages
Zooko O'Whielacronx [Thu, 9 Aug 2007 03:44:03 +0000 (20:44 -0700)]
README: point people to allmydata.org if they are looking for precompiled packages

17 years agoREADME: edit to arch_o_median's contribution re: installing the Python way
Zooko O'Whielacronx [Thu, 9 Aug 2007 03:32:45 +0000 (20:32 -0700)]
README: edit to arch_o_median's contribution re: installing the Python way

17 years agoREADME: add note about what "darcs get" will do and how to run "darcs pull"
Zooko O'Whielacronx [Thu, 9 Aug 2007 03:28:32 +0000 (20:28 -0700)]
README: add note about what "darcs get" will do and how to run "darcs pull"

17 years agochanged README install "Python Way" section
wilcoxjg [Thu, 9 Aug 2007 03:00:35 +0000 (20:00 -0700)]
changed README install "Python Way" section

17 years agonow that the buildslave is moved to a new machine, enable the 50MB test
Brian Warner [Thu, 9 Aug 2007 08:32:52 +0000 (01:32 -0700)]
now that the buildslave is moved to a new machine, enable the 50MB test

17 years agofoolscap: fix .deb-breaking bug (foolscap.lothar.com: #8)
warner-tahoe [Wed, 8 Aug 2007 02:00:08 +0000 (19:00 -0700)]
foolscap: fix .deb-breaking bug (foolscap.lothar.com: #8)

17 years agoupdate foolscap to foolscap-0.1.5, the latest release
warner-tahoe [Wed, 8 Aug 2007 01:55:47 +0000 (18:55 -0700)]
update foolscap to foolscap-0.1.5, the latest release

17 years agoshebang /usr/bin/env python in ez_setup.py
Zooko O'Whielacronx [Wed, 8 Aug 2007 21:37:40 +0000 (14:37 -0700)]
shebang /usr/bin/env python in ez_setup.py
This makes it so that "./ez_setup.py" works on more platforms.

17 years agofix missing import -- this bug was introduced by the recent patch to relax setuptools...
Zooko O'Whielacronx [Tue, 7 Aug 2007 21:25:44 +0000 (14:25 -0700)]
fix missing import -- this bug was introduced by the recent patch to relax setuptools version requirements

17 years agoin relnotes.txt, make the safety warnings slightly less scary
Zooko O'Whielacronx [Tue, 7 Aug 2007 21:23:23 +0000 (14:23 -0700)]
in relnotes.txt, make the safety warnings slightly less scary

and update the reference to the wiki's UseCases page

17 years agorequire setuptools >= 0.6c6 on cygwin, and >= 0.6a9 on other platforms
Zooko O'Whielacronx [Tue, 7 Aug 2007 21:15:54 +0000 (14:15 -0700)]
require setuptools >= 0.6c6 on cygwin, and >= 0.6a9 on other platforms

Earlier I tried 0.6a9 (which comes in .deb format on Dapper) and something
didn't work, so I raised it to 0.6c3.  However, I didn't make a note of what
failed, and so now I'm hoping that what failed was cygwin-specific.  Anyway,
everyone look out for setuptools compatibility problems on the your favorite
platform (and I'll check the buildslaves), and we'll raise the required version
as little as possible and only on the problematic platform.

17 years agoupdate Arno's entry in CREDITS
Zooko O'Whielacronx [Tue, 7 Aug 2007 19:18:44 +0000 (12:18 -0700)]
update Arno's entry in CREDITS

17 years agoupdate README to reflect existence of "make install" target
Zooko O'Whielacronx [Tue, 7 Aug 2007 19:13:24 +0000 (12:13 -0700)]
update README to reflect existence of "make install" target

17 years agoupdate README to reflect requirement of setuptools 0.6c6
Zooko O'Whielacronx [Tue, 7 Aug 2007 19:12:59 +0000 (12:12 -0700)]
update README to reflect requirement of setuptools 0.6c6

17 years agoadd install target, works at lest on sudo-free cygwin
tahoe [Tue, 31 Jul 2007 23:55:45 +0000 (16:55 -0700)]
add install target, works at lest on sudo-free cygwin

17 years agosetuptools upgrade to 0.6c6
tahoe [Tue, 31 Jul 2007 23:18:11 +0000 (16:18 -0700)]
setuptools upgrade to 0.6c6

17 years agorefactor test_uri and add a test of the empty file
Zooko O'Whielacronx [Thu, 26 Jul 2007 17:48:30 +0000 (10:48 -0700)]
refactor test_uri and add a test of the empty file

17 years agomove nodelogs from BASEDIR/twistd.log* to BASEDIR/logs/twistd.log*, closes #61
Brian Warner [Wed, 25 Jul 2007 03:44:33 +0000 (20:44 -0700)]
move nodelogs from BASEDIR/twistd.log* to BASEDIR/logs/twistd.log*, closes #61

17 years agotest_web.py: oops, fix syntax error caused by removing comments
Brian Warner [Wed, 25 Jul 2007 10:21:30 +0000 (03:21 -0700)]
test_web.py: oops, fix syntax error caused by removing comments

17 years agotest_web.py: remove spurious '# YES' lines, now that all the tests pass
Brian Warner [Wed, 25 Jul 2007 03:16:21 +0000 (20:16 -0700)]
test_web.py: remove spurious '# YES' lines, now that all the tests pass

17 years agovdrive: eventually create public/private dirnodes event if the vdrive server isn...
Brian Warner [Wed, 25 Jul 2007 02:44:25 +0000 (19:44 -0700)]
vdrive: eventually create public/private dirnodes event if the vdrive server isn't available at start up

17 years agointerfaces: move signatures into docstrings, to reduce lines of code and improve...
Brian Warner [Wed, 25 Jul 2007 02:43:21 +0000 (19:43 -0700)]
interfaces: move signatures into docstrings, to reduce lines of code and improve code-coverage numbers

17 years agoremove unused imports: hush pyflakes warnings
Brian Warner [Wed, 25 Jul 2007 01:13:58 +0000 (18:13 -0700)]
remove unused imports: hush pyflakes warnings

17 years agoswitch from rfc 3548 base-32 to z-base-32 except for tubids/nodeids
Zooko O'Whielacronx [Tue, 24 Jul 2007 20:46:06 +0000 (13:46 -0700)]
switch from rfc 3548 base-32 to z-base-32 except for tubids/nodeids

17 years agoURI: we now derive the storage index from the encryption key
Brian Warner [Tue, 24 Jul 2007 09:55:42 +0000 (02:55 -0700)]
URI: we now derive the storage index from the encryption key

17 years agorefactor upload/encode, to split encrypt and encode responsibilities
Brian Warner [Tue, 24 Jul 2007 02:31:53 +0000 (19:31 -0700)]
refactor upload/encode, to split encrypt and encode responsibilities

17 years agoupdate architecture.txt a little bit
Brian Warner [Mon, 23 Jul 2007 03:30:05 +0000 (20:30 -0700)]
update architecture.txt a little bit

17 years agotruncate storage index to 128 bits, since it's derived from a 128 bit AES key
Brian Warner [Mon, 23 Jul 2007 02:48:44 +0000 (19:48 -0700)]
truncate storage index to 128 bits, since it's derived from a 128 bit AES key

17 years agosmall edit of relnotes
Zooko O'Whielacronx [Mon, 23 Jul 2007 01:23:37 +0000 (18:23 -0700)]
small edit of relnotes

17 years agoupdate relnotes.txt to reflect NJS's comments
Zooko O'Whielacronx [Mon, 23 Jul 2007 01:21:29 +0000 (18:21 -0700)]
update relnotes.txt to reflect NJS's comments

17 years agoCHK: remove the storage index from the URI, deriving it from the key instead
Brian Warner [Sun, 22 Jul 2007 01:23:15 +0000 (18:23 -0700)]
CHK: remove the storage index from the URI, deriving it from the key instead

17 years agouri.py: get keys and index from the URI instance
Brian Warner [Sun, 22 Jul 2007 00:45:00 +0000 (17:45 -0700)]
uri.py: get keys and index from the URI instance

17 years agodocs/uri.txt: document current URI formats
Brian Warner [Sun, 22 Jul 2007 00:29:01 +0000 (17:29 -0700)]
docs/uri.txt: document current URI formats

17 years agouri: implement URI-processing classes, IFileURI/IDirnodeURI, use internally
Brian Warner [Sat, 21 Jul 2007 22:40:36 +0000 (15:40 -0700)]
uri: implement URI-processing classes, IFileURI/IDirnodeURI, use internally

17 years agodirnode.build_manifest(): tolerate cycles in the directory graph
Brian Warner [Sat, 21 Jul 2007 22:40:13 +0000 (15:40 -0700)]
dirnode.build_manifest(): tolerate cycles in the directory graph

17 years agoupload: finish refactoring, all unit tests pass now
Brian Warner [Fri, 20 Jul 2007 05:53:29 +0000 (22:53 -0700)]
upload: finish refactoring, all unit tests pass now

17 years agoupload: refactor to enable streaming upload. not all tests pass yet
Brian Warner [Fri, 20 Jul 2007 01:21:44 +0000 (18:21 -0700)]
upload: refactor to enable streaming upload. not all tests pass yet

17 years agowebish: improve test coverage further
Brian Warner [Tue, 17 Jul 2007 19:28:29 +0000 (12:28 -0700)]
webish: improve test coverage further

17 years agowebish: improve test coverage of WebDownloadTarget
Brian Warner [Tue, 17 Jul 2007 19:16:45 +0000 (12:16 -0700)]
webish: improve test coverage of WebDownloadTarget

17 years agoMakefile/check-memory: put all stats in ./memstats.out
Brian Warner [Tue, 17 Jul 2007 17:41:41 +0000 (10:41 -0700)]
Makefile/check-memory: put all stats in ./memstats.out

17 years agocheck_memory.py: test POST-based uploads as well as from-disk ones
Brian Warner [Tue, 17 Jul 2007 03:17:51 +0000 (20:17 -0700)]
check_memory.py: test POST-based uploads as well as from-disk ones

17 years agovdrive.py: log a note when we successfully retrieve the global root directory
Brian Warner [Tue, 17 Jul 2007 03:17:06 +0000 (20:17 -0700)]
vdrive.py: log a note when we successfully retrieve the global root directory

17 years agointroducer.py: minor rearrangement of methods
Brian Warner [Tue, 17 Jul 2007 02:47:42 +0000 (19:47 -0700)]
introducer.py: minor rearrangement of methods

17 years agocheck_memory.py: fix benign-but-noisy vdrive.furl handling bug
Brian Warner [Tue, 17 Jul 2007 02:34:52 +0000 (19:34 -0700)]
check_memory.py: fix benign-but-noisy vdrive.furl handling bug

17 years agocheck_memory: update it, write stats to a file, disable 50MB test for now
Brian Warner [Tue, 17 Jul 2007 01:08:55 +0000 (18:08 -0700)]
check_memory: update it, write stats to a file, disable 50MB test for now

17 years agoclient.py: add a 'debug_no_storage' option to throw out all share data
Brian Warner [Tue, 17 Jul 2007 01:07:03 +0000 (18:07 -0700)]
client.py: add a 'debug_no_storage' option to throw out all share data

17 years agoclient.py: write control.furl in the right place
Brian Warner [Tue, 17 Jul 2007 01:06:27 +0000 (18:06 -0700)]
client.py: write control.furl in the right place

17 years agoadded unit test to webish's rename function
robk-org [Tue, 17 Jul 2007 00:05:01 +0000 (17:05 -0700)]
added unit test to webish's rename function

added unit tests to test various permutations of the rename function, and
some sanity checks on the rename-form function.

also added a guard to prevent '/' in from_/to_name in rename calls.

17 years agorunner.py: make 'allmydata-tahoe --version' emit version numbers of everything
Brian Warner [Mon, 16 Jul 2007 21:58:36 +0000 (14:58 -0700)]
runner.py: make 'allmydata-tahoe --version' emit version numbers of everything

17 years agoreduce MAX_SEGMENT_SIZE from 2MB to 1MB, to compensate for the large blocks that...
Brian Warner [Mon, 16 Jul 2007 20:48:34 +0000 (13:48 -0700)]
reduce MAX_SEGMENT_SIZE from 2MB to 1MB, to compensate for the large blocks that 3-of-10 produces

17 years agomisc/storage-overhead.py: tool to estimate storage-space overhead per filesize
Brian Warner [Mon, 16 Jul 2007 20:43:31 +0000 (13:43 -0700)]
misc/storage-overhead.py: tool to estimate storage-space overhead per filesize

17 years agowebish: test error cases more thoroughly by looking inside the response text
Brian Warner [Mon, 16 Jul 2007 19:01:19 +0000 (12:01 -0700)]
webish: test error cases more thoroughly by looking inside the response text

17 years agowebish: oops, handle POST without localfile= too
Brian Warner [Mon, 16 Jul 2007 19:00:54 +0000 (12:00 -0700)]
webish: oops, handle POST without localfile= too

17 years agowebish.py: disallow slashes in POSTed filenames. Closes #75.
Brian Warner [Mon, 16 Jul 2007 18:53:12 +0000 (11:53 -0700)]
webish.py: disallow slashes in POSTed filenames. Closes #75.

17 years agowebish.Directory: add a 'text/plain' link for files, to download as plaintext.
Brian Warner [Sat, 14 Jul 2007 06:45:35 +0000 (23:45 -0700)]
webish.Directory: add a 'text/plain' link for files, to download as plaintext.
This is useful to view (e.g.) .py files that would otherwise be served as
some weird text/x-python that browsers will just want to save to disk.

17 years agostorage.py: add a test for the next_power_of_k fix I made a few hours ago, basically...
Brian Warner [Sat, 14 Jul 2007 05:24:06 +0000 (22:24 -0700)]
storage.py: add a test for the next_power_of_k fix I made a few hours ago, basically do an upload with a non-power-of-two number of segments

17 years agowebish.py: test that _get_or_create_directories fix I made a few hours ago
Brian Warner [Sat, 14 Jul 2007 05:19:16 +0000 (22:19 -0700)]
webish.py: test that _get_or_create_directories fix I made a few hours ago

17 years agosimplejson: lower our minimum-required-version of setuptools to 0.6a9, since that...
Brian Warner [Sat, 14 Jul 2007 02:47:56 +0000 (19:47 -0700)]
simplejson: lower our minimum-required-version of setuptools to 0.6a9, since that seems to work, and it's the version that comes with dapper

17 years agowebish: handle PUTs to direct children of the root
Brian Warner [Sat, 14 Jul 2007 02:31:52 +0000 (19:31 -0700)]
webish: handle PUTs to direct children of the root

17 years agostorage.py: turn some assertions into preconditions
Brian Warner [Sat, 14 Jul 2007 02:30:48 +0000 (19:30 -0700)]
storage.py: turn some assertions into preconditions

17 years agostorage.py: handle num_segments != power-of-two without an assertion
Brian Warner [Sat, 14 Jul 2007 02:30:21 +0000 (19:30 -0700)]
storage.py: handle num_segments != power-of-two without an assertion

17 years agointerfaces: increase ShareSize now that our default k is smaller (hence blocks are...
Brian Warner [Sat, 14 Jul 2007 02:29:31 +0000 (19:29 -0700)]
interfaces: increase ShareSize now that our default k is smaller (hence blocks are bigger)

17 years agorename storageserver.py to just storage.py, since it has both server and client sides now
Brian Warner [Sat, 14 Jul 2007 00:25:45 +0000 (17:25 -0700)]
rename storageserver.py to just storage.py, since it has both server and client sides now

17 years agowelcome.xhtml: add a link to allmydata.org
Brian Warner [Sat, 14 Jul 2007 00:15:44 +0000 (17:15 -0700)]
welcome.xhtml: add a link to allmydata.org

17 years agoencode.py: minor typo
Brian Warner [Sat, 14 Jul 2007 00:00:06 +0000 (17:00 -0700)]
encode.py: minor typo

17 years agofix dump-uri-extension
Brian Warner [Fri, 13 Jul 2007 23:58:08 +0000 (16:58 -0700)]
fix dump-uri-extension

17 years agostorageserver.ReadBucketProxy: break out _parse_offsets, for debug tools
Brian Warner [Fri, 13 Jul 2007 23:52:17 +0000 (16:52 -0700)]
storageserver.ReadBucketProxy: break out _parse_offsets, for debug tools

17 years agostorage: we must truncate short segments. Now most tests pass (except uri_extension)
Brian Warner [Fri, 13 Jul 2007 23:38:25 +0000 (16:38 -0700)]
storage: we must truncate short segments. Now most tests pass (except uri_extension)

17 years agomore #85 work, system test still fails
Brian Warner [Fri, 13 Jul 2007 22:09:01 +0000 (15:09 -0700)]
more #85 work, system test still fails

17 years agostorage: use one file per share instead of 7 (#85). work-in-progress, tests still...
Brian Warner [Fri, 13 Jul 2007 21:04:49 +0000 (14:04 -0700)]
storage: use one file per share instead of 7 (#85). work-in-progress, tests still fail

17 years agocontrol.py: make get_memory_usage() callable from elsewhere
Brian Warner [Mon, 9 Jul 2007 02:07:54 +0000 (19:07 -0700)]
control.py: make get_memory_usage() callable from elsewhere

17 years agoadd a 'rename' button to the webish dir view
robk-org [Thu, 12 Jul 2007 23:53:54 +0000 (16:53 -0700)]
add a 'rename' button to the webish dir view

alongside the 'del' button is now presented a 'rename' button, which takes
the user to a new page, the 't=rename-form' page, which asks ther user for
the new name of the child and ultimately submits a POST request to the dir
for 't=rename' to perform the actual rename i.e. an attach followed by a
delete of children.

17 years agofix bug in arg handling around 'delete' button in directory view
robk-org [Thu, 12 Jul 2007 23:46:54 +0000 (16:46 -0700)]
fix bug in arg handling around 'delete' button in directory view

the code composing the form providing the 'delete' button in a dir
view was broken in that it tried to put some of the arguments into
the url query, rather than as the form's post args.  worse, nevow
was kind enough to escape the querystring making it invalid.

17 years agofix a typo in webapi.txt
robk-org [Thu, 12 Jul 2007 23:45:51 +0000 (16:45 -0700)]
fix a typo in webapi.txt

17 years agoinclude the filename on URI-link urls for files
robk-org [Wed, 11 Jul 2007 22:26:47 +0000 (15:26 -0700)]
include the filename on URI-link urls for files

this is likely to induce browsers to do more useful things with the result
than they would when given neither content-type nor filename.  (i.e. they
can guess that a .jpg file is an image, even with a bogus content type)

17 years agoadded notes on pywin32 version support to README
robk-org [Wed, 13 Jun 2007 20:09:36 +0000 (13:09 -0700)]
added notes on pywin32 version support to README

17 years agowebish.DirnodeWalkerMixin: comment out the code that demonstrates what we
Brian Warner [Fri, 13 Jul 2007 06:28:09 +0000 (23:28 -0700)]
webish.DirnodeWalkerMixin: comment out the code that demonstrates what we
would do if we could just use generators, since we don't use it.

17 years agomisc/figleaf.excludes: exclude simplejson too, since we don't run their tests
Brian Warner [Thu, 12 Jul 2007 23:26:25 +0000 (16:26 -0700)]
misc/figleaf.excludes: exclude simplejson too, since we don't run their tests

17 years agonote that setting k=1 is equivalent to replication
Brian Warner [Thu, 12 Jul 2007 23:22:12 +0000 (16:22 -0700)]
note that setting k=1 is equivalent to replication

17 years agofix several methods to handle LIT URIs correctly, rather than assuming that all filen...
Brian Warner [Thu, 12 Jul 2007 23:17:49 +0000 (16:17 -0700)]
fix several methods to handle LIT URIs correctly, rather than assuming that all filenodes are CHK URIs

17 years agomake it possible to download LIT uris. oops.
Brian Warner [Thu, 12 Jul 2007 23:16:59 +0000 (16:16 -0700)]
make it possible to download LIT uris. oops.

17 years agoallow the introducer to set default encoding parameters. Closes #84.
Brian Warner [Thu, 12 Jul 2007 22:33:30 +0000 (15:33 -0700)]
allow the introducer to set default encoding parameters. Closes #84.
By writing something like "25 75 100" into a file named 'encoding_parameters'
in the central Introducer's base directory, all clients which use that
introducer will be advised to use 25-out-of-100 encoding for files (i.e.
100 shares will be produced, 25 are required to reconstruct, and the upload
process will be happy if it can find homes for at least 75 shares). The
default values are "3 7 10". For small meshes, the defaults are probably
good, but for larger ones it may be appropriate to increase the number of
shares.