zfec: don't use vsnprintf (because it is named _vsnprintf and has slightly different...

darcs-hash:5119f21d54da904a47f1a664c7d67eeeca0823b6

diff --git a/zfec/zfec/_fecmodule.c b/zfec/zfec/_fecmodule.c
index 905030047681ee3446fdff93f3cd477d7c22544f..4939a8c0359e37c2b712fcc4ee419e255489edbc 100644 (file)
--- a/zfec/zfec/_fecmodule.c
+++ b/zfec/zfec/_fecmodule.c
@@ -20,13 +20,14 @@ static char fec__doc__[] = "\
 FEC - Forward Error Correction \n\
 ";
 
+/* NOTE: if the complete expansion of the args (by vsprintf) exceeds 1024 then memory will be invalidly overwritten. */
 static PyObject *
 py_raise_fec_error(const char *format, ...) {
     char exceptionMsg[1024];
     va_list ap;
 
     va_start (ap, format);
-    vsnprintf (exceptionMsg, 1024, format, ap);
+    vsprintf (exceptionMsg, format, ap); /* Make sure that this can't exceed 1024 chars! */
     va_end (ap);
     exceptionMsg[1023]='\0';
     PyErr_SetString (py_fec_error, exceptionMsg);