make the nodeurl start with '127.0.0.1' instead of with 'localhost'

This is because there exist in the wild computers that are misconfigured so that 'localhost' doesn't resolve to 127.0.0.1.  On those computers, using 'localhost' for the nodeurl is a security problem, because the user commonly sends valuable caps to the nodeurl.

diff --git a/src/allmydata/webish.py b/src/allmydata/webish.py
index f591cf6535761d6361c087cb072d8f23690ee044..89935fb1bada877cf8238c55642d7e3954a0a9fc 100644 (file)
--- a/src/allmydata/webish.py
+++ b/src/allmydata/webish.py
@@ -1579,9 +1579,9 @@ class WebishServer(service.MultiService):
         # what is our webport?
         s = self.listener
         if isinstance(s, internet.TCPServer):
-            base_url = "http://localhost:%d" % s._port.getHost().port
+            base_url = "http://127.0.0.1:%d" % s._port.getHost().port
         elif isinstance(s, internet.SSLServer):
-            base_url = "https://localhost:%d" % s._port.getHost().port
+            base_url = "https://127.0.0.1:%d" % s._port.getHost().port
         else:
             base_url = None
         if base_url: