From: robk-org <robk-org@allmydata.com>
Date: Thu, 12 Jul 2007 23:46:54 +0000 (-0700)
Subject: fix bug in arg handling around 'delete' button in directory view
X-Git-Url: https://git.rkrishnan.org/pf/content/en/seg/something?a=commitdiff_plain;h=15c30551765756171058313ce8a956cfdcc1fe64;p=tahoe-lafs%2Ftahoe-lafs.git

fix bug in arg handling around 'delete' button in directory view

the code composing the form providing the 'delete' button in a dir
view was broken in that it tried to put some of the arguments into
the url query, rather than as the form's post args.  worse, nevow
was kind enough to escape the querystring making it invalid.
---

diff --git a/src/allmydata/webish.py b/src/allmydata/webish.py
index 8c13a1b8..168af19e 100644
--- a/src/allmydata/webish.py
+++ b/src/allmydata/webish.py
@@ -74,9 +74,10 @@ class Directory(rend.Page):
             # this creates a button which will cause our child__delete method
             # to be invoked, which deletes the file and then redirects the
             # browser back to this directory
-            del_url = url.here.add("t", "delete").add("name", name)
-            del_url = del_url.add("when_done", url.here)
-            delete = T.form(action=del_url, method="post")[
+            delete = T.form(action=url.here, method="post")[
+                T.input(type='hidden', name='t', value='delete'),
+                T.input(type='hidden', name='name', value=name),
+                T.input(type='hidden', name='when_done', value=url.here),
                 T.input(type='submit', value='del', name="del"),
                 ]
         else: