From: Brian Warner <warner@allmydata.com>
Date: Mon, 9 Feb 2009 21:50:04 +0000 (-0700)
Subject: upload: add a think-of-the-compatibility note to UploadResults
X-Git-Tag: allmydata-tahoe-1.3.0~57
X-Git-Url: https://git.rkrishnan.org/pf/content?a=commitdiff_plain;h=a9a3b509df791a82ca7a58ad315f342db3686c84;p=tahoe-lafs%2Ftahoe-lafs.git

upload: add a think-of-the-compatibility note to UploadResults
---

diff --git a/src/allmydata/immutable/upload.py b/src/allmydata/immutable/upload.py
index 28edda49..ed377daf 100644
--- a/src/allmydata/immutable/upload.py
+++ b/src/allmydata/immutable/upload.py
@@ -46,6 +46,11 @@ class UploadResults(Copyable, RemoteCopy):
     typeToCopy = "allmydata.upload.UploadResults.tahoe.allmydata.com"
     copytype = typeToCopy
 
+    # also, think twice about changing the shape of any existing attribute,
+    # because instances of this class are sent from the helper to its client,
+    # so changing this may break compatibility. Consider adding new fields
+    # instead of modifying existing ones.
+
     def __init__(self):
         self.timings = {} # dict of name to number of seconds
         self.sharemap = dictutil.DictOfSets() # {shnum: set(serverid)}