Daira's excellent fixes to the uploader from our pairing session

Teach uploader's _scan to use the deque

Split scanning into a separate method so that we can call it periodically.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Teach magic-folder join to use configutil.

Author: David Stainton <david@leastauthority.com>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Refactor tahoe.cfg handling to configutil.

Author: David Stainton <david@leastauthority.com>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Add magic-folder test_scan_once_on_startup

Various test cleanups.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Teach join twice test to test for proper stdout and stderr values

More thorough checks to the join leave join test

Fix test_join_leave_join

Add more magic-folder join leave tests

Add unit test for join twice failure

Delay only the download scan not the turning of our event queue.

Author: David Stainton <david@leastauthority.com>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Merge pull request #212 from david415/2535.fix-file-perms.0

set downloader umask

Fix magic folder constructor signature in test

Fix tests usage of umask

Merge pull request #210 from david415/2593.remove_from_config.0

Remove magic_folder subsection from default tahoe.cfg

Fix umask again

Merge pull request #209 from david415/2554.remove-exclude-stat.0

Remove magic-folder exclude stat

Fix umask usage bit fiddling and use try finally blocks

remove magic_folder from config in test

Add download.umask config option with default of 077

Add umask to Downloader

Remove magic_folder subsection from default tahoe.cfg

Remove magic-folder exclude stat

drop Python 2.6 (.travis.yml, doc, setup.py)

Twisted 15 dropped support for it, which causes Travis CI tests to fail on 2.6.
We still theoretically support older versions of Twisted, so perhaps we should
configure Travis to test with those? I think we should drop Python 2.6 in any
case since distros are all on 2.7 now.

I'm leaving Travis running (and ignoring) the failing PyPy tests because I
don't know why that is there.

Merge pull request #205 from tahoe-lafs/2568.make-join-useable.1

2568.make-join-useable.1

Improve the error reporting for 'tahoe magic-folder join/leave'. refs #2568

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

teach leave to: remove magic_folder section of config

Add simple magic-folder leave command

Teach join to also check for existing magicfolder db file

Prevent magic-folder join if already joined.

Refactor is_new_file.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

.gitignore: add /smoke_magicfolder/, delete obsolete stuff.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Add section for "Conflict/overwrite decision algorithm" and label substeps so that we can refer to them from the code.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Clarify corner cases in the conflict/overwrite decision.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Minor simplification.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Simply conflict detection by removing nested if statements

Scan our own dmd upon start only

remove print

Add a unit-test and correct the code for "already deleted"

If a Downloader decides that it needs to delete a file, but that
file is already gone locally, the exeption is caugt and a log message
produced.

Fix test: previously we accounted for the propagation of the conflict
because alice scaned her own dmd... whereas now she does not.

Fix test helper _check_version_in_local_db

WIP: Refactoring to get db fields in one query.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

WIP

Fix pending upload conflict detection.

Author: David Stainton <david@leastauthority.com>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Create test for last upload uri conflict

Detect remote conflict by checking for pending upload.

Author: David Stainton <david@leastauthority.com>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Add debugging print statement for timestamp comparison

Add last uploaded timestamp comparison for remote conflict detection

Fix an unused import.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix some miscapture bugs.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Workaround.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Simplify _notify and improve logging.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Simplify _scan_remote_* and remove Downloader._download_scan_batch attribute.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Cosmetics.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Downloader doesn't need the pending set.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Delete redundant is_ready attribute from MagicFolder.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

test_encodingutil: fixes for Unix.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Add precondition to Uploader._process.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix test_errors.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix test_move_tree.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Debugging WIP.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix a corner case for to_filepath on Windows to make it consistent with Unix.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

test_encodingutil: add tests for FilePath-related functions.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

test_encodingutil: use self.patch rather than modifying encodingutil.io_encoding directly.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Depend on FilePath.asTextMode().

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

WIP: exclude own dirnode from scan. This is not quite right; we shouldn't exclude it on startup. refs #2553

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Magic Folder docs: status of tests on Windows.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

More Magic Folder doc updates.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Magic Folder doc updates.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Don't add subdirectory watches if the platform's notifier doesn't require them. refs #2559

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Improve reporting of assertion failures.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix the change to turn off bridging to Twisted log.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix unused import.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Revert pinning of Twisted 15.2.0 which causes more problems than it solves.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Turn off bridging to Twisted log, and pin to Twisted 15.2.0.
Hopefully this will avoid http://foolscap.lothar.com/trac/ticket/244 .

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Merge pull request #200 from meejah/2438.magic-folder-stable.5

some minor fixes for instructions

fix the windows command-line too

some minor fixes for instructions

Windows path fix.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

magic-folder-howto.rst formatting fixes.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Add docs/magic-folder-howto.rst.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Add test for 'tahoe create-node/client/introducer' output. closes ticket:2556

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Quote local paths correctly in the output of node creation commands. fixes ticket:2556

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

bin\tahoe can't be run directly on Windows.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Strip any long path marker in the input to flush_volume.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Correct type for Windows BOOL.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Depend on Twisted >= 15.2.0 and (finally!) retire the setup_requires hack.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Disable precondition that autoAdd == recursive.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix a type error.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Flush handling WIP.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Use fileutil.write for magic folder tests.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Improve all of the Windows-specific error reporting.
Also make the Windows function declarations more readable and consistent.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Consolidate Windows-specific imports in fileutil to avoid pyflakes warnings.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

replace_file should allow the replaced file not to exist on Windows.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix fileutil tests.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

More path fixes.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix a test broken by the last commit.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Don't include [magic_folder]enabled and local.directory fields by default.
Add a comment reminding to do the field modification properly.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>