From: David Stainton <dstainton415@gmail.com>
Date: Wed, 15 Apr 2015 18:13:41 +0000 (+0000)
Subject: Bug fix: deque must be unbounded
X-Git-Url: https://git.rkrishnan.org/reliability?a=commitdiff_plain;h=7e64d6021192708c91cc7093f0bcbac3f4e01ae2;p=tahoe-lafs%2Ftahoe-lafs.git

Bug fix: deque must be unbounded

If using a bounded deque then:
"""
Once a bounded length deque is full, when new items are added, a corresponding number of items are discarded from the opposite end.
"""

This bug was introduced at commit 87657eb382da05039cce99862691efcc27243193
---

diff --git a/src/allmydata/frontends/drop_upload.py b/src/allmydata/frontends/drop_upload.py
index 0dfe42b7..ffabad46 100644
--- a/src/allmydata/frontends/drop_upload.py
+++ b/src/allmydata/frontends/drop_upload.py
@@ -17,7 +17,7 @@ class DropUploader(service.MultiService):
     name = 'drop-upload'
 
     def __init__(self, client, upload_dircap, local_dir_utf8, inotify=None,
-                 deque_max_len=100, pending_delay=1.0):
+                 pending_delay=1.0):
         service.MultiService.__init__(self)
 
         try:
@@ -37,7 +37,7 @@ class DropUploader(service.MultiService):
         self._convergence = client.convergence
         self._local_path = FilePath(local_dir)
 
-        self._upload_deque = deque(maxlen=deque_max_len)
+        self._upload_deque = deque()
         self.is_upload_ready = False
 
         if inotify is None: