From: david-sarah Date: Tue, 2 Aug 2011 17:24:37 +0000 (-0700) Subject: verifier: correct a bug introduced in changeset [5106] that caused us to only verify... X-Git-Url: https://git.rkrishnan.org/reliability?a=commitdiff_plain;h=c7f65ee8ad254f3f84b20706b3f2048c77994785;p=tahoe-lafs%2Ftahoe-lafs.git verifier: correct a bug introduced in changeset [5106] that caused us to only verify the first block of a file. refs #1395 --- diff --git a/src/allmydata/immutable/checker.py b/src/allmydata/immutable/checker.py index 6731e94c..ad7931b9 100644 --- a/src/allmydata/immutable/checker.py +++ b/src/allmydata/immutable/checker.py @@ -615,18 +615,21 @@ class Checker(log.PrefixingLogMixin): assert isinstance(r, str), r # to free up the RAM return None + def _get_blocks(vrbp): def _get_block(ign, blocknum): db = vrbp.get_block(blocknum) db.addCallback(_discard_result) return db + dbs = defer.succeed(None) for blocknum in range(veup.num_segments): dbs.addCallback(_get_block, blocknum) - # The Deferred we return will fire after every block of this - # share has been downloaded and verified successfully, or else it - # will errback as soon as the first error is observed. - return dbs + + # The Deferred we return will fire after every block of this + # share has been downloaded and verified successfully, or else it + # will errback as soon as the first error is observed. + return dbs d.addCallback(_get_blocks)