From: David-Sarah Hopwood Date: Thu, 3 Jan 2013 18:54:04 +0000 (+0000) Subject: startstop_node.py: improvements to comments. X-Git-Url: https://git.rkrishnan.org/schema.xhtml?a=commitdiff_plain;h=3e98f489833f2c2a9a87576efc3627df4cd9bf78;p=tahoe-lafs%2Ftahoe-lafs.git startstop_node.py: improvements to comments. Signed-off-by: David-Sarah Hopwood --- diff --git a/src/allmydata/scripts/startstop_node.py b/src/allmydata/scripts/startstop_node.py index a0c69bb6..424b3289 100644 --- a/src/allmydata/scripts/startstop_node.py +++ b/src/allmydata/scripts/startstop_node.py @@ -147,7 +147,7 @@ def start(config, out=sys.stdout, err=sys.stderr): verb = "running" print >>out, "%s node in %s" % (verb, basedir) twistd.runApp(twistd_config) - # we should only reach here if --nodaemon was used + # we should only reach here if --nodaemon or equivalent was used return 0 def stop(config, out=sys.stdout, err=sys.stderr): @@ -219,7 +219,10 @@ def restart(config, stdout, stderr): def run(config, stdout, stderr): config.twistd_args = config.twistd_args + ("--nodaemon",) - # also ("--logfile", "tahoesvc.log") + # Previously we would do the equivalent of adding ("--logfile", "tahoesvc.log"), + # but that redirects stdout/stderr which is often unhelpful, and the user can + # add that option explicitly if they want. + return start(config, stdout, stderr)