Correct type for Windows BOOL.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Depend on Twisted >= 15.2.0 and (finally!) retire the setup_requires hack.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Disable precondition that autoAdd == recursive.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix a type error.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Flush handling WIP.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Use fileutil.write for magic folder tests.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Improve all of the Windows-specific error reporting.
Also make the Windows function declarations more readable and consistent.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Consolidate Windows-specific imports in fileutil to avoid pyflakes warnings.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

replace_file should allow the replaced file not to exist on Windows.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix fileutil tests.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

More path fixes.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix a test broken by the last commit.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Don't include [magic_folder]enabled and local.directory fields by default.
Add a comment reminding to do the field modification properly.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Don't use a long path for the [magic_folder]local.directory field.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix some path Unixisms.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Add long_path=False option to abspath_expanduser_unicode.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix test_alice_bob.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Refactor _check_up/downloader_count.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Don't download the deletion marker file unnecessarily.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Distinguish deletion of directories.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Rename deleted files to .backup rather than unlinking them.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Add file conflict unit test

Add basic bob upload test and fix conflict detect

Fix bob's uploading test...

Attempt to teach bob to upload a file

Count conflicted objects

Basic remote conflict detection based on ancestor uri

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

magic-folder.rst: remove "Known Issues and Limitations" that have been fixed.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

magic-folder.rst: update introduction.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Avoid .format, since it is inconsistent between Python 2.6 and 2.7 (and the rest of Tahoe-LAFS doesn't use it).

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix test_alice_bob.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Add counter for uploader.objects_not_uploaded.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Advance Bob's clock after notifying.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

test_alice_bob: use magic= argument to notify, rather than self.magicfolder.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

add excluded check

add the 'spurious' notifies

Fix a pyflakes warning and check existence of file in Bob's local dir.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

implement 'delete' functionality, with tests

smoketest for magic-folder functionality

Describe use of size=None for deleted files. refs ticket:1710.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Schema change for last_uploaded_uri.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Earth Dragons: take into account that the replaced file may not exist.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Writing a file without a db entry is an overwrite.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

remote-to-local-sync.rst: fix an inconsistency in the representation option table.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Add test that we don't write files outside the magic folder directory. refs ticket:2506

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix infinite loop in should_ignore_path for absolute paths.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

More debug logging.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Unicode fix for do_join.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Minor cleanups to tests.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Ensure that errors from Alice-and-Bob tests are reported correctly if setup fails.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Cosmetics.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Eliminate duplicate parsing of invite code.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Remaining test fixes.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Make sure that do_cli is only called with strs, and avoid unnecessary use of attributes in tests.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Cosmetics.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

URIs are strs.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Aliases and nicknames are Unicode.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Add precondition that arguments to do_cli are strs.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix call to argv_to_abspath. Also rename localdir to local_dir.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix magic-folder cli tests

convert path to abs path when matching
strings in the generated config file.

Attempt to fix cli tests

Better but still broken tests.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix check for initial '-' in argv_to_abspath.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix tests by submitting unicode args instead of str

Teach magic-folder join to use argv_to_abspath

- also we modify argv_to_abspath to through a usage error
if the name starts with a '-'

- add a test
currently the tests fail

Use argv_to_abspath for magic-folder join file path arg

Test creation of a subdirectory.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Watch for IN_CREATE events but filter them out for non-directories.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Patch Downloader.REMOTE_SCAN_INTERVAL rather than setting it persistently.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Implement creating local directories in downloader.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Decode names in the scanned remote.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Refactoring to allow logging from _write_downloaded_file and _rename_conflicted_file.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Simplify and fix non-existent-file handling.
Also make the existent and non-existent cases as similar as possible,
with a view to merging them.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Logging/debugging improvements.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Refactor and fix race conditions in test_alice_bob.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Correct a call to did_upload_version in the downloader.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Make sure that test_move_tree waits until files have been uploaded as well as downloaded.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Restore a call to increment files_uploaded that was mistakenly removed.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Teach uploader+downloader to use to db schema

here we attempt to fix all the unit tests as well...
however two tests still fail

Add magicfolderdb.py.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Remove magic-folder db code from backupdb.py

WIP

Include brief summary of magic-folder CLI commands

Add link to our cli design doc

Mention gc is not part of the otf grant and link to the gc ticket

Remove old obsolete/inaccurate statements

Minor comment correction for get_all_relpaths

For all downloaded files ensure parent dir exists

Simplify the cleanup_Alice_and_Bob callback.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Make downloader delay a class-variable

This gives the integration-style CLI-based tests a chance
to set the delay to 0 before the first 3-second delayed
call is queued to _lazy_tail in the Downloader

Teach unit-tests to time-warp

1. Split alice/bob clocks to avoid races conditions
   in the tests
2. Wrap ._notify so we can advance the clock after inotify
   calls in the RealTest (since it takes >0ms to do the "real" notifies)

Fix call to ready()

Correct a string-type error.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

WIP.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Magic Folder file moves.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Prepare to move drop_upload.py to magic_folder.py.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Move backupdb.py to src/allmydata.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Rename upload_ready_d to connected_enough_d.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Documentation changes for Magic Folder.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Teach StorageFarmBroker to fire a deferred when a connection threshold is reached. refs #1449

Signed-off-by: Daira Hopwood <daira@jacaranda.org>