From: Daira Hopwood Date: Tue, 3 Nov 2015 22:26:01 +0000 (+0000) Subject: Fix pending upload conflict detection. X-Git-Url: https://git.rkrishnan.org/simplejson/%22news.html/frontends/quickstart.html?a=commitdiff_plain;h=052aaf0bc7019f1f1579ef11bb4a4fbf3592d541;p=tahoe-lafs%2Ftahoe-lafs.git Fix pending upload conflict detection. Author: David Stainton Signed-off-by: Daira Hopwood --- diff --git a/src/allmydata/frontends/magic_folder.py b/src/allmydata/frontends/magic_folder.py index df26ebb8..e52d1c97 100644 --- a/src/allmydata/frontends/magic_folder.py +++ b/src/allmydata/frontends/magic_folder.py @@ -266,7 +266,7 @@ class Uploader(QueueMixin): return d - def is_pending(relpath_u): + def is_pending(self, relpath_u): return relpath_u in self._pending def _notify(self, opaque, path, events_mask): @@ -713,18 +713,18 @@ class Downloader(QueueMixin, WriteFileMixin): if dmd_last_downloaded_uri != local_last_downloaded_uri: is_conflict = True self._count('objects_conflicted') + else: + dmd_last_uploaded_uri = metadata.get('last_uploaded_uri', None) + local_last_uploaded_uri = self._db.get_last_uploaded_uri(relpath_u) + print ">>>> if %r != %r" % (dmd_last_uploaded_uri, local_last_uploaded_uri) + if dmd_last_uploaded_uri is not None and dmd_last_uploaded_uri != local_last_uploaded_uri: + is_conflict = True + self._count('objects_conflicted') else: - dmd_last_uploaded_uri = metadata.get('last_uploaded_uri', None) - local_last_uploaded_uri = self._db.get_last_uploaded_uri(relpath_u) - print ">>>> if %r != %r" % (dmd_last_uploaded_uri, local_last_uploaded_uri) - if dmd_last_uploaded_uri != local_last_uploaded_uri: + # XXX todo: mark as conflict if file is in pending upload set + if self._is_upload_pending(relpath_u): is_conflict = True self._count('objects_conflicted') - else: - # XXX todo: mark as conflict if file is in pending upload set - if self._is_upload_pending(relpath_u): - is_conflict = True - self._count('objects_conflicted') if relpath_u.endswith(u"/"): if metadata.get('deleted', False):