From a5363b6d47dd79e029da27e0f732c2b64be4b85b Mon Sep 17 00:00:00 2001 From: Ramakrishnan Muthukrishnan Date: Sun, 8 Jan 2023 08:40:19 +0530 Subject: [PATCH] midi menu: bug fix for a crash because of an uninitialized pointer --- midi_menu.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/midi_menu.c b/midi_menu.c index 35bd822..f804f91 100644 --- a/midi_menu.c +++ b/midi_menu.c @@ -357,6 +357,13 @@ static void load_original_cb(GtkWidget *widget,gpointer user_data) { gint res; struct desc *cmd; + if (midi_device_name == NULL) { + filename = g_new(gchar,10); + sprintf(filename,"midi.midi"); + } else { + filename=g_new(gchar,strlen(midi_device_name)+6); + sprintf(filename,"%s.midi",midi_device_name); + } load_dialog = gtk_file_chooser_dialog_new ("Open ORIGINAL MIDI File", GTK_WINDOW(dialog), action, @@ -366,8 +373,6 @@ static void load_original_cb(GtkWidget *widget,gpointer user_data) { GTK_RESPONSE_ACCEPT, NULL); chooser = GTK_FILE_CHOOSER (load_dialog); - filename=g_new(gchar,strlen(midi_device_name)+6); - sprintf(filename,"%s.midi",midi_device_name); gtk_file_chooser_set_current_name(chooser,filename); res = gtk_dialog_run (GTK_DIALOG (load_dialog)); if(res==GTK_RESPONSE_ACCEPT) { -- 2.45.2