From: Brian Warner Date: Fri, 10 Sep 2010 04:30:38 +0000 (-0700) Subject: immutable download: have the finder inform its share consumer "no more shares" in... X-Git-Tag: allmydata-tahoe-1.8.0c4~11 X-Git-Url: https://git.rkrishnan.org/simplejson/components//%22%22?a=commitdiff_plain;h=0475bd8e27ae83070342cfa95a997662d9bcc861;p=tahoe-lafs%2Ftahoe-lafs.git immutable download: have the finder inform its share consumer "no more shares" in a subsequent tick, thus avoiding accidentally telling it "no more shares" now and then telling it "here's another share" in a subsequent tick fixes #1191 Patch by Brian. This patch description was actually written by Zooko, but I forged Brian's name on the "author" field so that he would get credit for this patch in revision control history. --- diff --git a/src/allmydata/immutable/downloader/finder.py b/src/allmydata/immutable/downloader/finder.py index fa6204c7..4816ccdf 100644 --- a/src/allmydata/immutable/downloader/finder.py +++ b/src/allmydata/immutable/downloader/finder.py @@ -127,7 +127,7 @@ class ShareFinder: # we've run out of servers (so we can't send any more requests), and # we have nothing in flight. No further progress can be made. They # are destined to remain hungry. - self.share_consumer.no_more_shares() + eventually(self.share_consumer.no_more_shares) def send_request(self, server): peerid, rref = server