From: Daira Hopwood Date: Tue, 20 Oct 2015 14:12:36 +0000 (+0100) Subject: Add precondition that arguments to do_cli are strs. X-Git-Url: https://git.rkrishnan.org/specifications/%5B/%5D%20/(%5B%5E?a=commitdiff_plain;h=5215e3e1ac61b1bea7f2def6dad60b8ed0f46f52;p=tahoe-lafs%2Ftahoe-lafs.git Add precondition that arguments to do_cli are strs. Signed-off-by: Daira Hopwood --- diff --git a/src/allmydata/test/test_cli.py b/src/allmydata/test/test_cli.py index 9cfaf659..bed35871 100644 --- a/src/allmydata/test/test_cli.py +++ b/src/allmydata/test/test_cli.py @@ -36,7 +36,7 @@ from twisted.python import usage from allmydata.util.assertutil import precondition from allmydata.util.encodingutil import listdir_unicode, unicode_platform, \ - get_io_encoding, get_filesystem_encoding + get_io_encoding, get_filesystem_encoding, unicode_to_argv timeout = 480 # deep_check takes 360s on Zandr's linksys box, others take > 240s @@ -49,11 +49,14 @@ def parse_options(basedir, command, args): class CLITestMixin(ReallyEqualMixin): def do_cli(self, verb, *args, **kwargs): + precondition(not [True for arg in args if not isinstance(arg, str)], + "arguments to do_cli must be strs -- convert using unicode_to_argv", args=args) + # client_num is used to execute client CLI commands on a specific client. client_num = kwargs.get("client_num", 0) nodeargs = [ - "--node-directory", self.get_clientdir(i=client_num), + "--node-directory", unicode_to_argv(self.get_clientdir(i=client_num)), ] argv = nodeargs + [verb] + list(args) stdin = kwargs.get("stdin", "")