From: David-Sarah Hopwood <david-sarah@jacaranda.org>
Date: Fri, 8 Feb 2013 19:27:57 +0000 (+0000)
Subject: Add comment explaining fix to #1679. refs #1679
X-Git-Tag: allmydata-tahoe-1.10a1~20
X-Git-Url: https://git.rkrishnan.org/specifications/%5B/%5D%20/-?a=commitdiff_plain;h=cdf1752a5d20e050276a32a322b6a508369f1f30;p=tahoe-lafs%2Ftahoe-lafs.git

Add comment explaining fix to #1679. refs #1679

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>
---

diff --git a/src/allmydata/nodemaker.py b/src/allmydata/nodemaker.py
index d590bf5a..d0c00246 100644
--- a/src/allmydata/nodemaker.py
+++ b/src/allmydata/nodemaker.py
@@ -72,6 +72,10 @@ class NodeMaker:
             cap = uri.from_string(bigcap, deep_immutable=deep_immutable,
                                   name=name)
             node = self._create_from_single_cap(cap)
+
+            # node is None for an unknown URI, otherwise it is a type for which
+            # is_mutable() is known. We avoid cacheing mutable nodes due to
+            # ticket #1679.
             if node is None:
                 # don't cache UnknownNode
                 node = UnknownNode(writecap, readcap,