From: Daira Hopwood <daira@jacaranda.org>
Date: Tue, 21 Apr 2015 22:54:25 +0000 (+0100)
Subject: Avoid shadowing a method name.
X-Git-Url: https://git.rkrishnan.org/specifications/components/statistics?a=commitdiff_plain;h=66a61226fdbf5ef3280f9d0d043a77d13b34f903;p=tahoe-lafs%2Ftahoe-lafs.git

Avoid shadowing a method name.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
---

diff --git a/src/allmydata/test/test_drop_upload.py b/src/allmydata/test/test_drop_upload.py
index 77711e44..5e9c2a76 100644
--- a/src/allmydata/test/test_drop_upload.py
+++ b/src/allmydata/test/test_drop_upload.py
@@ -276,7 +276,7 @@ class MockTest(DropUploadTestMixin, unittest.TestCase):
 
         client = self.g.clients[0]
         d = client.create_dirnode()
-        def _made_upload_dir(n):
+        def _check_errors(n):
             self.failUnless(IDirectoryNode.providedBy(n))
             upload_dircap = n.get_uri()
             readonly_dircap = n.get_readonly_uri()
@@ -295,7 +295,7 @@ class MockTest(DropUploadTestMixin, unittest.TestCase):
                             DropUploader, client, 'URI:LIT:foo', errors_dir, 'magicfolderdb', inotify=fake_inotify)
             self.shouldFail(AssertionError, 'readonly upload.dircap', 'is not a writecap to a directory',
                             DropUploader, client, readonly_dircap, errors_dir, 'magicfolderdb', inotify=fake_inotify)
-        d.addCallback(_made_upload_dir)
+        d.addCallback(_check_errors)
         return d
 
     def test_drop_upload(self):