From: Daira Hopwood <daira@jacaranda.org>
Date: Tue, 28 May 2013 21:33:22 +0000 (+0100)
Subject: Cloud backend: suppress unhandled TaskStopped exceptions from FileBodyProducer.
X-Git-Url: https://git.rkrishnan.org/status?a=commitdiff_plain;h=441dd1a7ca957dc1bdaab7d755ec7a686d7d81e4;p=tahoe-lafs%2Ftahoe-lafs.git

Cloud backend: suppress unhandled TaskStopped exceptions from FileBodyProducer.

Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org>
---

diff --git a/src/allmydata/storage/backends/cloud/cloud_common.py b/src/allmydata/storage/backends/cloud/cloud_common.py
index 90fec844..e122dd1c 100644
--- a/src/allmydata/storage/backends/cloud/cloud_common.py
+++ b/src/allmydata/storage/backends/cloud/cloud_common.py
@@ -652,6 +652,18 @@ class DataCollector(Protocol):
         return self._done
 
 
+class QuieterFileBodyProducer(FileBodyProducer):
+    """
+    Workaround for a minor bug in Twisted: losing a connection may result in stopProducing
+    being called twice, causing a spurious unhandled TaskStopped exception to be logged.
+    """
+    def stopProducing(self):
+        try:
+            FileBodyProducer.stopProducing(self)
+        except task.TaskStopped:
+            log.msg("ignoring a harmless TaskStopped exception", level=log.OPERATIONAL)
+
+
 class HTTPClientMixin:
     """
     I implement helper methods for making HTTP requests and getting response headers.
@@ -671,7 +683,7 @@ class HTTPClientMixin:
         if body is None:
             bodyProducer = None
         else:
-            bodyProducer = FileBodyProducer(StringIO(body))
+            bodyProducer = QuieterFileBodyProducer(StringIO(body))
             # We don't need to explicitly set Content-Length because FileBodyProducer knows the length
             # (and if we do it won't work, because in that case Content-Length would be duplicated).