]> git.rkrishnan.org Git - tahoe-lafs/tahoe-lafs.git/log
tahoe-lafs/tahoe-lafs.git
13 years agodebug.py: remove some dead comments
Brian Warner [Sun, 28 Aug 2011 07:45:56 +0000 (00:45 -0700)]
debug.py: remove some dead comments

13 years agohush pyflakes
Brian Warner [Sun, 28 Aug 2011 07:42:54 +0000 (00:42 -0700)]
hush pyflakes

13 years agoMutableFileNode.set_downloader_hints: never depend upon order of dict.values()
Brian Warner [Sun, 28 Aug 2011 07:41:03 +0000 (00:41 -0700)]
MutableFileNode.set_downloader_hints: never depend upon order of dict.values()

The old code was calculating the "extension parameters" (a list) from the
downloader hints (a dictionary) with hints.values(), which is not stable, and
would result in corrupted filecaps (with the 'k' and 'segsize' hints
occasionally swapped). The new code always uses [k,segsize].

13 years agolayout.py: fix MDMF share layout documentation
Brian Warner [Sun, 28 Aug 2011 07:39:21 +0000 (00:39 -0700)]
layout.py: fix MDMF share layout documentation

13 years agoteach 'tahoe debug dump-share' about MDMF and offsets. refs #1507
Brian Warner [Sun, 28 Aug 2011 07:38:34 +0000 (00:38 -0700)]
teach 'tahoe debug dump-share' about MDMF and offsets. refs #1507

13 years agotest_mutable.Version.test_debug: use splitlines() to fix buildslaves
Brian Warner [Sun, 28 Aug 2011 06:47:28 +0000 (23:47 -0700)]
test_mutable.Version.test_debug: use splitlines() to fix buildslaves

Any slave running in a directory with spaces in the name was miscounting
shares, causing the test to fail.

13 years agotest_mutable.Version: exercise 'tahoe debug find-shares' on MDMF. refs #1507
Brian Warner [Sun, 28 Aug 2011 00:55:42 +0000 (17:55 -0700)]
test_mutable.Version: exercise 'tahoe debug find-shares' on MDMF. refs #1507

Also changes NoNetworkGrid to put shares in storage/shares/ .

13 years agotest_mutable.py: oops, missed a .todo
Brian Warner [Sun, 28 Aug 2011 00:21:18 +0000 (17:21 -0700)]
test_mutable.py: oops, missed a .todo

13 years agotest_mutable: merge davidsarah's patch with my Version refactorings
Brian Warner [Sat, 27 Aug 2011 23:57:07 +0000 (16:57 -0700)]
test_mutable: merge davidsarah's patch with my Version refactorings

13 years agoMake the immutable/read-only constraint checking for MDMF URIs identical to that...
david-sarah [Tue, 23 Aug 2011 01:27:20 +0000 (18:27 -0700)]
Make the immutable/read-only constraint checking for MDMF URIs identical to that for SSK URIs. refs #393

13 years agoAdditional tests for MDMF URIs and for zero-length files. refs #393
david-sarah [Tue, 23 Aug 2011 01:15:32 +0000 (18:15 -0700)]
Additional tests for MDMF URIs and for zero-length files. refs #393

13 years agoAdditional tests for zero-length partial reads and updates to mutable versions. refs...
david-sarah [Mon, 22 Aug 2011 01:41:11 +0000 (18:41 -0700)]
Additional tests for zero-length partial reads and updates to mutable versions. refs #393

13 years agotest_mutable.Version: factor out some expensive uploads, save 25% runtime
Brian Warner [Sat, 27 Aug 2011 23:27:37 +0000 (16:27 -0700)]
test_mutable.Version: factor out some expensive uploads, save 25% runtime

13 years agoSDMF: update filenode with correct k/N after Retrieve. Fixes #1510.
Brian Warner [Sat, 27 Aug 2011 22:50:31 +0000 (15:50 -0700)]
SDMF: update filenode with correct k/N after Retrieve. Fixes #1510.

Without this, we get a regression when modifying a mutable file that was
created with more shares (larger N) than our current tahoe.cfg . The
modification attempt creates new versions of the (0,1,..,newN-1) shares, but
leaves the old versions of the (newN,..,oldN-1) shares alone (and throws a
assertion error in SDMFSlotWriteProxy.finish_publishing in the process).

The mixed versions that result (some shares with e.g. N=10, some with N=20,
such that both versions are recoverable) cause problems for the Publish code,
even before MDMF landed. Might be related to refs #1390 and refs #1042.

13 years agolayout.py: annotate assertion to figure out 'tahoe backup' failure
Brian Warner [Sat, 27 Aug 2011 19:52:53 +0000 (12:52 -0700)]
layout.py: annotate assertion to figure out 'tahoe backup' failure

13 years agoAdd 'tahoe debug dump-cap' support for MDMF, DIR2-CHK, DIR2-MDMF. refs #1507.
Brian Warner [Sat, 27 Aug 2011 19:50:48 +0000 (12:50 -0700)]
Add 'tahoe debug dump-cap' support for MDMF, DIR2-CHK, DIR2-MDMF. refs #1507.

This also adds tests for all those cases, and fixes an omission in uri.py
that broke parsing of DIR2-MDMF-Verifier and DIR2-CHK-Verifier.

13 years agoMDMF: more writable/writeable consistentifications
Brian Warner [Sat, 27 Aug 2011 19:06:02 +0000 (12:06 -0700)]
MDMF: more writable/writeable consistentifications

13 years agoMDMF: s/Writable/Writeable/g, for consistency with existing SDMF code
Brian Warner [Sat, 27 Aug 2011 18:33:57 +0000 (11:33 -0700)]
MDMF: s/Writable/Writeable/g, for consistency with existing SDMF code

13 years agosetup.cfg: remove no-longer-supported test_mac_diskimage alias. refs #1479
david-sarah [Fri, 26 Aug 2011 23:03:45 +0000 (16:03 -0700)]
setup.cfg: remove no-longer-supported test_mac_diskimage alias. refs #1479

13 years agotest_mutable.Update: increase timeout from 120s to 400s, slaves are failing
Brian Warner [Thu, 25 Aug 2011 23:01:40 +0000 (16:01 -0700)]
test_mutable.Update: increase timeout from 120s to 400s, slaves are failing

13 years agotests: fix check_memory test
Zooko O'Whielacronx [Thu, 25 Aug 2011 20:11:16 +0000 (13:11 -0700)]
tests: fix check_memory test
fixes #1503

13 years agoTAG allmydata-tahoe-1.9.0a1 allmydata-tahoe-1.9.0a1
Brian Warner [Thu, 25 Aug 2011 16:11:22 +0000 (09:11 -0700)]
TAG allmydata-tahoe-1.9.0a1

13 years agotouch NEWS to trigger buildslaves
Brian Warner [Thu, 25 Aug 2011 16:10:26 +0000 (09:10 -0700)]
touch NEWS to trigger buildslaves

13 years agotest_mutable.Update: remove .timeout overrides, otherwise tests ERROR
Brian Warner [Tue, 23 Aug 2011 21:19:04 +0000 (14:19 -0700)]
test_mutable.Update: remove .timeout overrides, otherwise tests ERROR

13 years agoblacklist.py: add read() method too, for completeness
Brian Warner [Thu, 25 Aug 2011 02:19:02 +0000 (19:19 -0700)]
blacklist.py: add read() method too, for completeness

13 years agoImplementation, tests and docs for blacklists. This version allows listing directorie...
david-sarah [Wed, 24 Aug 2011 15:59:28 +0000 (08:59 -0700)]
Implementation, tests and docs for blacklists. This version allows listing directories containing a blacklisted child. Inclusion of blacklist.py fixed. fixes #1425

13 years agomutable/layout.py: fix unused import. refs #393 post-393
david-sarah [Tue, 16 Aug 2011 22:50:43 +0000 (15:50 -0700)]
mutable/layout.py: fix unused import. refs #393

13 years agomutable/retrieve.py: cosmetics and remove a stale comment. refs #393
david-sarah [Tue, 16 Aug 2011 21:46:12 +0000 (14:46 -0700)]
mutable/retrieve.py: cosmetics and remove a stale comment. refs #393

13 years agomutable/filenode.py: don't fetch more segments than necesasry to update the file
Kevan Carstensen [Sat, 13 Aug 2011 21:00:05 +0000 (14:00 -0700)]
mutable/filenode.py: don't fetch more segments than necesasry to update the file

13 years agotest/test_mutable: test for incorrect div_ceil equations trac-5200
Kevan Carstensen [Sat, 13 Aug 2011 18:39:36 +0000 (11:39 -0700)]
test/test_mutable: test for incorrect div_ceil equations

13 years agomutable/retrieve.py: use floor division to calculate segment boundaries, don't fetch...
Kevan Carstensen [Sat, 13 Aug 2011 18:38:33 +0000 (11:38 -0700)]
mutable/retrieve.py: use floor division to calculate segment boundaries, don't fetch more segments than necessary

13 years agomdmf: clean up boolean expressions, correct typos, remove self._paused, and don't...
Kevan Carstensen [Sat, 13 Aug 2011 18:37:10 +0000 (11:37 -0700)]
mdmf: clean up boolean expressions, correct typos, remove self._paused, and don't unconditionally initialize block hash trees, asll as suggested by davidsarahs' review comments

13 years agonow that tests pass with full-size keys, return test-keys to normal (522bit)
Brian Warner [Thu, 11 Aug 2011 17:54:18 +0000 (10:54 -0700)]
now that tests pass with full-size keys, return test-keys to normal (522bit)

13 years agofix SHARE_HASH_CHAIN_SIZE computation
Brian Warner [Thu, 11 Aug 2011 17:53:50 +0000 (10:53 -0700)]
fix SHARE_HASH_CHAIN_SIZE computation

13 years agoMore idiomatic resolution of the conflict between ticket393-MDMF-2 and trunk. refs...
david-sarah [Wed, 10 Aug 2011 20:29:42 +0000 (13:29 -0700)]
More idiomatic resolution of the conflict between ticket393-MDMF-2 and trunk. refs #393

13 years agoReplace the hard-coded 522-bit RSA key size used for tests with a TEST_RSA_KEY_SIZE...
david-sarah [Wed, 10 Aug 2011 20:23:10 +0000 (13:23 -0700)]
Replace the hard-coded 522-bit RSA key size used for tests with a TEST_RSA_KEY_SIZE constant defined in test/common.py (part 2). refs #393

13 years agoReplace the hard-coded 522-bit RSA key size used for tests with a TEST_RSA_KEY_SIZE...
david-sarah [Wed, 10 Aug 2011 20:22:43 +0000 (13:22 -0700)]
Replace the hard-coded 522-bit RSA key size used for tests with a TEST_RSA_KEY_SIZE constant defined in test/common.py (part 1). refs #393

13 years agomerge some minor conflicts in test code from the 393-2 branch and trunk
Zooko O'Whielacronx [Wed, 10 Aug 2011 17:21:39 +0000 (10:21 -0700)]
merge some minor conflicts in test code from the 393-2 branch and trunk

13 years agodoc: eliminate the phrase "rootcap" from doc/frontends/FTP-and-SFTP.rst
Zooko O'Whielacronx [Tue, 9 Aug 2011 13:26:01 +0000 (06:26 -0700)]
doc: eliminate the phrase "rootcap" from doc/frontends/FTP-and-SFTP.rst
Two different people have asked me for help, saying they couldn't figure out what a "rootcap" is. Hopefully just calling it a "cap" will make it easier for them to find out from the other docs what it is.

13 years agotest_web.py: fix a test failure dependent on whether simplejson.loads returns a unico...
david-sarah [Mon, 8 Aug 2011 21:39:25 +0000 (14:39 -0700)]
test_web.py: fix a test failure dependent on whether simplejson.loads returns a unicode or str object.

13 years agoimmutable/filenode: fix pyflakes warnings
Kevan Carstensen [Sun, 7 Aug 2011 00:45:14 +0000 (17:45 -0700)]
immutable/filenode: fix pyflakes warnings

13 years agotest: fix assorted tests broken by MDMF changes
Kevan Carstensen [Sun, 7 Aug 2011 00:44:59 +0000 (17:44 -0700)]
test: fix assorted tests broken by MDMF changes

13 years agouri: add MDMF and MDMF directory caps, add extension hint support
Kevan Carstensen [Sun, 7 Aug 2011 00:44:36 +0000 (17:44 -0700)]
uri: add MDMF and MDMF directory caps, add extension hint support

13 years agotest/test_mutable: tests for MDMF
Kevan Carstensen [Sun, 7 Aug 2011 00:44:14 +0000 (17:44 -0700)]
test/test_mutable: tests for MDMF

These are their own patch because they cut across a lot of the changes
I've made in implementing MDMF in such a way as to make it difficult to
split them up into the other patches.

13 years agowebapi changes for MDMF
Kevan Carstensen [Sun, 7 Aug 2011 00:43:48 +0000 (17:43 -0700)]
webapi changes for MDMF

    - Learn how to create MDMF files and directories through the
      mutable-type argument.
    - Operate with the interface changes associated with MDMF and #993.
    - Learn how to do partial updates of mutable files.

13 years agomutable/servermap: Rework the servermap to work with MDMF mutable files
Kevan Carstensen [Sun, 7 Aug 2011 00:42:59 +0000 (17:42 -0700)]
mutable/servermap: Rework the servermap to work with MDMF mutable files

13 years agodirnode: teach dirnode to make MDMF directories
Kevan Carstensen [Sun, 7 Aug 2011 00:42:24 +0000 (17:42 -0700)]
dirnode: teach dirnode to make MDMF directories

13 years agoFix some test failures caused by #393 patch.
david-sarah [Tue, 2 Aug 2011 03:28:10 +0000 (20:28 -0700)]
Fix some test failures caused by #393 patch.

13 years agodocs: amend configuration, webapi documentation to talk about MDMF
Kevan Carstensen [Tue, 2 Aug 2011 02:20:56 +0000 (19:20 -0700)]
docs: amend configuration, webapi documentation to talk about MDMF

13 years agocli: teach CLI how to create MDMF mutable files
Kevan Carstensen [Tue, 2 Aug 2011 02:16:13 +0000 (19:16 -0700)]
cli: teach CLI how to create MDMF mutable files

Specifically, 'tahoe mkdir' and 'tahoe put' now take a --mutable-type
argument.

13 years agofrontends/sftpd: Resolve incompatibilities between SFTP frontend and MDMF changes
Kevan Carstensen [Tue, 2 Aug 2011 02:12:07 +0000 (19:12 -0700)]
frontends/sftpd: Resolve incompatibilities between SFTP frontend and MDMF changes

13 years agomutable/layout: Define MDMF share format, write tools for working with MDMF share...
Kevan Carstensen [Tue, 2 Aug 2011 02:11:20 +0000 (19:11 -0700)]
mutable/layout: Define MDMF share format, write tools for working with MDMF share format

The changes in layout.py are mostly concerned with the MDMF share
format. In particular, we define read and write proxy objects used by
retrieval, publishing, and other code to write and read the MDMF share
format. We create equivalent proxies for SDMF objects so that these
objects can be suitably general.

13 years agoimmutable/filenode: implement unified filenode interface
Kevan Carstensen [Tue, 2 Aug 2011 02:09:05 +0000 (19:09 -0700)]
immutable/filenode: implement unified filenode interface

13 years agoimmutable/literal.py: Implement interface changes in literal nodes.
Kevan Carstensen [Tue, 2 Aug 2011 02:08:14 +0000 (19:08 -0700)]
immutable/literal.py: Implement interface changes in literal nodes.

13 years agotest/common: Alter common test code to work with MDMF.
Kevan Carstensen [Tue, 2 Aug 2011 01:56:43 +0000 (18:56 -0700)]
test/common: Alter common test code to work with MDMF.

This mostly has to do with making the test code implement the new
unified filenode interfaces.

13 years agomutable: train checker and repairer to work with MDMF mutable files
Kevan Carstensen [Tue, 2 Aug 2011 01:51:40 +0000 (18:51 -0700)]
mutable: train checker and repairer to work with MDMF mutable files

13 years agonodemaker: teach nodemaker about MDMF caps
Kevan Carstensen [Tue, 2 Aug 2011 01:49:26 +0000 (18:49 -0700)]
nodemaker: teach nodemaker about MDMF caps

13 years agoclient: teach client how to create and work with MDMF files
Kevan Carstensen [Tue, 2 Aug 2011 01:48:11 +0000 (18:48 -0700)]
client: teach client how to create and work with MDMF files

13 years agomutable/filenode: Modify mutable filenodes for use with MDMF
Kevan Carstensen [Tue, 2 Aug 2011 01:45:01 +0000 (18:45 -0700)]
mutable/filenode: Modify mutable filenodes for use with MDMF

In particular:
    - Break MutableFileNode and MutableFileVersion into distinct classes.
    - Implement the interface modifications made for MDMF.
    - Be aware of MDMF caps.
    - Learn how to create and work with MDMF files.

13 years agonodemaker: teach nodemaker how to create MDMF mutable files
Kevan Carstensen [Tue, 2 Aug 2011 01:42:58 +0000 (18:42 -0700)]
nodemaker: teach nodemaker how to create MDMF mutable files

13 years agointerfaces: change interfaces to work with MDMF
Kevan Carstensen [Tue, 2 Aug 2011 01:41:19 +0000 (18:41 -0700)]
interfaces: change interfaces to work with MDMF

A lot of this work concerns #993, in that it unifies (to an extent) the
interfaces of mutable and immutable files.

13 years agomutable/publish: teach the publisher how to publish MDMF mutable files
Kevan Carstensen [Tue, 2 Aug 2011 01:39:31 +0000 (18:39 -0700)]
mutable/publish: teach the publisher how to publish MDMF mutable files

Like the downloader, the publisher needs some substantial changes to handle multiple segment mutable files.

13 years agomutable/retrieve: rework the mutable downloader to handle multiple-segment files
Kevan Carstensen [Tue, 2 Aug 2011 01:35:24 +0000 (18:35 -0700)]
mutable/retrieve: rework the mutable downloader to handle multiple-segment files

The downloader needs substantial reworking to handle multiple segment
mutable files, which it needs to handle for MDMF.

13 years agoFix repeated 'the' in license text. pre-393
david-sarah [Fri, 19 Aug 2011 20:48:36 +0000 (13:48 -0700)]
Fix repeated 'the' in license text.

13 years agoRemove Non-Profit Open Software License from the set of 'added permission' licenses...
david-sarah [Fri, 19 Aug 2011 20:47:42 +0000 (13:47 -0700)]
Remove Non-Profit Open Software License from the set of 'added permission' licenses. Although it actually does qualify as an Open Source license (because it allows relicensing under plain OSL), its wording is unclear and could easily be misunderstood, and it contributes to incompatible license proliferation.

13 years agodocs: change links that pointed to COPYING.TGPPL.html to point to COPYING.TGPPL.rst...
Zooko O'Whielacronx [Fri, 19 Aug 2011 06:01:42 +0000 (23:01 -0700)]
docs: change links that pointed to COPYING.TGPPL.html to point to COPYING.TGPPL.rst instead

13 years agodocs: formatting: reflow to fill-column 77
Zooko O'Whielacronx [Fri, 19 Aug 2011 06:01:10 +0000 (23:01 -0700)]
docs: formatting: reflow to fill-column 77

13 years agodocs: formatting: M-x whitespace-cleanup
Zooko O'Whielacronx [Fri, 19 Aug 2011 06:00:41 +0000 (23:00 -0700)]
docs: formatting: M-x whitespace-cleanup

13 years agolicensing: add to the list of licenses that we grant the added permission for
Zooko O'Whielacronx [Fri, 19 Aug 2011 05:46:56 +0000 (22:46 -0700)]
licensing: add to the list of licenses that we grant the added permission for
Added: most of the ones listed on the FSF's "List of Free Software, GPL Incompatible Licenses", plus the Non-Profit Open Software License.

13 years agodocs: reflow the added text at the top of COPYING.GPL to fill-column 77
Zooko O'Whielacronx [Fri, 19 Aug 2011 05:30:59 +0000 (22:30 -0700)]
docs: reflow the added text at the top of COPYING.GPL to fill-column 77

13 years agodocs: reformat COPYING.TGPPL.html to COPYING.TGPPL.rst
Zooko O'Whielacronx [Fri, 19 Aug 2011 05:27:53 +0000 (22:27 -0700)]
docs: reformat COPYING.TGPPL.html to COPYING.TGPPL.rst

13 years agodocs: reflow docs/logging.rst to fill-column 77
Zooko O'Whielacronx [Fri, 19 Aug 2011 04:41:03 +0000 (21:41 -0700)]
docs: reflow docs/logging.rst to fill-column 77

13 years agodoc: fix formatting error in docs/logging.rst
Zooko O'Whielacronx [Fri, 19 Aug 2011 04:39:46 +0000 (21:39 -0700)]
doc: fix formatting error in docs/logging.rst

13 years agoCleanups for suppression of UserWarnings. refs #1435
david-sarah [Thu, 18 Aug 2011 04:07:49 +0000 (21:07 -0700)]
Cleanups for suppression of UserWarnings. refs #1435

13 years agosuppress warning emitted by newer zope.interface with Nevow 0.10
Zooko O'Whielacronx [Wed, 17 Aug 2011 20:31:34 +0000 (13:31 -0700)]
suppress warning emitted by newer zope.interface with Nevow 0.10
refs #1435

13 years agodoc: formatting: reflow to fill-column=77
Zooko O'Whielacronx [Tue, 9 Aug 2011 13:25:10 +0000 (06:25 -0700)]
doc: formatting: reflow to fill-column=77

13 years ago_auto_deps.py: change the requirement for zope.interface to <= 3.6.2, >= 3.6.6. fixes...
david-sarah [Mon, 15 Aug 2011 02:53:47 +0000 (19:53 -0700)]
_auto_deps.py: change the requirement for zope.interface to <= 3.6.2, >= 3.6.6. fixes #1435

13 years agoallmydata/__init__.py, test_version.py: make version parsing understand '<=', with...
david-sarah [Mon, 15 Aug 2011 03:51:53 +0000 (20:51 -0700)]
allmydata/__init__.py, test_version.py: make version parsing understand '<=', with test. refs #1435

13 years agoMakefile and setup.py: remove setup.py commands that we no longer need, and their...
david-sarah [Mon, 1 Aug 2011 03:19:52 +0000 (20:19 -0700)]
Makefile and setup.py: remove setup.py commands that we no longer need, and their uses in the Makefile. Delete a stale and incorrect comment about updating _version.py. Also fix some coding style checks in the Makefile to operate on all source files.

13 years agoremove misc/debian[_helpers], rely upon official packaging instead. fixes #1454
Brian Warner [Thu, 11 Aug 2011 18:27:05 +0000 (11:27 -0700)]
remove misc/debian[_helpers], rely upon official packaging instead. fixes #1454

13 years agoMakefile: remove targets that used misc/debian[_helpers] which no longer exist. Also...
david-sarah [Mon, 1 Aug 2011 03:18:57 +0000 (20:18 -0700)]
Makefile: remove targets that used misc/debian[_helpers] which no longer exist. Also change docs/debian.rst to reflect the fact that we no longer support building .debs using those targets. refs #1454

13 years agoreplace tabs with spaces in the #1441 'tahoe debug' synopsis
Brian Warner [Thu, 11 Aug 2011 17:37:04 +0000 (10:37 -0700)]
replace tabs with spaces in the #1441 'tahoe debug' synopsis

13 years agoCorrect the information printed by '/usr/bin/tahoe debug --help' on Debian/Ubuntu...
david-sarah [Sun, 24 Jul 2011 16:25:30 +0000 (09:25 -0700)]
Correct the information printed by '/usr/bin/tahoe debug --help' on Debian/Ubuntu. fixes #1441

13 years agodoc: edit the explanation of K-of-N tradeoffs
Zooko O'Whielacronx [Thu, 4 Aug 2011 19:34:09 +0000 (12:34 -0700)]
doc: edit the explanation of K-of-N tradeoffs

13 years agodoc: clean up formatting of doc/configuration.rst
Zooko O'Whielacronx [Thu, 4 Aug 2011 19:27:22 +0000 (12:27 -0700)]
doc: clean up formatting of doc/configuration.rst
reflow to 77 chars line width, M-x white-space cleanup, blank link between name and definition

13 years agoAdd test for webopen. fixes #1149
david-sarah [Sun, 24 Jul 2011 21:16:59 +0000 (14:16 -0700)]
Add test for webopen. fixes #1149

13 years agotest_client.py: relax a check in test_create_drop_uploader so that it should pass...
david-sarah [Wed, 10 Aug 2011 05:25:04 +0000 (22:25 -0700)]
test_client.py: relax a check in test_create_drop_uploader so that it should pass on Python 2.4.x. refs #1429

13 years agotest/common_util.py: correct fix to mkdir_nonascii. refs #1472
david-sarah [Wed, 10 Aug 2011 05:19:06 +0000 (22:19 -0700)]
test/common_util.py: correct fix to mkdir_nonascii. refs #1472

13 years agotest/common_util.py: fix a typo. refs #1472
david-sarah [Wed, 10 Aug 2011 04:42:35 +0000 (21:42 -0700)]
test/common_util.py: fix a typo. refs #1472

13 years agotest_client.py, test_drop_upload.py: fix pyflakes warnings.
david-sarah [Wed, 10 Aug 2011 03:45:05 +0000 (20:45 -0700)]
test_client.py, test_drop_upload.py: fix pyflakes warnings.

13 years agoFactor out methods dealing with non-ASCII directories and filenames from test_drop_up...
david-sarah [Wed, 10 Aug 2011 03:15:58 +0000 (20:15 -0700)]
Factor out methods dealing with non-ASCII directories and filenames from test_drop_upload.py into common_util.py. refs #1429, #1472

13 years agotest_client.py: add a test that the drop-uploader is initialized correctly by client...
david-sarah [Wed, 10 Aug 2011 03:05:38 +0000 (20:05 -0700)]
test_client.py: add a test that the drop-uploader is initialized correctly by client.py. Also give the DropUploader service a name, which is necessary for the test. refs #1429

13 years agodrop-upload: rename 'start' method to 'startService', which is what you're supposed...
david-sarah [Wed, 10 Aug 2011 03:03:45 +0000 (20:03 -0700)]
drop-upload: rename 'start' method to 'startService', which is what you're supposed to use to start a Service. refs #1429

13 years agotest_drop_upload.py: add comment explaining why we don't use FilePath.setContent...
david-sarah [Wed, 10 Aug 2011 02:59:42 +0000 (19:59 -0700)]
test_drop_upload.py: add comment explaining why we don't use FilePath.setContent. refs #1429

13 years agotest_drop_upload.py: fix some grammatical and spelling nits. refs #1429
david-sarah [Tue, 9 Aug 2011 22:12:31 +0000 (15:12 -0700)]
test_drop_upload.py: fix some grammatical and spelling nits. refs #1429

13 years agodrop-upload: report the configured local directory being absent differently from...
Zooko O'Whielacronx [Tue, 9 Aug 2011 22:09:30 +0000 (15:09 -0700)]
drop-upload: report the configured local directory being absent differently from it being a file
refs #1429

13 years agodrop-upload: rename the 'upload.uri' parameter to 'upload.dircap', and a couple of...
Zooko O'Whielacronx [Tue, 9 Aug 2011 22:05:08 +0000 (15:05 -0700)]
drop-upload: rename the 'upload.uri' parameter to 'upload.dircap', and a couple of cleanups to error messages. refs #1429
I rerecorded this patch, originally by David-Sarah, to use "darcs replace" instead of editing to do the renames. This uncovered one missed rename in Client.init_drop_uploader. (Which also means that code isn't exercised by the current unit tests.)
refs #1429

13 years agodrop-upload test for non-existent local dir separately from test for non-directory...
Zooko O'Whielacronx [Tue, 9 Aug 2011 22:01:15 +0000 (15:01 -0700)]
drop-upload test for non-existent local dir separately from test for non-directory local dir
A candidate patch for #1429 has a bug when it is using FilePath.is_dir() to detect whether the configured local dir exists and is a directory. FilePath.is_dir() raises exception, instead of returning False, if the thing doesn't exist. This test is to make sure that DropUploader.__init__ raise different exceptions for those two cases.
refs #1429

13 years agodrop-upload: unit tests for the configuration options being named "cap" instead of...
Zooko O'Whielacronx [Tue, 9 Aug 2011 21:59:13 +0000 (14:59 -0700)]
drop-upload: unit tests for the configuration options being named "cap" instead of "uri"
This is a subset of a patch that David-Sarah attached to #1429. This is just the unit-tests part of that patch, and uses darcs record instead of hunks to change the names.
refs #1429

13 years agosrc/allmydata/storage/server.py: use the filesystem of storage/shares/, rather than...
david-sarah [Tue, 19 Jul 2011 02:27:52 +0000 (19:27 -0700)]
src/allmydata/storage/server.py: use the filesystem of storage/shares/, rather than storage/, to calculate remaining space. fixes #1384