setup: remove the dependency on foolscap's "secure_connections" extra, add a dependen...

fixes #1383

diff --git a/src/allmydata/_auto_deps.py b/src/allmydata/_auto_deps.py
index 45a6f2407be06882d1446c69cd5b922fc95ba2d4..e8ff4bc771af89907ceab07be13ccde111debbd9 100644 (file)
--- a/src/allmydata/_auto_deps.py
+++ b/src/allmydata/_auto_deps.py
@@ -23,7 +23,16 @@ install_requires = [
     # of size N.
     # foolscap < 0.6 is incompatible with Twisted 10.2.0.
     # foolscap 0.6.1 quiets a DeprecationWarning.
-    "foolscap[secure_connections] >= 0.6.1",
+    # pyOpenSSL is required by foolscap for it (foolscap) to provide secure
+    # connections. Foolscap doesn't reliably declare this dependency in a
+    # machine-readable way, so we need to declare a dependency on pyOpenSSL
+    # ourselves. Tahoe-LAFS doesn't *really* depend directly on pyOpenSSL,
+    # so if something changes in the relationship between foolscap and
+    # pyOpenSSL, such as foolscap requiring a specific version of pyOpenSSL,
+    # or foolscap switching from pyOpenSSL to a different crypto library, we
+    # need to update this declaration here.
+    "foolscap >= 0.6.1",
+    "pyOpenSSL",
 
     "Nevow >= 0.6.0",