Don't hardcode the encoded form of "/".

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Rename encoded_name_u to encoded_path_u.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Rename did_upload_file to did_upload_version, and is_new_file_time to is_new_file.
Make them take a PathInfo argument rather than (mtime, ctime, size).
Also treat the size of a nonexistent file as None (SQL NULL) rather than 0.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Make the PathInfo returned by get_pathinfo for a nonexistent path use "now" for ctime and mtime.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Cleanups relating to order of mtime and ctime.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

FilePath-related changes. refs ticket:2506

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Teach magic-folder test helpers to use passed in clock

Teach magic-folder to use passed in clock instead of global reactor

Teach Uploader to ignore files unless they've changed

- specifically we compare the ctime, mtime and size with the
entry in magic-folder db.

Fix is_new_file_time by converting floats to int

Fix an oversight in the design doc.

Teach test_alice_bob to fail if local version is wrong

Make sure that the 'processed' hook is run for calls to _process from scan.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Debug prints.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Improve logging of HookMixin.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Ignore files with ignorable names.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix an oversight when joining paths.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Relative paths used by magic folder are '/'-separated on all platforms.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Make sure that a path is in the pending set before calling Uploader._process on it.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Make assertions about objects_failed counts.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Comment out bad/unfinished test code.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix objects_queued counter.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

The type of deque elements differs between the uploader and downloader.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Debug prints.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Include client nickname in magic folder log messages.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Delete process_child.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Reenable debug prints.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix relative path calculation WIP.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Enforce that paths are below the magic folder directory -- WIP.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Remove superfluous debugging print statement

Fix another rebasing error.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix an import that broke during rebasing.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Remove or comment out print statements and improve logging.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Remove MagicFolderTestMixin._create_magicfolder.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Remove MagicFolderCLITestMixin.create_magicfolder.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Minor cleanup.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Remove redundant inotify parameters to MagicFolder and Uploader constructors.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Ensure that fake_inotify is used for restarted clients in MockTest.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Compare size and ctime as well as mtime.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix test bug that accidentally suppressed errors.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Teach should_ignore_file to require unicode

Simply should_ignore_file helper function

Activate test_alice_bob test

it was previously renamed to ommit it from unit test runs

Remove old debugging print statements

WIP

remove debug print statements

Fix version incrementation bug

only increment if mtimes are differing...

Add is_new_file_time db helper function

this is for comparing mtimes

Fix bug in Downloader's _get_local_latest

previously the magic-folder path was not prepended
to the file path... thus the file didn't exist and
the call to _get_local_latest returned None.

Teach test_persistence to only use one clientdir

This effectively fixes the bug where upon restart the client
uses a different clientdir

WIP

fix unit test helper _wait_until_started by using ready()

Teach test_persistence to upload a 2nd file

test fails...

Teach test_persistence to restart client with the new no network grid api changes

Add should_ignore_file and tests

This helper function will be used by magic-folder to
determine when to drop a file from the upload queue...
it ignores hidden files and certain suffixed files.

Repair test_replace_file for the case where the replaced file did not already exist
(which is no longer considered an error).

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Repair test.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

restart_client needs to remove the old client from its parent, not just stop it.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

startService can be called more than once.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Comment out some print statements.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Cleanup of _restart_client.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix a logging bug for Unicode nicknames.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

WIP

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Solve a potential race condition by waiting until the uploader is started.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Remove self.client and stats_provider attributes which could get out-of-sync with self.get_client().

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Add 'started' hook to Magic Folder uploader.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Remove unused variables.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Add _restart_client callback.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

stopService does not necessarily return a Deferred.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Add a restart_client method to GridTestMixin.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Rename test_cli_magic_folder.MagicFolderTestMixin to MagicFolderCLITestMixin.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Add print statements.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

WIP

Revert "Attempt to fix test_persistence"

This reverts commit 257d6665d29454351886d9c1125d214b21c324f7.

Attempt to fix test_persistence

broken WIP, startup path was broken

Add db util function for retrieving all downloaded files

More precise and correct error reporting in replace_file.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Fix path handling in Downloader._process.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Make _write_downloaded_file return the path of the destination file.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

replace_file should not fail if replaced_path does not exist.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Move the test for _write_download_file() to test_magic_folder module

WIP: test for _write_downloaded_file

more debugging print statements

Uncomment alice bob test print statements

Remove stupid errback and raise proper conflict exception

Fix replace_file; rename only if replaced_path exists

Add err print statement to show the conflict...

Capture exceptions from conflict and write info in magic folder db

Fix _write_downloaded_file by adding base path

Correct spelling is os.utime not utimes

Add Downloader._write_downloaded_file. refs ticket:2489

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Remove debug prints in backupdb.py.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Remove or comment out print statements.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Rename Client.upload_ready_d to connected_enough_d.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

In Downloader._get_collective_latest_file, consume errors when getting metadata.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Teach uploader to process lazy tail upon stop method

Teach magic-folder ready method to return a deferred

Fix a bug in Downloader._scan_remote that incorrectly skips subsequent files
(and drops a Deferred) when local version >= remote version.
Also simplify that code and robustify it for the case where the version metadata is missing.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Use deferredutil.HookMixin to simplify callback for tests.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

Minor fix to alice bob test